From: Sinan Kaya <okaya@codeaurora.org> To: Eric Auger <eric.auger@linaro.org>, kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com Cc: linux-acpi@vger.kernel.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Baptiste Reynal <b.reynal@virtualopensystems.com>, Alex Williamson <alex.williamson@redhat.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI Date: Mon, 23 May 2016 22:23:26 -0400 [thread overview] Message-ID: <5743BB1E.10607@codeaurora.org> (raw) In-Reply-To: <574316B0.5080306@linaro.org> On 5/23/2016 10:41 AM, Eric Auger wrote: > On 05/16/2016 04:13 AM, Sinan Kaya wrote: >> The device tree code checks for the presence of a reset driver and calls >> the of_reset function pointer by looking up the reset driver as a module. >> >> ACPI defines _RST method to perform device level reset. After the _RST >> method is executed, the OS can resume using the device. >> >> This patch checks the presence of _RST method and calls the _RST >> method when reset is requested. >> >> Signed-off-by: Sinan Kaya <okaya@codeaurora.org> >> --- >> drivers/vfio/platform/vfio_platform_common.c | 44 ++++++++++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> >> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c >> index d859d3b..095d5b7 100644 >> --- a/drivers/vfio/platform/vfio_platform_common.c >> +++ b/drivers/vfio/platform/vfio_platform_common.c >> @@ -73,21 +73,59 @@ int vfio_platform_acpi_probe(struct vfio_platform_device *vdev, >> } >> return 0; >> } >> + >> +static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev) >> +{ >> + struct device *dev = vdev->device; >> + acpi_handle handle = ACPI_HANDLE(dev); >> + acpi_status acpi_ret; >> + unsigned long long val; >> + >> + acpi_ret = acpi_evaluate_integer(handle, "_RST", NULL, &val); >> + if (ACPI_FAILURE(acpi_ret)) >> + return -EINVAL; >> + >> + return 0; >> +} >> + >> +static bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev) >> +{ >> + struct device *dev = vdev->device; >> + acpi_handle handle = ACPI_HANDLE(dev); >> + >> + return acpi_has_method(handle, "_RST"); >> +} >> #else >> int vfio_platform_acpi_probe(struct vfio_platform_device *vdev, >> struct device *dev) >> { >> return -EINVAL; >> } >> + >> +static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev) >> +{ > nit: inline >> + return -EINVAL; >> +} >> + >> +static bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev) > nit: inline sure > > Besides Reviewed-by: Eric Auger <eric.auger@linaro.org> > thanks > It is not explictly written in the ACPI spec that _RST is expected to > stop DMA transfers and IRQs although this may be implicit in the notion > of "function level reset ". May be worth adding this info in the commit msg? > yes, I'll add DMA and IRQ requirement to the commit message. > Best Regards > > Eric >> +{ >> + return false; >> +} >> #endif >> >> static bool vfio_platform_has_reset(struct vfio_platform_device *vdev) >> { >> + if (vdev->acpihid) >> + return vfio_platform_acpi_has_reset(vdev); >> + >> return vdev->of_reset ? true : false; >> } >> >> static void vfio_platform_get_reset(struct vfio_platform_device *vdev) >> { >> + if (vdev->acpihid) >> + return; >> + >> vdev->of_reset = vfio_platform_lookup_reset(vdev->compat, >> &vdev->reset_module); >> if (!vdev->of_reset) { >> @@ -99,6 +137,9 @@ static void vfio_platform_get_reset(struct vfio_platform_device *vdev) >> >> static void vfio_platform_put_reset(struct vfio_platform_device *vdev) >> { >> + if (vdev->acpihid) >> + return; >> + >> if (vdev->of_reset) >> module_put(vdev->reset_module); >> } >> @@ -177,6 +218,9 @@ static int vfio_platform_call_reset(struct vfio_platform_device *vdev) >> dev_info(vdev->device, "reset\n"); >> vdev->of_reset(vdev); >> return 0; >> + } else if (vdev->acpihid) { >> + dev_info(vdev->device, "reset\n"); >> + return vfio_platform_acpi_call_reset(vdev); >> } >> >> dev_warn(vdev->device, "no reset function found!\n"); >> > -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI Date: Mon, 23 May 2016 22:23:26 -0400 [thread overview] Message-ID: <5743BB1E.10607@codeaurora.org> (raw) In-Reply-To: <574316B0.5080306@linaro.org> On 5/23/2016 10:41 AM, Eric Auger wrote: > On 05/16/2016 04:13 AM, Sinan Kaya wrote: >> The device tree code checks for the presence of a reset driver and calls >> the of_reset function pointer by looking up the reset driver as a module. >> >> ACPI defines _RST method to perform device level reset. After the _RST >> method is executed, the OS can resume using the device. >> >> This patch checks the presence of _RST method and calls the _RST >> method when reset is requested. >> >> Signed-off-by: Sinan Kaya <okaya@codeaurora.org> >> --- >> drivers/vfio/platform/vfio_platform_common.c | 44 ++++++++++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> >> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c >> index d859d3b..095d5b7 100644 >> --- a/drivers/vfio/platform/vfio_platform_common.c >> +++ b/drivers/vfio/platform/vfio_platform_common.c >> @@ -73,21 +73,59 @@ int vfio_platform_acpi_probe(struct vfio_platform_device *vdev, >> } >> return 0; >> } >> + >> +static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev) >> +{ >> + struct device *dev = vdev->device; >> + acpi_handle handle = ACPI_HANDLE(dev); >> + acpi_status acpi_ret; >> + unsigned long long val; >> + >> + acpi_ret = acpi_evaluate_integer(handle, "_RST", NULL, &val); >> + if (ACPI_FAILURE(acpi_ret)) >> + return -EINVAL; >> + >> + return 0; >> +} >> + >> +static bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev) >> +{ >> + struct device *dev = vdev->device; >> + acpi_handle handle = ACPI_HANDLE(dev); >> + >> + return acpi_has_method(handle, "_RST"); >> +} >> #else >> int vfio_platform_acpi_probe(struct vfio_platform_device *vdev, >> struct device *dev) >> { >> return -EINVAL; >> } >> + >> +static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev) >> +{ > nit: inline >> + return -EINVAL; >> +} >> + >> +static bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev) > nit: inline sure > > Besides Reviewed-by: Eric Auger <eric.auger@linaro.org> > thanks > It is not explictly written in the ACPI spec that _RST is expected to > stop DMA transfers and IRQs although this may be implicit in the notion > of "function level reset ". May be worth adding this info in the commit msg? > yes, I'll add DMA and IRQ requirement to the commit message. > Best Regards > > Eric >> +{ >> + return false; >> +} >> #endif >> >> static bool vfio_platform_has_reset(struct vfio_platform_device *vdev) >> { >> + if (vdev->acpihid) >> + return vfio_platform_acpi_has_reset(vdev); >> + >> return vdev->of_reset ? true : false; >> } >> >> static void vfio_platform_get_reset(struct vfio_platform_device *vdev) >> { >> + if (vdev->acpihid) >> + return; >> + >> vdev->of_reset = vfio_platform_lookup_reset(vdev->compat, >> &vdev->reset_module); >> if (!vdev->of_reset) { >> @@ -99,6 +137,9 @@ static void vfio_platform_get_reset(struct vfio_platform_device *vdev) >> >> static void vfio_platform_put_reset(struct vfio_platform_device *vdev) >> { >> + if (vdev->acpihid) >> + return; >> + >> if (vdev->of_reset) >> module_put(vdev->reset_module); >> } >> @@ -177,6 +218,9 @@ static int vfio_platform_call_reset(struct vfio_platform_device *vdev) >> dev_info(vdev->device, "reset\n"); >> vdev->of_reset(vdev); >> return 0; >> + } else if (vdev->acpihid) { >> + dev_info(vdev->device, "reset\n"); >> + return vfio_platform_acpi_call_reset(vdev); >> } >> >> dev_warn(vdev->device, "no reset function found!\n"); >> > -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-05-24 2:23 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-16 2:13 [PATCH V5 0/6] vfio, platform: add ACPI support Sinan Kaya 2016-05-16 2:13 ` Sinan Kaya 2016-05-16 2:13 ` [PATCH V5 1/6] vfio: platform: rename reset function Sinan Kaya 2016-05-16 2:13 ` Sinan Kaya 2016-05-16 2:13 ` Sinan Kaya 2016-05-23 12:52 ` Eric Auger 2016-05-23 12:52 ` Eric Auger 2016-05-16 2:13 ` [PATCH V5 2/6] vfio: platform: move reset call to a common function Sinan Kaya 2016-05-16 2:13 ` Sinan Kaya 2016-05-23 13:02 ` Eric Auger 2016-05-23 13:02 ` Eric Auger 2016-05-24 2:14 ` Sinan Kaya 2016-05-24 2:14 ` Sinan Kaya 2016-05-16 2:13 ` [PATCH V5 3/6] vfio: platform: determine reset capability Sinan Kaya 2016-05-16 2:13 ` Sinan Kaya 2016-05-16 2:13 ` Sinan Kaya 2016-05-23 13:16 ` Eric Auger 2016-05-23 13:16 ` Eric Auger 2016-05-16 2:13 ` [PATCH V5 4/6] vfio: platform: add support for ACPI probe Sinan Kaya 2016-05-16 2:13 ` Sinan Kaya 2016-05-23 13:18 ` Eric Auger 2016-05-23 13:18 ` Eric Auger 2016-05-24 2:18 ` Sinan Kaya 2016-05-24 2:18 ` Sinan Kaya 2016-06-07 16:33 ` Auger Eric 2016-06-07 16:33 ` Auger Eric 2016-06-07 16:33 ` Auger Eric 2016-05-16 2:13 ` [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI Sinan Kaya 2016-05-16 2:13 ` Sinan Kaya 2016-05-23 14:41 ` Eric Auger 2016-05-23 14:41 ` Eric Auger 2016-05-24 2:23 ` Sinan Kaya [this message] 2016-05-24 2:23 ` Sinan Kaya 2016-05-23 15:21 ` Eric Auger 2016-05-23 15:21 ` Eric Auger 2016-05-24 2:25 ` Sinan Kaya 2016-05-24 2:25 ` Sinan Kaya 2016-05-16 2:13 ` [PATCH V5 6/6] vfio, platform: make reset driver a requirement by default Sinan Kaya 2016-05-16 2:13 ` Sinan Kaya 2016-05-23 15:20 ` Eric Auger 2016-05-23 15:20 ` Eric Auger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5743BB1E.10607@codeaurora.org \ --to=okaya@codeaurora.org \ --cc=agross@codeaurora.org \ --cc=alex.williamson@redhat.com \ --cc=b.reynal@virtualopensystems.com \ --cc=cov@codeaurora.org \ --cc=eric.auger@linaro.org \ --cc=jcm@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=timur@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.