* [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries
@ 2016-05-25 12:53 ` Ravikumar Kattekola
0 siblings, 0 replies; 24+ messages in thread
From: Ravikumar Kattekola @ 2016-05-25 12:53 UTC (permalink / raw)
To: paul, tony, linux, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux-omap, devicetree, linux-arm-kernel,
linux-kernel
DRA72x devices have a sixth i2c ocntroller instance.
Following patches add the required hwmod structure and
device tree nodes.
Reference doc: DRA72x TRM [ SPRUHP2Q ]
Tested on :
DRA72x Rev B EVM
Ravikumar Kattekola (2):
arm: dra7: Add hwmod entry for i2c6
dts: dra7: Add device tree node for i2c6
arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
2 files changed, 34 insertions(+)
--
2.8.2.396.g5fe494c
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries
@ 2016-05-25 12:53 ` Ravikumar Kattekola
0 siblings, 0 replies; 24+ messages in thread
From: Ravikumar Kattekola @ 2016-05-25 12:53 UTC (permalink / raw)
To: paul, tony, linux, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux-omap, devicetree, linux-arm-kernel,
linux-kernel
DRA72x devices have a sixth i2c ocntroller instance.
Following patches add the required hwmod structure and
device tree nodes.
Reference doc: DRA72x TRM [ SPRUHP2Q ]
Tested on :
DRA72x Rev B EVM
Ravikumar Kattekola (2):
arm: dra7: Add hwmod entry for i2c6
dts: dra7: Add device tree node for i2c6
arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
2 files changed, 34 insertions(+)
--
2.8.2.396.g5fe494c
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries
@ 2016-05-25 12:53 ` Ravikumar Kattekola
0 siblings, 0 replies; 24+ messages in thread
From: Ravikumar Kattekola @ 2016-05-25 12:53 UTC (permalink / raw)
To: linux-arm-kernel
DRA72x devices have a sixth i2c ocntroller instance.
Following patches add the required hwmod structure and
device tree nodes.
Reference doc: DRA72x TRM [ SPRUHP2Q ]
Tested on :
DRA72x Rev B EVM
Ravikumar Kattekola (2):
arm: dra7: Add hwmod entry for i2c6
dts: dra7: Add device tree node for i2c6
arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
2 files changed, 34 insertions(+)
--
2.8.2.396.g5fe494c
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
2016-05-25 12:53 ` Ravikumar Kattekola
(?)
@ 2016-05-25 12:53 ` Ravikumar Kattekola
-1 siblings, 0 replies; 24+ messages in thread
From: Ravikumar Kattekola @ 2016-05-25 12:53 UTC (permalink / raw)
To: paul, tony, linux, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux-omap, devicetree, linux-arm-kernel,
linux-kernel
dra72x device has i2c6 controller.
Adding hwmod definition for the same.
Reference DRA72x TRM [ SPRUHP2Q ]
Signed-off-by: Ravikumar Kattekola <rk@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index d0e7e525..b84c0f7 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
.dev_attr = &i2c_dev_attr,
};
+/* i2c6 */
+static struct omap_hwmod dra7xx_i2c6_hwmod = {
+ .name = "i2c6",
+ .class = &dra7xx_i2c_hwmod_class,
+ .clkdm_name = "l4per2_clkdm",
+ .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
+ .main_clk = "func_96m_fclk",
+ .prcm = {
+ .omap4 = {
+ },
+ },
+ .dev_attr = &i2c_dev_attr,
+};
+
/*
* 'mailbox' class
*
@@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
.user = OCP_USER_MPU | OCP_USER_SDMA,
};
+/* l4_per2 -> i2c6 */
+static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
+ .master = &dra7xx_l4_per2_hwmod,
+ .slave = &dra7xx_i2c6_hwmod,
+ .clk = "l3_iclk_div",
+ .user = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
/* l4_cfg -> mailbox1 */
static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
.master = &dra7xx_l4_cfg_hwmod,
@@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
&dra7xx_l4_per1__i2c3,
&dra7xx_l4_per1__i2c4,
&dra7xx_l4_per1__i2c5,
+ &dra7xx_l4_per2__i2c6,
&dra7xx_l4_cfg__mailbox1,
&dra7xx_l4_per3__mailbox2,
&dra7xx_l4_per3__mailbox3,
--
2.8.2.396.g5fe494c
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
@ 2016-05-25 12:53 ` Ravikumar Kattekola
0 siblings, 0 replies; 24+ messages in thread
From: Ravikumar Kattekola @ 2016-05-25 12:53 UTC (permalink / raw)
To: paul, tony, linux, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux-omap, devicetree, linux-arm-kernel,
linux-kernel
dra72x device has i2c6 controller.
Adding hwmod definition for the same.
Reference DRA72x TRM [ SPRUHP2Q ]
Signed-off-by: Ravikumar Kattekola <rk@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index d0e7e525..b84c0f7 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
.dev_attr = &i2c_dev_attr,
};
+/* i2c6 */
+static struct omap_hwmod dra7xx_i2c6_hwmod = {
+ .name = "i2c6",
+ .class = &dra7xx_i2c_hwmod_class,
+ .clkdm_name = "l4per2_clkdm",
+ .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
+ .main_clk = "func_96m_fclk",
+ .prcm = {
+ .omap4 = {
+ },
+ },
+ .dev_attr = &i2c_dev_attr,
+};
+
/*
* 'mailbox' class
*
@@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
.user = OCP_USER_MPU | OCP_USER_SDMA,
};
+/* l4_per2 -> i2c6 */
+static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
+ .master = &dra7xx_l4_per2_hwmod,
+ .slave = &dra7xx_i2c6_hwmod,
+ .clk = "l3_iclk_div",
+ .user = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
/* l4_cfg -> mailbox1 */
static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
.master = &dra7xx_l4_cfg_hwmod,
@@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
&dra7xx_l4_per1__i2c3,
&dra7xx_l4_per1__i2c4,
&dra7xx_l4_per1__i2c5,
+ &dra7xx_l4_per2__i2c6,
&dra7xx_l4_cfg__mailbox1,
&dra7xx_l4_per3__mailbox2,
&dra7xx_l4_per3__mailbox3,
--
2.8.2.396.g5fe494c
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
@ 2016-05-25 12:53 ` Ravikumar Kattekola
0 siblings, 0 replies; 24+ messages in thread
From: Ravikumar Kattekola @ 2016-05-25 12:53 UTC (permalink / raw)
To: linux-arm-kernel
dra72x device has i2c6 controller.
Adding hwmod definition for the same.
Reference DRA72x TRM [ SPRUHP2Q ]
Signed-off-by: Ravikumar Kattekola <rk@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index d0e7e525..b84c0f7 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
.dev_attr = &i2c_dev_attr,
};
+/* i2c6 */
+static struct omap_hwmod dra7xx_i2c6_hwmod = {
+ .name = "i2c6",
+ .class = &dra7xx_i2c_hwmod_class,
+ .clkdm_name = "l4per2_clkdm",
+ .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
+ .main_clk = "func_96m_fclk",
+ .prcm = {
+ .omap4 = {
+ },
+ },
+ .dev_attr = &i2c_dev_attr,
+};
+
/*
* 'mailbox' class
*
@@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
.user = OCP_USER_MPU | OCP_USER_SDMA,
};
+/* l4_per2 -> i2c6 */
+static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
+ .master = &dra7xx_l4_per2_hwmod,
+ .slave = &dra7xx_i2c6_hwmod,
+ .clk = "l3_iclk_div",
+ .user = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
/* l4_cfg -> mailbox1 */
static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
.master = &dra7xx_l4_cfg_hwmod,
@@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
&dra7xx_l4_per1__i2c3,
&dra7xx_l4_per1__i2c4,
&dra7xx_l4_per1__i2c5,
+ &dra7xx_l4_per2__i2c6,
&dra7xx_l4_cfg__mailbox1,
&dra7xx_l4_per3__mailbox2,
&dra7xx_l4_per3__mailbox3,
--
2.8.2.396.g5fe494c
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/2] dts: dra7: Add device tree node for i2c6
2016-05-25 12:53 ` Ravikumar Kattekola
(?)
@ 2016-05-25 12:53 ` Ravikumar Kattekola
-1 siblings, 0 replies; 24+ messages in thread
From: Ravikumar Kattekola @ 2016-05-25 12:53 UTC (permalink / raw)
To: paul, tony, linux, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux-omap, devicetree, linux-arm-kernel,
linux-kernel
DRA72x devices have an extra i2c controller instance - i2c6
Adding device description for the same.
Reference : DRA72x_SR1.0 TRM [ SPRUHP2Q ]
Signed-off-by: Ravikumar Kattekola <rk@ti.com>
---
arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 3a8f397..84729a1 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -27,6 +27,7 @@
i2c2 = &i2c3;
i2c3 = &i2c4;
i2c4 = &i2c5;
+ i2c5 = &i2c6;
serial0 = &uart1;
serial1 = &uart2;
serial2 = &uart3;
@@ -929,6 +930,16 @@
status = "disabled";
};
+ i2c6: i2c@48458000 {
+ compatible = "ti,omap4-i2c";
+ reg = <0x48458000 0x100>;
+ interrupts = <GIC_SPI 402 IRQ_TYPE_LEVEL_HIGH>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ ti,hwmods = "i2c6";
+ status = "disabled";
+ };
+
mmc1: mmc@4809c000 {
compatible = "ti,omap4-hsmmc";
reg = <0x4809c000 0x400>;
--
2.8.2.396.g5fe494c
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/2] dts: dra7: Add device tree node for i2c6
@ 2016-05-25 12:53 ` Ravikumar Kattekola
0 siblings, 0 replies; 24+ messages in thread
From: Ravikumar Kattekola @ 2016-05-25 12:53 UTC (permalink / raw)
To: paul, tony, linux, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux-omap, devicetree, linux-arm-kernel,
linux-kernel
DRA72x devices have an extra i2c controller instance - i2c6
Adding device description for the same.
Reference : DRA72x_SR1.0 TRM [ SPRUHP2Q ]
Signed-off-by: Ravikumar Kattekola <rk@ti.com>
---
arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 3a8f397..84729a1 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -27,6 +27,7 @@
i2c2 = &i2c3;
i2c3 = &i2c4;
i2c4 = &i2c5;
+ i2c5 = &i2c6;
serial0 = &uart1;
serial1 = &uart2;
serial2 = &uart3;
@@ -929,6 +930,16 @@
status = "disabled";
};
+ i2c6: i2c@48458000 {
+ compatible = "ti,omap4-i2c";
+ reg = <0x48458000 0x100>;
+ interrupts = <GIC_SPI 402 IRQ_TYPE_LEVEL_HIGH>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ ti,hwmods = "i2c6";
+ status = "disabled";
+ };
+
mmc1: mmc@4809c000 {
compatible = "ti,omap4-hsmmc";
reg = <0x4809c000 0x400>;
--
2.8.2.396.g5fe494c
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/2] dts: dra7: Add device tree node for i2c6
@ 2016-05-25 12:53 ` Ravikumar Kattekola
0 siblings, 0 replies; 24+ messages in thread
From: Ravikumar Kattekola @ 2016-05-25 12:53 UTC (permalink / raw)
To: linux-arm-kernel
DRA72x devices have an extra i2c controller instance - i2c6
Adding device description for the same.
Reference : DRA72x_SR1.0 TRM [ SPRUHP2Q ]
Signed-off-by: Ravikumar Kattekola <rk@ti.com>
---
arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 3a8f397..84729a1 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -27,6 +27,7 @@
i2c2 = &i2c3;
i2c3 = &i2c4;
i2c4 = &i2c5;
+ i2c5 = &i2c6;
serial0 = &uart1;
serial1 = &uart2;
serial2 = &uart3;
@@ -929,6 +930,16 @@
status = "disabled";
};
+ i2c6: i2c at 48458000 {
+ compatible = "ti,omap4-i2c";
+ reg = <0x48458000 0x100>;
+ interrupts = <GIC_SPI 402 IRQ_TYPE_LEVEL_HIGH>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ ti,hwmods = "i2c6";
+ status = "disabled";
+ };
+
mmc1: mmc at 4809c000 {
compatible = "ti,omap4-hsmmc";
reg = <0x4809c000 0x400>;
--
2.8.2.396.g5fe494c
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries
2016-05-25 12:53 ` Ravikumar Kattekola
(?)
@ 2016-05-25 16:09 ` Nishanth Menon
-1 siblings, 0 replies; 24+ messages in thread
From: Nishanth Menon @ 2016-05-25 16:09 UTC (permalink / raw)
To: Ravikumar Kattekola, paul, tony, linux, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
Cc: Felipe Balbi
On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
> DRA72x devices have a sixth i2c ocntroller instance.
> Following patches add the required hwmod structure and
> device tree nodes.
>
> Reference doc: DRA72x TRM [ SPRUHP2Q ]
>
> Tested on :
> DRA72x Rev B EVM
>
> Ravikumar Kattekola (2):
> arm: dra7: Add hwmod entry for i2c6
> dts: dra7: Add device tree node for i2c6
>
> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 2 files changed, 34 insertions(+)
>
NAK. reasoning:
a) i2c6 is a custom IP integration with completely non-standard
dependencies with cross device dependencies for pretty much a specific
usecase -> usage is pretty much limited for generic support - the
decision is NOT to support this instance in Linux kernel - internal
discussion forwarded to developer.
b) the patches themselves are wrong -> it applies to DRA72x not
generic DRA7x platform
c) patches themselves are in the wrong format (wrong subject line etc).
d) patches don't handle the SoC internal device dependencies either ->
in short will not function in a generic solution for all variations of
platforms.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries
@ 2016-05-25 16:09 ` Nishanth Menon
0 siblings, 0 replies; 24+ messages in thread
From: Nishanth Menon @ 2016-05-25 16:09 UTC (permalink / raw)
To: Ravikumar Kattekola, paul, tony, linux, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
Cc: Felipe Balbi
On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
> DRA72x devices have a sixth i2c ocntroller instance.
> Following patches add the required hwmod structure and
> device tree nodes.
>
> Reference doc: DRA72x TRM [ SPRUHP2Q ]
>
> Tested on :
> DRA72x Rev B EVM
>
> Ravikumar Kattekola (2):
> arm: dra7: Add hwmod entry for i2c6
> dts: dra7: Add device tree node for i2c6
>
> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 2 files changed, 34 insertions(+)
>
NAK. reasoning:
a) i2c6 is a custom IP integration with completely non-standard
dependencies with cross device dependencies for pretty much a specific
usecase -> usage is pretty much limited for generic support - the
decision is NOT to support this instance in Linux kernel - internal
discussion forwarded to developer.
b) the patches themselves are wrong -> it applies to DRA72x not
generic DRA7x platform
c) patches themselves are in the wrong format (wrong subject line etc).
d) patches don't handle the SoC internal device dependencies either ->
in short will not function in a generic solution for all variations of
platforms.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries
@ 2016-05-25 16:09 ` Nishanth Menon
0 siblings, 0 replies; 24+ messages in thread
From: Nishanth Menon @ 2016-05-25 16:09 UTC (permalink / raw)
To: linux-arm-kernel
On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
> DRA72x devices have a sixth i2c ocntroller instance.
> Following patches add the required hwmod structure and
> device tree nodes.
>
> Reference doc: DRA72x TRM [ SPRUHP2Q ]
>
> Tested on :
> DRA72x Rev B EVM
>
> Ravikumar Kattekola (2):
> arm: dra7: Add hwmod entry for i2c6
> dts: dra7: Add device tree node for i2c6
>
> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 2 files changed, 34 insertions(+)
>
NAK. reasoning:
a) i2c6 is a custom IP integration with completely non-standard
dependencies with cross device dependencies for pretty much a specific
usecase -> usage is pretty much limited for generic support - the
decision is NOT to support this instance in Linux kernel - internal
discussion forwarded to developer.
b) the patches themselves are wrong -> it applies to DRA72x not
generic DRA7x platform
c) patches themselves are in the wrong format (wrong subject line etc).
d) patches don't handle the SoC internal device dependencies either ->
in short will not function in a generic solution for all variations of
platforms.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
2016-05-25 12:53 ` Ravikumar Kattekola
(?)
@ 2016-05-25 16:10 ` Nishanth Menon
-1 siblings, 0 replies; 24+ messages in thread
From: Nishanth Menon @ 2016-05-25 16:10 UTC (permalink / raw)
To: Ravikumar Kattekola, paul, tony, linux, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
> dra72x device has i2c6 controller.
> Adding hwmod definition for the same.
>
> Reference DRA72x TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index d0e7e525..b84c0f7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
> .dev_attr = &i2c_dev_attr,
> };
>
> +/* i2c6 */
> +static struct omap_hwmod dra7xx_i2c6_hwmod = {
> + .name = "i2c6",
> + .class = &dra7xx_i2c_hwmod_class,
> + .clkdm_name = "l4per2_clkdm",
> + .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
> + .main_clk = "func_96m_fclk",
> + .prcm = {
> + .omap4 = {
> + },
> + },
> + .dev_attr = &i2c_dev_attr,
> +};
> +
> /*
> * 'mailbox' class
> *
> @@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +/* l4_per2 -> i2c6 */
> +static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
> + .master = &dra7xx_l4_per2_hwmod,
> + .slave = &dra7xx_i2c6_hwmod,
> + .clk = "l3_iclk_div",
> + .user = OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> /* l4_cfg -> mailbox1 */
> static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
> .master = &dra7xx_l4_cfg_hwmod,
> @@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
> &dra7xx_l4_per1__i2c3,
> &dra7xx_l4_per1__i2c4,
> &dra7xx_l4_per1__i2c5,
> + &dra7xx_l4_per2__i2c6,
> &dra7xx_l4_cfg__mailbox1,
> &dra7xx_l4_per3__mailbox2,
> &dra7xx_l4_per3__mailbox3,
>
responding to the specific patches themselves:
NAK. reasoning:
a) i2c6 is a custom IP integration with completely non-standard
dependencies with cross device dependencies for pretty much a specific
usecase -> usage is pretty much limited for generic support - the
decision is NOT to support this instance in Linux kernel - internal
discussion forwarded to developer.
b) the patches themselves are wrong -> it applies to DRA72x not
generic DRA7x platform
c) patches themselves are in the wrong format (wrong subject line etc).
d) patches don't handle the SoC internal device dependencies either ->
in short will not function in a generic solution for all variations of
platforms.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
@ 2016-05-25 16:10 ` Nishanth Menon
0 siblings, 0 replies; 24+ messages in thread
From: Nishanth Menon @ 2016-05-25 16:10 UTC (permalink / raw)
To: Ravikumar Kattekola, paul, tony, linux, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
> dra72x device has i2c6 controller.
> Adding hwmod definition for the same.
>
> Reference DRA72x TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index d0e7e525..b84c0f7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
> .dev_attr = &i2c_dev_attr,
> };
>
> +/* i2c6 */
> +static struct omap_hwmod dra7xx_i2c6_hwmod = {
> + .name = "i2c6",
> + .class = &dra7xx_i2c_hwmod_class,
> + .clkdm_name = "l4per2_clkdm",
> + .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
> + .main_clk = "func_96m_fclk",
> + .prcm = {
> + .omap4 = {
> + },
> + },
> + .dev_attr = &i2c_dev_attr,
> +};
> +
> /*
> * 'mailbox' class
> *
> @@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +/* l4_per2 -> i2c6 */
> +static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
> + .master = &dra7xx_l4_per2_hwmod,
> + .slave = &dra7xx_i2c6_hwmod,
> + .clk = "l3_iclk_div",
> + .user = OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> /* l4_cfg -> mailbox1 */
> static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
> .master = &dra7xx_l4_cfg_hwmod,
> @@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
> &dra7xx_l4_per1__i2c3,
> &dra7xx_l4_per1__i2c4,
> &dra7xx_l4_per1__i2c5,
> + &dra7xx_l4_per2__i2c6,
> &dra7xx_l4_cfg__mailbox1,
> &dra7xx_l4_per3__mailbox2,
> &dra7xx_l4_per3__mailbox3,
>
responding to the specific patches themselves:
NAK. reasoning:
a) i2c6 is a custom IP integration with completely non-standard
dependencies with cross device dependencies for pretty much a specific
usecase -> usage is pretty much limited for generic support - the
decision is NOT to support this instance in Linux kernel - internal
discussion forwarded to developer.
b) the patches themselves are wrong -> it applies to DRA72x not
generic DRA7x platform
c) patches themselves are in the wrong format (wrong subject line etc).
d) patches don't handle the SoC internal device dependencies either ->
in short will not function in a generic solution for all variations of
platforms.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
@ 2016-05-25 16:10 ` Nishanth Menon
0 siblings, 0 replies; 24+ messages in thread
From: Nishanth Menon @ 2016-05-25 16:10 UTC (permalink / raw)
To: linux-arm-kernel
On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
> dra72x device has i2c6 controller.
> Adding hwmod definition for the same.
>
> Reference DRA72x TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index d0e7e525..b84c0f7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
> .dev_attr = &i2c_dev_attr,
> };
>
> +/* i2c6 */
> +static struct omap_hwmod dra7xx_i2c6_hwmod = {
> + .name = "i2c6",
> + .class = &dra7xx_i2c_hwmod_class,
> + .clkdm_name = "l4per2_clkdm",
> + .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
> + .main_clk = "func_96m_fclk",
> + .prcm = {
> + .omap4 = {
> + },
> + },
> + .dev_attr = &i2c_dev_attr,
> +};
> +
> /*
> * 'mailbox' class
> *
> @@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +/* l4_per2 -> i2c6 */
> +static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
> + .master = &dra7xx_l4_per2_hwmod,
> + .slave = &dra7xx_i2c6_hwmod,
> + .clk = "l3_iclk_div",
> + .user = OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> /* l4_cfg -> mailbox1 */
> static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
> .master = &dra7xx_l4_cfg_hwmod,
> @@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
> &dra7xx_l4_per1__i2c3,
> &dra7xx_l4_per1__i2c4,
> &dra7xx_l4_per1__i2c5,
> + &dra7xx_l4_per2__i2c6,
> &dra7xx_l4_cfg__mailbox1,
> &dra7xx_l4_per3__mailbox2,
> &dra7xx_l4_per3__mailbox3,
>
responding to the specific patches themselves:
NAK. reasoning:
a) i2c6 is a custom IP integration with completely non-standard
dependencies with cross device dependencies for pretty much a specific
usecase -> usage is pretty much limited for generic support - the
decision is NOT to support this instance in Linux kernel - internal
discussion forwarded to developer.
b) the patches themselves are wrong -> it applies to DRA72x not
generic DRA7x platform
c) patches themselves are in the wrong format (wrong subject line etc).
d) patches don't handle the SoC internal device dependencies either ->
in short will not function in a generic solution for all variations of
platforms.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dts: dra7: Add device tree node for i2c6
2016-05-25 12:53 ` Ravikumar Kattekola
(?)
@ 2016-05-25 16:11 ` Nishanth Menon
-1 siblings, 0 replies; 24+ messages in thread
From: Nishanth Menon @ 2016-05-25 16:11 UTC (permalink / raw)
To: Ravikumar Kattekola, paul, tony, linux, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
> DRA72x devices have an extra i2c controller instance - i2c6
> Adding device description for the same.
>
> Reference : DRA72x_SR1.0 TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk@ti.com>
> ---
> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 3a8f397..84729a1 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -27,6 +27,7 @@
> i2c2 = &i2c3;
> i2c3 = &i2c4;
> i2c4 = &i2c5;
> + i2c5 = &i2c6;
> serial0 = &uart1;
> serial1 = &uart2;
> serial2 = &uart3;
> @@ -929,6 +930,16 @@
> status = "disabled";
> };
>
> + i2c6: i2c@48458000 {
> + compatible = "ti,omap4-i2c";
> + reg = <0x48458000 0x100>;
> + interrupts = <GIC_SPI 402 IRQ_TYPE_LEVEL_HIGH>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + ti,hwmods = "i2c6";
> + status = "disabled";
> + };
> +
> mmc1: mmc@4809c000 {
> compatible = "ti,omap4-hsmmc";
> reg = <0x4809c000 0x400>;
>
NAK again for the same reasoning.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] dts: dra7: Add device tree node for i2c6
@ 2016-05-25 16:11 ` Nishanth Menon
0 siblings, 0 replies; 24+ messages in thread
From: Nishanth Menon @ 2016-05-25 16:11 UTC (permalink / raw)
To: Ravikumar Kattekola, paul, tony, linux, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
> DRA72x devices have an extra i2c controller instance - i2c6
> Adding device description for the same.
>
> Reference : DRA72x_SR1.0 TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk@ti.com>
> ---
> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 3a8f397..84729a1 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -27,6 +27,7 @@
> i2c2 = &i2c3;
> i2c3 = &i2c4;
> i2c4 = &i2c5;
> + i2c5 = &i2c6;
> serial0 = &uart1;
> serial1 = &uart2;
> serial2 = &uart3;
> @@ -929,6 +930,16 @@
> status = "disabled";
> };
>
> + i2c6: i2c@48458000 {
> + compatible = "ti,omap4-i2c";
> + reg = <0x48458000 0x100>;
> + interrupts = <GIC_SPI 402 IRQ_TYPE_LEVEL_HIGH>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + ti,hwmods = "i2c6";
> + status = "disabled";
> + };
> +
> mmc1: mmc@4809c000 {
> compatible = "ti,omap4-hsmmc";
> reg = <0x4809c000 0x400>;
>
NAK again for the same reasoning.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 2/2] dts: dra7: Add device tree node for i2c6
@ 2016-05-25 16:11 ` Nishanth Menon
0 siblings, 0 replies; 24+ messages in thread
From: Nishanth Menon @ 2016-05-25 16:11 UTC (permalink / raw)
To: linux-arm-kernel
On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
> DRA72x devices have an extra i2c controller instance - i2c6
> Adding device description for the same.
>
> Reference : DRA72x_SR1.0 TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk@ti.com>
> ---
> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 3a8f397..84729a1 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -27,6 +27,7 @@
> i2c2 = &i2c3;
> i2c3 = &i2c4;
> i2c4 = &i2c5;
> + i2c5 = &i2c6;
> serial0 = &uart1;
> serial1 = &uart2;
> serial2 = &uart3;
> @@ -929,6 +930,16 @@
> status = "disabled";
> };
>
> + i2c6: i2c at 48458000 {
> + compatible = "ti,omap4-i2c";
> + reg = <0x48458000 0x100>;
> + interrupts = <GIC_SPI 402 IRQ_TYPE_LEVEL_HIGH>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + ti,hwmods = "i2c6";
> + status = "disabled";
> + };
> +
> mmc1: mmc at 4809c000 {
> compatible = "ti,omap4-hsmmc";
> reg = <0x4809c000 0x400>;
>
NAK again for the same reasoning.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
@ 2016-05-26 3:55 ` Lokesh Vutla
0 siblings, 0 replies; 24+ messages in thread
From: Lokesh Vutla @ 2016-05-26 3:55 UTC (permalink / raw)
To: Ravikumar Kattekola, paul, tony, linux, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
On Wednesday 25 May 2016 06:23 PM, Ravikumar Kattekola wrote:
> dra72x device has i2c6 controller.
> Adding hwmod definition for the same.
>
> Reference DRA72x TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index d0e7e525..b84c0f7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
> .dev_attr = &i2c_dev_attr,
> };
>
> +/* i2c6 */
> +static struct omap_hwmod dra7xx_i2c6_hwmod = {
> + .name = "i2c6",
> + .class = &dra7xx_i2c_hwmod_class,
> + .clkdm_name = "l4per2_clkdm",
> + .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
> + .main_clk = "func_96m_fclk",
> + .prcm = {
> + .omap4 = {
> + },
> + },
> + .dev_attr = &i2c_dev_attr,
> +};
> +
> /*
> * 'mailbox' class
> *
> @@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +/* l4_per2 -> i2c6 */
> +static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
> + .master = &dra7xx_l4_per2_hwmod,
> + .slave = &dra7xx_i2c6_hwmod,
> + .clk = "l3_iclk_div",
> + .user = OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> /* l4_cfg -> mailbox1 */
> static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
> .master = &dra7xx_l4_cfg_hwmod,
> @@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
> &dra7xx_l4_per1__i2c3,
> &dra7xx_l4_per1__i2c4,
> &dra7xx_l4_per1__i2c5,
> + &dra7xx_l4_per2__i2c6,
If it is available only on dra72x, register the hwmod under
dra72x_hwmod_ocp_ifs. Also in $subject use dra72x to make things clear.
Thanks and regards,
Lokesh
> &dra7xx_l4_cfg__mailbox1,
> &dra7xx_l4_per3__mailbox2,
> &dra7xx_l4_per3__mailbox3,
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
@ 2016-05-26 3:55 ` Lokesh Vutla
0 siblings, 0 replies; 24+ messages in thread
From: Lokesh Vutla @ 2016-05-26 3:55 UTC (permalink / raw)
To: Ravikumar Kattekola, paul-DWxLp4Yu+b8AvxtiuMwx3w,
tony-4v6yS6AI5VpBDgjK7y7TUQ, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Wednesday 25 May 2016 06:23 PM, Ravikumar Kattekola wrote:
> dra72x device has i2c6 controller.
> Adding hwmod definition for the same.
>
> Reference DRA72x TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk-l0cyMroinI0@public.gmane.org>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index d0e7e525..b84c0f7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
> .dev_attr = &i2c_dev_attr,
> };
>
> +/* i2c6 */
> +static struct omap_hwmod dra7xx_i2c6_hwmod = {
> + .name = "i2c6",
> + .class = &dra7xx_i2c_hwmod_class,
> + .clkdm_name = "l4per2_clkdm",
> + .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
> + .main_clk = "func_96m_fclk",
> + .prcm = {
> + .omap4 = {
> + },
> + },
> + .dev_attr = &i2c_dev_attr,
> +};
> +
> /*
> * 'mailbox' class
> *
> @@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +/* l4_per2 -> i2c6 */
> +static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
> + .master = &dra7xx_l4_per2_hwmod,
> + .slave = &dra7xx_i2c6_hwmod,
> + .clk = "l3_iclk_div",
> + .user = OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> /* l4_cfg -> mailbox1 */
> static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
> .master = &dra7xx_l4_cfg_hwmod,
> @@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
> &dra7xx_l4_per1__i2c3,
> &dra7xx_l4_per1__i2c4,
> &dra7xx_l4_per1__i2c5,
> + &dra7xx_l4_per2__i2c6,
If it is available only on dra72x, register the hwmod under
dra72x_hwmod_ocp_ifs. Also in $subject use dra72x to make things clear.
Thanks and regards,
Lokesh
> &dra7xx_l4_cfg__mailbox1,
> &dra7xx_l4_per3__mailbox2,
> &dra7xx_l4_per3__mailbox3,
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
@ 2016-05-26 3:55 ` Lokesh Vutla
0 siblings, 0 replies; 24+ messages in thread
From: Lokesh Vutla @ 2016-05-26 3:55 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 25 May 2016 06:23 PM, Ravikumar Kattekola wrote:
> dra72x device has i2c6 controller.
> Adding hwmod definition for the same.
>
> Reference DRA72x TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index d0e7e525..b84c0f7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
> .dev_attr = &i2c_dev_attr,
> };
>
> +/* i2c6 */
> +static struct omap_hwmod dra7xx_i2c6_hwmod = {
> + .name = "i2c6",
> + .class = &dra7xx_i2c_hwmod_class,
> + .clkdm_name = "l4per2_clkdm",
> + .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
> + .main_clk = "func_96m_fclk",
> + .prcm = {
> + .omap4 = {
> + },
> + },
> + .dev_attr = &i2c_dev_attr,
> +};
> +
> /*
> * 'mailbox' class
> *
> @@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +/* l4_per2 -> i2c6 */
> +static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
> + .master = &dra7xx_l4_per2_hwmod,
> + .slave = &dra7xx_i2c6_hwmod,
> + .clk = "l3_iclk_div",
> + .user = OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> /* l4_cfg -> mailbox1 */
> static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
> .master = &dra7xx_l4_cfg_hwmod,
> @@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
> &dra7xx_l4_per1__i2c3,
> &dra7xx_l4_per1__i2c4,
> &dra7xx_l4_per1__i2c5,
> + &dra7xx_l4_per2__i2c6,
If it is available only on dra72x, register the hwmod under
dra72x_hwmod_ocp_ifs. Also in $subject use dra72x to make things clear.
Thanks and regards,
Lokesh
> &dra7xx_l4_cfg__mailbox1,
> &dra7xx_l4_per3__mailbox2,
> &dra7xx_l4_per3__mailbox3,
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries
2016-05-25 16:09 ` Nishanth Menon
(?)
@ 2016-05-26 5:47 ` Tero Kristo
-1 siblings, 0 replies; 24+ messages in thread
From: Tero Kristo @ 2016-05-26 5:47 UTC (permalink / raw)
To: Nishanth Menon, Ravikumar Kattekola, paul, tony, linux, robh+dt,
pawel.moll, mark.rutland, ijc+devicetree, galak, linux-omap,
devicetree, linux-arm-kernel, linux-kernel
Cc: Felipe Balbi
On 25/05/16 19:09, Nishanth Menon wrote:
> On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
>> DRA72x devices have a sixth i2c ocntroller instance.
>> Following patches add the required hwmod structure and
>> device tree nodes.
>>
>> Reference doc: DRA72x TRM [ SPRUHP2Q ]
>>
>> Tested on :
>> DRA72x Rev B EVM
>>
>> Ravikumar Kattekola (2):
>> arm: dra7: Add hwmod entry for i2c6
>> dts: dra7: Add device tree node for i2c6
>>
>> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
>> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
>> 2 files changed, 34 insertions(+)
>>
> NAK. reasoning:
> a) i2c6 is a custom IP integration with completely non-standard
> dependencies with cross device dependencies for pretty much a specific
> usecase -> usage is pretty much limited for generic support - the
> decision is NOT to support this instance in Linux kernel - internal
> discussion forwarded to developer.
> b) the patches themselves are wrong -> it applies to DRA72x not
> generic DRA7x platform
> c) patches themselves are in the wrong format (wrong subject line etc).
> d) patches don't handle the SoC internal device dependencies either ->
> in short will not function in a generic solution for all variations of
> platforms.
>
Yes please drop this, attempting to support it in upstream is just going
to cause unnecessary pain.
-Tero
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries
@ 2016-05-26 5:47 ` Tero Kristo
0 siblings, 0 replies; 24+ messages in thread
From: Tero Kristo @ 2016-05-26 5:47 UTC (permalink / raw)
To: Nishanth Menon, Ravikumar Kattekola, paul, tony, linux, robh+dt,
pawel.moll, mark.rutland, ijc+devicetree, galak, linux-omap,
devicetree, linux-arm-kernel, linux-kernel
Cc: Felipe Balbi
On 25/05/16 19:09, Nishanth Menon wrote:
> On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
>> DRA72x devices have a sixth i2c ocntroller instance.
>> Following patches add the required hwmod structure and
>> device tree nodes.
>>
>> Reference doc: DRA72x TRM [ SPRUHP2Q ]
>>
>> Tested on :
>> DRA72x Rev B EVM
>>
>> Ravikumar Kattekola (2):
>> arm: dra7: Add hwmod entry for i2c6
>> dts: dra7: Add device tree node for i2c6
>>
>> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
>> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
>> 2 files changed, 34 insertions(+)
>>
> NAK. reasoning:
> a) i2c6 is a custom IP integration with completely non-standard
> dependencies with cross device dependencies for pretty much a specific
> usecase -> usage is pretty much limited for generic support - the
> decision is NOT to support this instance in Linux kernel - internal
> discussion forwarded to developer.
> b) the patches themselves are wrong -> it applies to DRA72x not
> generic DRA7x platform
> c) patches themselves are in the wrong format (wrong subject line etc).
> d) patches don't handle the SoC internal device dependencies either ->
> in short will not function in a generic solution for all variations of
> platforms.
>
Yes please drop this, attempting to support it in upstream is just going
to cause unnecessary pain.
-Tero
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries
@ 2016-05-26 5:47 ` Tero Kristo
0 siblings, 0 replies; 24+ messages in thread
From: Tero Kristo @ 2016-05-26 5:47 UTC (permalink / raw)
To: linux-arm-kernel
On 25/05/16 19:09, Nishanth Menon wrote:
> On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
>> DRA72x devices have a sixth i2c ocntroller instance.
>> Following patches add the required hwmod structure and
>> device tree nodes.
>>
>> Reference doc: DRA72x TRM [ SPRUHP2Q ]
>>
>> Tested on :
>> DRA72x Rev B EVM
>>
>> Ravikumar Kattekola (2):
>> arm: dra7: Add hwmod entry for i2c6
>> dts: dra7: Add device tree node for i2c6
>>
>> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++
>> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
>> 2 files changed, 34 insertions(+)
>>
> NAK. reasoning:
> a) i2c6 is a custom IP integration with completely non-standard
> dependencies with cross device dependencies for pretty much a specific
> usecase -> usage is pretty much limited for generic support - the
> decision is NOT to support this instance in Linux kernel - internal
> discussion forwarded to developer.
> b) the patches themselves are wrong -> it applies to DRA72x not
> generic DRA7x platform
> c) patches themselves are in the wrong format (wrong subject line etc).
> d) patches don't handle the SoC internal device dependencies either ->
> in short will not function in a generic solution for all variations of
> platforms.
>
Yes please drop this, attempting to support it in upstream is just going
to cause unnecessary pain.
-Tero
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2016-05-26 5:48 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-25 12:53 [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 12:53 ` [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6 Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 16:10 ` Nishanth Menon
2016-05-25 16:10 ` Nishanth Menon
2016-05-25 16:10 ` Nishanth Menon
2016-05-26 3:55 ` Lokesh Vutla
2016-05-26 3:55 ` Lokesh Vutla
2016-05-26 3:55 ` Lokesh Vutla
2016-05-25 12:53 ` [PATCH 2/2] dts: dra7: Add device tree node " Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 16:11 ` Nishanth Menon
2016-05-25 16:11 ` Nishanth Menon
2016-05-25 16:11 ` Nishanth Menon
2016-05-25 16:09 ` [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries Nishanth Menon
2016-05-25 16:09 ` Nishanth Menon
2016-05-25 16:09 ` Nishanth Menon
2016-05-26 5:47 ` Tero Kristo
2016-05-26 5:47 ` Tero Kristo
2016-05-26 5:47 ` Tero Kristo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.