Fwd: Re: [RFC i-g-t 5/7] tools/Makefile: Format whitespace.

Fwd: Re: [RFC i-g-t 5/7] tools/Makefile: Format whitespace.

[Robert Foss]

On Wednesday, May 25, 2016 19:18 BST, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
>
> Harmonize tabs/spaces etc.
>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> ---
>  tools/Makefile.sources | 57 +++++++++++++++++++++++++-------------------------
>  1 file changed, 29 insertions(+), 28 deletions(-)
>
> diff --git a/tools/Makefile.sources b/tools/Makefile.sources
> index 07d8d9b..7ed5fe5 100644
> --- a/tools/Makefile.sources
> +++ b/tools/Makefile.sources
> @@ -1,33 +1,34 @@
> -noinst_PROGRAMS = \
> -	hsw_compute_wrpll \
> -	skl_compute_wrpll \
> -	skl_ddb_allocation \
> +noinst_PROGRAMS =		\
> +	hsw_compute_wrpll	\
> +	skl_compute_wrpll	\
> +	skl_ddb_allocation	\
>  	$(NULL)
>
And this is why ladies and gentlemen you don't align on the \ character. 
As one adds a test/file with long name, you'll need to re-indent the 
whole lot. Then again... people like these, for whatever reason :-(

-Emil






_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Fwd: Re: [RFC i-g-t 5/7] tools/Makefile: Format whitespace.

[Robert Foss]

Forward to ML.

On Wednesday, May 25, 2016 21:04 BST, Robert Foss 
<robert.foss@collabora.com> wrote:

> > And this is why ladies and gentlemen you don't align on the \ character. As one adds a test/file with long name, you'll need to re-indent the whole lot. Then again... people like these, for whatever reason :-(
> >
> > -Emil
>
> I don't have particularly strong feelings about the patch, but it does
> harmonize the formatting.
>
> I'll happily drop if if anyone feels I should.
>
I think they'll like/keep it. Despite that I (sometimes) think that that 
the patch makes things looks prettier, I'd rather devote resources into 
something that's of more value ;-) And adding/removing whitespace isn't 
the one.

-Emil





_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx