* [PATCH] clone: don't use an integer as a NULL pointer
@ 2016-05-25 23:12 Ramsay Jones
2016-05-25 23:30 ` Stefan Beller
0 siblings, 1 reply; 3+ messages in thread
From: Ramsay Jones @ 2016-05-25 23:12 UTC (permalink / raw)
To: Stefan Beller; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Stefan,
If you need to re-roll your 'sb/submodule-default-paths' branch, could
you please squash this into the relevant patch. (commit 8efbe28b,
"clone: add --init-submodule=<pathspec> switch", 23-05-2016).
Thanks!
ATB,
Ramsay Jones
builtin/clone.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index 22b6eac..a056f72 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -925,7 +925,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
struct strbuf sb = STRBUF_INIT;
for_each_string_list_item(item, &init_submodules) {
strbuf_addf(&sb, "submodule.defaultUpdatePath=%s", item->string);
- string_list_append(&option_config, strbuf_detach(&sb, 0));
+ string_list_append(&option_config, strbuf_detach(&sb, NULL));
}
}
--
2.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clone: don't use an integer as a NULL pointer
2016-05-25 23:12 [PATCH] clone: don't use an integer as a NULL pointer Ramsay Jones
@ 2016-05-25 23:30 ` Stefan Beller
2016-05-26 0:32 ` Ramsay Jones
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Beller @ 2016-05-25 23:30 UTC (permalink / raw)
To: Ramsay Jones, git
On Wed, May 25, 2016 at 4:12 PM, Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Stefan,
>
> If you need to re-roll your 'sb/submodule-default-paths' branch, could
> you please squash this into the relevant patch. (commit 8efbe28b,
> "clone: add --init-submodule=<pathspec> switch", 23-05-2016).
>
> Thanks!
>
> ATB,
> Ramsay Jones
Thanks for pointing out!
I am sorry for having you write me these emails;
Out of curiosity, how much of this is manual work and how
much did you automate of this?
>
> builtin/clone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/clone.c b/builtin/clone.c
> index 22b6eac..a056f72 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -925,7 +925,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
> struct strbuf sb = STRBUF_INIT;
> for_each_string_list_item(item, &init_submodules) {
> strbuf_addf(&sb, "submodule.defaultUpdatePath=%s", item->string);
> - string_list_append(&option_config, strbuf_detach(&sb, 0));
> + string_list_append(&option_config, strbuf_detach(&sb, NULL));
> }
> }
>
> --
> 2.8.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clone: don't use an integer as a NULL pointer
2016-05-25 23:30 ` Stefan Beller
@ 2016-05-26 0:32 ` Ramsay Jones
0 siblings, 0 replies; 3+ messages in thread
From: Ramsay Jones @ 2016-05-26 0:32 UTC (permalink / raw)
To: Stefan Beller, git
On 26/05/16 00:30, Stefan Beller wrote:
> On Wed, May 25, 2016 at 4:12 PM, Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Stefan,
>>
>> If you need to re-roll your 'sb/submodule-default-paths' branch, could
>> you please squash this into the relevant patch. (commit 8efbe28b,
>> "clone: add --init-submodule=<pathspec> switch", 23-05-2016).
>>
>> Thanks!
>>
>> ATB,
>> Ramsay Jones
>
> Thanks for pointing out!
>
> I am sorry for having you write me these emails;
It's no problem ...
> Out of curiosity, how much of this is manual work and how
> much did you automate of this?
... because this particular problem is caught by 'make sparse'.
[OK, I have to write the patch, test, etc. manually, but that's
not a great burden.]
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-26 0:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-25 23:12 [PATCH] clone: don't use an integer as a NULL pointer Ramsay Jones
2016-05-25 23:30 ` Stefan Beller
2016-05-26 0:32 ` Ramsay Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.