From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Caesar Wang <wxt@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>
Cc: dianders@chromium.org, briannorris@google.com,
smbarber@google.com, linux-rockchip@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
cf@rock-chips.com, huangtao@rock-chips.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] clocksource: rockchip: remove unnecessary clear irq before request_irq
Date: Tue, 31 May 2016 01:09:45 +0200 [thread overview]
Message-ID: <574CC839.60608@linaro.org> (raw)
In-Reply-To: <1464169802-6033-3-git-send-email-wxt@rock-chips.com>
On 05/25/2016 11:49 AM, Caesar Wang wrote:
> From: Huang Tao <huangtao@rock-chips.com>
>
> rk_timer_interrupt_clear and rk_timer_disable is unnecessary before
> request_irq. Timer should keep disabled before booting Linux.
That's true in the perfect world :/ Some version has u-boot letting the
timer with irq enabled, therefore as soon as request_irq is done, an irq
fires and leads to a kernel panic.
On the other side, this timer is not used on the other rockchip version
than rk3399 because of no need of a broadcast timer, so removing these
two lines may be acceptable.
Can try the changes with another board, eg rk3288 (and forcing to use
this timer). Can you do the test and confirm it does not break with
different version of u-boot ?
Thanks!
-- Daniel
> Signed-off-by: Huang Tao <huangtao@rock-chips.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Jianqun Xu <jay.xu@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
>
> drivers/clocksource/rockchip_timer.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
> index b991b28..b93fed6 100644
> --- a/drivers/clocksource/rockchip_timer.c
> +++ b/drivers/clocksource/rockchip_timer.c
> @@ -158,9 +158,6 @@ static void __init rk_timer_init(struct device_node *np)
> ce->cpumask = cpumask_of(0);
> ce->rating = 250;
>
> - rk_timer_interrupt_clear(ce);
> - rk_timer_disable(ce);
> -
> ret = request_irq(irq, rk_timer_interrupt, IRQF_TIMER, TIMER_NAME, ce);
> if (ret) {
> pr_err("Failed to initialize '%s': %d\n", TIMER_NAME, ret);
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] clocksource: rockchip: remove unnecessary clear irq before request_irq
Date: Tue, 31 May 2016 01:09:45 +0200 [thread overview]
Message-ID: <574CC839.60608@linaro.org> (raw)
In-Reply-To: <1464169802-6033-3-git-send-email-wxt@rock-chips.com>
On 05/25/2016 11:49 AM, Caesar Wang wrote:
> From: Huang Tao <huangtao@rock-chips.com>
>
> rk_timer_interrupt_clear and rk_timer_disable is unnecessary before
> request_irq. Timer should keep disabled before booting Linux.
That's true in the perfect world :/ Some version has u-boot letting the
timer with irq enabled, therefore as soon as request_irq is done, an irq
fires and leads to a kernel panic.
On the other side, this timer is not used on the other rockchip version
than rk3399 because of no need of a broadcast timer, so removing these
two lines may be acceptable.
Can try the changes with another board, eg rk3288 (and forcing to use
this timer). Can you do the test and confirm it does not break with
different version of u-boot ?
Thanks!
-- Daniel
> Signed-off-by: Huang Tao <huangtao@rock-chips.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Jianqun Xu <jay.xu@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
>
> drivers/clocksource/rockchip_timer.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
> index b991b28..b93fed6 100644
> --- a/drivers/clocksource/rockchip_timer.c
> +++ b/drivers/clocksource/rockchip_timer.c
> @@ -158,9 +158,6 @@ static void __init rk_timer_init(struct device_node *np)
> ce->cpumask = cpumask_of(0);
> ce->rating = 250;
>
> - rk_timer_interrupt_clear(ce);
> - rk_timer_disable(ce);
> -
> ret = request_irq(irq, rk_timer_interrupt, IRQF_TIMER, TIMER_NAME, ce);
> if (ret) {
> pr_err("Failed to initialize '%s': %d\n", TIMER_NAME, ret);
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2016-05-30 23:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 9:49 [PATCH 0/5] clocksource: rockchip/timer: Support rktimer for rk3399 Caesar Wang
2016-05-25 9:49 ` Caesar Wang
2016-05-25 9:49 ` [PATCH 1/5] dt-bindings: document rk3399 rk-timer bindings Caesar Wang
2016-05-25 9:49 ` Caesar Wang
2016-05-25 19:11 ` Rob Herring
2016-05-25 19:11 ` Rob Herring
2016-05-25 19:11 ` Rob Herring
2016-05-25 9:49 ` [PATCH 2/5] clocksource: rockchip: remove unnecessary clear irq before request_irq Caesar Wang
2016-05-25 9:49 ` Caesar Wang
2016-05-30 23:09 ` Daniel Lezcano [this message]
2016-05-30 23:09 ` Daniel Lezcano
2016-05-31 17:03 ` Doug Anderson
2016-05-31 17:03 ` Doug Anderson
2016-05-31 17:03 ` Doug Anderson
2016-06-01 2:30 ` Huang, Tao
2016-06-01 2:30 ` Huang, Tao
2016-06-01 2:30 ` Huang, Tao
2016-06-01 2:36 ` Doug Anderson
2016-06-01 2:36 ` Doug Anderson
2016-06-01 2:36 ` Doug Anderson
2016-05-25 9:50 ` [PATCH 3/5] clocksource: rockchip: add dynamic irq flag to the timer Caesar Wang
2016-05-25 9:50 ` Caesar Wang
2016-05-30 23:16 ` Daniel Lezcano
2016-05-30 23:16 ` Daniel Lezcano
2016-05-31 13:45 ` Huang, Tao
2016-05-31 13:45 ` Huang, Tao
2016-05-31 13:45 ` Huang, Tao
2016-05-25 9:50 ` [PATCH 4/5] clocksource: rockchip: add support for rk3399 SoC Caesar Wang
2016-05-25 9:50 ` Caesar Wang
2016-05-30 23:28 ` Daniel Lezcano
2016-05-30 23:28 ` Daniel Lezcano
2016-05-31 13:46 ` Huang, Tao
2016-05-31 13:46 ` Huang, Tao
2016-05-31 13:46 ` Huang, Tao
2016-05-31 14:06 ` Daniel Lezcano
2016-05-31 14:06 ` Daniel Lezcano
2016-06-01 1:58 ` Huang, Tao
2016-06-01 1:58 ` Huang, Tao
2016-06-01 6:16 ` Daniel Lezcano
2016-06-01 6:16 ` Daniel Lezcano
2016-05-25 9:50 ` [PATCH 5/5] ARM64: dts: rockchip: add rktimer device node for rk3399 Caesar Wang
2016-05-25 9:50 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574CC839.60608@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=briannorris@google.com \
--cc=cf@rock-chips.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=smbarber@google.com \
--cc=tglx@linutronix.de \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.