* [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
@ 2016-05-10 18:56 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-05-10 18:56 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Vladimir Murzin
Cc: Andy Shevchenko, Geert Uytterhoeven, linux-arm-kernel,
linux-serial, Sudeep Holla
Enabling support for the UART on the ARM MPS2 platform only make sense
when compiling for the ARM MPS2 platform, unless compile-testing.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/tty/serial/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index b84810aa8621d8b1..3def7478ca44f573 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1457,7 +1457,7 @@ config SERIAL_MPS2_UART_CONSOLE
config SERIAL_MPS2_UART
bool "MPS2 UART port"
- depends on ARM || COMPILE_TEST
+ depends on ARCH_MPS2 || COMPILE_TEST
select SERIAL_CORE
help
This driver support the UART ports on ARM MPS2.
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
@ 2016-05-10 18:56 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-05-10 18:56 UTC (permalink / raw)
To: linux-arm-kernel
Enabling support for the UART on the ARM MPS2 platform only make sense
when compiling for the ARM MPS2 platform, unless compile-testing.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/tty/serial/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index b84810aa8621d8b1..3def7478ca44f573 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1457,7 +1457,7 @@ config SERIAL_MPS2_UART_CONSOLE
config SERIAL_MPS2_UART
bool "MPS2 UART port"
- depends on ARM || COMPILE_TEST
+ depends on ARCH_MPS2 || COMPILE_TEST
select SERIAL_CORE
help
This driver support the UART ports on ARM MPS2.
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
2016-05-10 18:56 ` Geert Uytterhoeven
@ 2016-05-13 8:35 ` Vladimir Murzin
-1 siblings, 0 replies; 8+ messages in thread
From: Vladimir Murzin @ 2016-05-13 8:35 UTC (permalink / raw)
To: Geert Uytterhoeven, Greg Kroah-Hartman, Jiri Slaby
Cc: Andy Shevchenko, linux-serial, linux-arm-kernel, Sudeep Holla
On 10/05/16 19:56, Geert Uytterhoeven wrote:
> Enabling support for the UART on the ARM MPS2 platform only make sense
> when compiling for the ARM MPS2 platform, unless compile-testing.
What you said is true, but looking around (see SERIAL_STM32 for example)
I'm wondering what makes MPS2 so special flake?
I was under impression that architecture/board specific guard must have
only if we have something like
#include <asm/xyz.h>
or
#include <mach/xyz.h>
which is not a case for device-tree driven MPS2 uart.
I have no idea what is practice for such things, so would be grateful to
get it known.
Cheers
Vladimir
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/tty/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index b84810aa8621d8b1..3def7478ca44f573 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1457,7 +1457,7 @@ config SERIAL_MPS2_UART_CONSOLE
>
> config SERIAL_MPS2_UART
> bool "MPS2 UART port"
> - depends on ARM || COMPILE_TEST
> + depends on ARCH_MPS2 || COMPILE_TEST
> select SERIAL_CORE
> help
> This driver support the UART ports on ARM MPS2.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
@ 2016-05-13 8:35 ` Vladimir Murzin
0 siblings, 0 replies; 8+ messages in thread
From: Vladimir Murzin @ 2016-05-13 8:35 UTC (permalink / raw)
To: linux-arm-kernel
On 10/05/16 19:56, Geert Uytterhoeven wrote:
> Enabling support for the UART on the ARM MPS2 platform only make sense
> when compiling for the ARM MPS2 platform, unless compile-testing.
What you said is true, but looking around (see SERIAL_STM32 for example)
I'm wondering what makes MPS2 so special flake?
I was under impression that architecture/board specific guard must have
only if we have something like
#include <asm/xyz.h>
or
#include <mach/xyz.h>
which is not a case for device-tree driven MPS2 uart.
I have no idea what is practice for such things, so would be grateful to
get it known.
Cheers
Vladimir
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/tty/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index b84810aa8621d8b1..3def7478ca44f573 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1457,7 +1457,7 @@ config SERIAL_MPS2_UART_CONSOLE
>
> config SERIAL_MPS2_UART
> bool "MPS2 UART port"
> - depends on ARM || COMPILE_TEST
> + depends on ARCH_MPS2 || COMPILE_TEST
> select SERIAL_CORE
> help
> This driver support the UART ports on ARM MPS2.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
2016-05-13 8:35 ` Vladimir Murzin
@ 2016-05-13 8:57 ` Geert Uytterhoeven
-1 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-05-13 8:57 UTC (permalink / raw)
To: Vladimir Murzin
Cc: Geert Uytterhoeven, Greg Kroah-Hartman, Sudeep Holla,
Andy Shevchenko, linux-serial, Jiri Slaby, linux-arm-kernel
Hi Vladimir,
On Fri, May 13, 2016 at 10:35 AM, Vladimir Murzin
<vladimir.murzin@arm.com> wrote:
> On 10/05/16 19:56, Geert Uytterhoeven wrote:
>> Enabling support for the UART on the ARM MPS2 platform only make sense
>> when compiling for the ARM MPS2 platform, unless compile-testing.
>
> What you said is true, but looking around (see SERIAL_STM32 for example)
> I'm wondering what makes MPS2 so special flake?
Nothing. SERIAL_STM32 should be fixed, too.
I only fixed SERIAL_MPS2_UART, as it was a newly-introduced symbol.
> I was under impression that architecture/board specific guard must have
> only if we have something like
>
> #include <asm/xyz.h>
>
> or
>
> #include <mach/xyz.h>
>
> which is not a case for device-tree driven MPS2 uart.
>
> I have no idea what is practice for such things, so would be grateful to
> get it known.
That's why there's an "|| COMPILE_TEST" in the dependency.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
@ 2016-05-13 8:57 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-05-13 8:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Vladimir,
On Fri, May 13, 2016 at 10:35 AM, Vladimir Murzin
<vladimir.murzin@arm.com> wrote:
> On 10/05/16 19:56, Geert Uytterhoeven wrote:
>> Enabling support for the UART on the ARM MPS2 platform only make sense
>> when compiling for the ARM MPS2 platform, unless compile-testing.
>
> What you said is true, but looking around (see SERIAL_STM32 for example)
> I'm wondering what makes MPS2 so special flake?
Nothing. SERIAL_STM32 should be fixed, too.
I only fixed SERIAL_MPS2_UART, as it was a newly-introduced symbol.
> I was under impression that architecture/board specific guard must have
> only if we have something like
>
> #include <asm/xyz.h>
>
> or
>
> #include <mach/xyz.h>
>
> which is not a case for device-tree driven MPS2 uart.
>
> I have no idea what is practice for such things, so would be grateful to
> get it known.
That's why there's an "|| COMPILE_TEST" in the dependency.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
2016-05-13 8:57 ` Geert Uytterhoeven
@ 2016-06-01 12:51 ` Vladimir Murzin
-1 siblings, 0 replies; 8+ messages in thread
From: Vladimir Murzin @ 2016-06-01 12:51 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Geert Uytterhoeven, Greg Kroah-Hartman, Sudeep Holla,
Andy Shevchenko, linux-serial, Jiri Slaby, linux-arm-kernel
On 13/05/16 09:57, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Fri, May 13, 2016 at 10:35 AM, Vladimir Murzin
> <vladimir.murzin@arm.com> wrote:
>> On 10/05/16 19:56, Geert Uytterhoeven wrote:
>>> Enabling support for the UART on the ARM MPS2 platform only make sense
>>> when compiling for the ARM MPS2 platform, unless compile-testing.
>>
>> What you said is true, but looking around (see SERIAL_STM32 for example)
>> I'm wondering what makes MPS2 so special flake?
>
> Nothing. SERIAL_STM32 should be fixed, too.
> I only fixed SERIAL_MPS2_UART, as it was a newly-introduced symbol.
>
>> I was under impression that architecture/board specific guard must have
>> only if we have something like
>>
>> #include <asm/xyz.h>
>>
>> or
>>
>> #include <mach/xyz.h>
>>
>> which is not a case for device-tree driven MPS2 uart.
>>
>> I have no idea what is practice for such things, so would be grateful to
>> get it known.
>
> That's why there's an "|| COMPILE_TEST" in the dependency.
>
First of all sorry for the late response...
Secondly, I have no strong opinion on the patch, so I'd leave the final
word to Greg
FWIW
Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
Cheers
Vladimir
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
@ 2016-06-01 12:51 ` Vladimir Murzin
0 siblings, 0 replies; 8+ messages in thread
From: Vladimir Murzin @ 2016-06-01 12:51 UTC (permalink / raw)
To: linux-arm-kernel
On 13/05/16 09:57, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Fri, May 13, 2016 at 10:35 AM, Vladimir Murzin
> <vladimir.murzin@arm.com> wrote:
>> On 10/05/16 19:56, Geert Uytterhoeven wrote:
>>> Enabling support for the UART on the ARM MPS2 platform only make sense
>>> when compiling for the ARM MPS2 platform, unless compile-testing.
>>
>> What you said is true, but looking around (see SERIAL_STM32 for example)
>> I'm wondering what makes MPS2 so special flake?
>
> Nothing. SERIAL_STM32 should be fixed, too.
> I only fixed SERIAL_MPS2_UART, as it was a newly-introduced symbol.
>
>> I was under impression that architecture/board specific guard must have
>> only if we have something like
>>
>> #include <asm/xyz.h>
>>
>> or
>>
>> #include <mach/xyz.h>
>>
>> which is not a case for device-tree driven MPS2 uart.
>>
>> I have no idea what is practice for such things, so would be grateful to
>> get it known.
>
> That's why there's an "|| COMPILE_TEST" in the dependency.
>
First of all sorry for the late response...
Secondly, I have no strong opinion on the patch, so I'd leave the final
word to Greg
FWIW
Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
Cheers
Vladimir
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-06-01 12:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-10 18:56 [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2 Geert Uytterhoeven
2016-05-10 18:56 ` Geert Uytterhoeven
2016-05-13 8:35 ` Vladimir Murzin
2016-05-13 8:35 ` Vladimir Murzin
2016-05-13 8:57 ` Geert Uytterhoeven
2016-05-13 8:57 ` Geert Uytterhoeven
2016-06-01 12:51 ` Vladimir Murzin
2016-06-01 12:51 ` Vladimir Murzin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.