All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xing Zheng <zhengxing@rock-chips.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	linux-rockchip@lists.infradead.org, dianders@chromium.org,
	heiko@sntech.de, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219
Date: Tue, 07 Jun 2016 20:47:01 +0800	[thread overview]
Message-ID: <5756C245.7010001@rock-chips.com> (raw)
In-Reply-To: <20160607120647.GV7510@sirena.org.uk>

Hi Mark,

On 2016年06月07日 20:06, Mark Brown wrote:
> OK, then the original name probably makes some sense though really
> that's such an unusual design that just naming it after the specific
> board might be better, it's not likely to see any reuse I'd guess.
There are not only one type of board with this audio connection, so I 
think we don't need to add specific board name.

Therefore, I intend to recover original name 
(rk3399_max98357a_rt5514_da7219.c), and description like this:
sound {
     compatible = "rockchip,rk3399-max98357a-rt5514-da7219";
     rockchip,cpu = <&i2s0 &i2s0 &i2s0>;               // note (will not 
be sent to upstream): In future, we may use the i2s1 or i2s2...
     rockchip,codec = <&max98357a &headsetcodec &codec>;
};

Could you please agree to do this?

Thanks.

-- 
- Xing Zheng

WARNING: multiple messages have this Message-ID (diff)
From: Xing Zheng <zhengxing@rock-chips.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh@kernel.org>,
	alsa-devel@alsa-project.org, heiko@sntech.de,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
	dianders@chromium.org, Liam Girdwood <lgirdwood@gmail.com>,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	Kumar Gala <galak@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219
Date: Tue, 07 Jun 2016 20:47:01 +0800	[thread overview]
Message-ID: <5756C245.7010001@rock-chips.com> (raw)
In-Reply-To: <20160607120647.GV7510@sirena.org.uk>

Hi Mark,

On 2016年06月07日 20:06, Mark Brown wrote:
> OK, then the original name probably makes some sense though really
> that's such an unusual design that just naming it after the specific
> board might be better, it's not likely to see any reuse I'd guess.
There are not only one type of board with this audio connection, so I 
think we don't need to add specific board name.

Therefore, I intend to recover original name 
(rk3399_max98357a_rt5514_da7219.c), and description like this:
sound {
     compatible = "rockchip,rk3399-max98357a-rt5514-da7219";
     rockchip,cpu = <&i2s0 &i2s0 &i2s0>;               // note (will not 
be sent to upstream): In future, we may use the i2s1 or i2s2...
     rockchip,codec = <&max98357a &headsetcodec &codec>;
};

Could you please agree to do this?

Thanks.

-- 
- Xing Zheng


_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: zhengxing@rock-chips.com (Xing Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219
Date: Tue, 07 Jun 2016 20:47:01 +0800	[thread overview]
Message-ID: <5756C245.7010001@rock-chips.com> (raw)
In-Reply-To: <20160607120647.GV7510@sirena.org.uk>

Hi Mark,

On 2016?06?07? 20:06, Mark Brown wrote:
> OK, then the original name probably makes some sense though really
> that's such an unusual design that just naming it after the specific
> board might be better, it's not likely to see any reuse I'd guess.
There are not only one type of board with this audio connection, so I 
think we don't need to add specific board name.

Therefore, I intend to recover original name 
(rk3399_max98357a_rt5514_da7219.c), and description like this:
sound {
     compatible = "rockchip,rk3399-max98357a-rt5514-da7219";
     rockchip,cpu = <&i2s0 &i2s0 &i2s0>;               // note (will not 
be sent to upstream): In future, we may use the i2s1 or i2s2...
     rockchip,codec = <&max98357a &headsetcodec &codec>;
};

Could you please agree to do this?

Thanks.

-- 
- Xing Zheng

  reply	other threads:[~2016-06-07 12:47 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 13:02 [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219 Xing Zheng
2016-05-26 13:02 ` Xing Zheng
2016-05-30  7:32 ` Xing Zheng
2016-05-30  7:32   ` Xing Zheng
2016-05-30  7:32   ` Xing Zheng
2016-05-30 16:03   ` Mark Brown
2016-05-30 16:03     ` Mark Brown
2016-05-30 16:03     ` Mark Brown
2016-06-01 14:45 ` Rob Herring
2016-06-01 14:45   ` Rob Herring
2016-06-03 14:16   ` Xing Zheng
2016-06-03 14:16     ` Xing Zheng
2016-06-03 14:16     ` Xing Zheng
2016-06-06 23:50     ` Mark Brown
2016-06-06 23:50       ` Mark Brown
2016-06-07  2:49       ` Xing Zheng
2016-06-07  2:49         ` Xing Zheng
2016-06-07  2:49         ` Xing Zheng
2016-06-07 10:47         ` Mark Brown
2016-06-07 10:47           ` Mark Brown
2016-06-07 10:47           ` Mark Brown
2016-06-07 11:38           ` Xing Zheng
2016-06-07 11:38             ` Xing Zheng
2016-06-07 12:06             ` Mark Brown
2016-06-07 12:06               ` Mark Brown
2016-06-07 12:06               ` Mark Brown
2016-06-07 12:47               ` Xing Zheng [this message]
2016-06-07 12:47                 ` Xing Zheng
2016-06-07 12:47                 ` Xing Zheng
2016-06-07 13:32                 ` Mark Brown
2016-06-07 13:32                   ` Mark Brown
2016-06-07 13:32                   ` Mark Brown
2016-06-07 13:48                   ` Xing Zheng
2016-06-07 13:48                     ` Xing Zheng
2016-06-07 13:48                     ` Xing Zheng
2016-06-07 14:54                     ` Mark Brown
2016-06-07 14:54                       ` Mark Brown
2016-06-07 14:54                       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5756C245.7010001@rock-chips.com \
    --to=zhengxing@rock-chips.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.