All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Julien Grall <julien.grall@arm.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Shannon Zhao <zhaoshenglong@huawei.com>
Cc: peter.huangpeng@huawei.com, sstabellini@kernel.org,
	ian.jackson@eu.citrix.com, shannon.zhao@linaro.org,
	xen-devel@lists.xen.org
Subject: Re: [PATCH RESEND 00/14] Xen ARM DomU ACPI support
Date: Tue, 7 Jun 2016 10:24:30 -0400	[thread overview]
Message-ID: <5756D91E.2070407@oracle.com> (raw)
In-Reply-To: <5756A803.1080302@arm.com>

On 06/07/2016 06:54 AM, Julien Grall wrote:
> Hello Boris,
>
> On 06/06/16 17:50, Boris Ostrovsky wrote:
>> On 06/06/2016 11:37 AM, Boris Ostrovsky wrote:
>>>> What I don't want to see is that x86 builds its ACPI table in libxc
>>>> while ARM builds its in libxl. That would make future merger harder.
>>>>
>>>> Boris?
>>> TBH, I am not sure which library this should really belong to. I felt
>>> libxc would be more appropriate.
>>
>> Actually, I now remember why I picked libxc: because I wanted ACPI pages
>> to be loaded as part of xc_dom_build_image().
>
> What about adding a new field in xc_dom_image? For the device tree,
> libxl is provide a buffer which will be loaded as part of
> xc_dom_build_image (see devicetree_blob).

Yes, I think we can do this (although I suspect we will need more than
one field there).

Still, we need first to understand where this code should live logically
(i.e. is this the type of things that libxl does or is it the type of
things that libxc does) instead of trying to see where we can jam it.

(And only then we will argue that we can't put it in that logical place
due to whatever excuses we can come up with ;-) )

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-07 14:24 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31  5:02 [PATCH RESEND 00/14] Xen ARM DomU ACPI support Shannon Zhao
2016-05-31  5:02 ` [PATCH RESEND 01/14] libxl/arm: Fix the function name in error log Shannon Zhao
2016-06-03 19:25   ` Wei Liu
2016-06-17 10:46     ` Wei Liu
2016-06-20  1:12       ` Shannon Zhao
2016-05-31  5:02 ` [PATCH RESEND 02/14] libxl/arm: Factor out codes for generating DTB Shannon Zhao
2016-06-03 19:25   ` Wei Liu
2016-05-31  5:02 ` [PATCH RESEND 03/14] libxc: Add placeholders for ACPI tables blob and size Shannon Zhao
2016-06-06 10:00   ` Stefano Stabellini
2016-06-06 12:16     ` Wei Liu
2016-06-06 14:20       ` Shannon Zhao
2016-06-07 11:05   ` Julien Grall
2016-06-07 11:13     ` Shannon Zhao
2016-06-07 11:27       ` Julien Grall
2016-06-07 11:35         ` Shannon Zhao
2016-06-07 11:42           ` Julien Grall
2016-06-07 11:59             ` Shannon Zhao
2016-06-07 12:06               ` Julien Grall
2016-06-07 12:32                 ` Shannon Zhao
2016-06-07 13:06                   ` Julien Grall
2016-06-16  6:53                     ` Shannon Zhao
2016-06-16 10:21                       ` Julien Grall
2016-06-16 10:45                         ` Shannon Zhao
2016-06-16 11:04                           ` Julien Grall
2016-06-16 10:49                   ` Wei Liu
2016-06-16 10:53                     ` Shannon Zhao
2016-06-16 11:04                       ` Wei Liu
2016-06-07 12:02             ` Julien Grall
2016-06-07 12:27               ` Shannon Zhao
2016-05-31  5:02 ` [PATCH RESEND 04/14] tools: add ACPI tables relevant definitions Shannon Zhao
2016-06-06 10:04   ` Stefano Stabellini
2016-06-06 10:11     ` Julien Grall
2016-06-06 10:27       ` Shannon Zhao
2016-06-06 12:16         ` Wei Liu
2016-06-06 14:19           ` Shannon Zhao
2016-06-22  3:24           ` Shannon Zhao
2016-06-22  8:35             ` Julien Grall
2016-06-22  8:50               ` Shannon Zhao
2016-06-22  8:55                 ` Julien Grall
2016-06-22  9:38             ` [PATCH RESEND 04/14] tools: add ACPI tables relevant definitions (and more) Wei Liu
2016-06-22 10:06               ` Shannon Zhao
2016-05-31  5:02 ` [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table Shannon Zhao
2016-06-06 11:40   ` Stefano Stabellini
2016-06-06 11:52     ` Julien Grall
2016-06-06 12:04       ` Stefano Stabellini
2016-06-06 14:31         ` Shannon Zhao
2016-06-06 14:50           ` Stefano Stabellini
2016-06-06 15:42             ` Julien Grall
2016-06-07  9:41               ` Stefano Stabellini
2016-06-06 15:35         ` Julien Grall
2016-06-07  9:48           ` Stefano Stabellini
2016-06-07 11:55             ` Wei Liu
2016-06-17  3:29     ` Shannon Zhao
2016-06-17  8:17       ` Julien Grall
2016-06-17  9:15         ` Stefano Stabellini
2016-06-17 13:27           ` Julien Grall
2016-06-06 12:18   ` Wei Liu
2016-06-07 11:02     ` Julien Grall
2016-06-07 11:19   ` Julien Grall
2016-06-07 11:30     ` Shannon Zhao
2016-06-07 11:36       ` Julien Grall
2016-06-07 11:39         ` Shannon Zhao
2016-06-07 11:43           ` Julien Grall
2016-05-31  5:02 ` [PATCH RESEND 06/14] libxl/arm: Construct ACPI FADT table Shannon Zhao
2016-06-07 13:17   ` Julien Grall
2016-06-07 14:13     ` Shannon Zhao
2016-06-07 14:14       ` Julien Grall
2016-05-31  5:02 ` [PATCH RESEND 07/14] libxl/arm: Construct ACPI DSDT table Shannon Zhao
2016-06-07 13:42   ` Julien Grall
2016-06-16  6:25     ` Shannon Zhao
2016-06-16  9:44       ` Julien Grall
2016-06-16 10:01         ` Stefano Stabellini
2016-05-31  5:03 ` [PATCH RESEND 08/14] libxl/arm: Construct ACPI MADT table Shannon Zhao
2016-06-07 13:40   ` Julien Grall
2016-05-31  5:03 ` [PATCH RESEND 09/14] libxl/arm: Construct ACPI XSDT table Shannon Zhao
2016-05-31  5:03 ` [PATCH RESEND 10/14] libxl/arm: Construct ACPI RSDP table Shannon Zhao
2016-05-31  5:03 ` [PATCH RESEND 11/14] libxl/arm: Initialize domain param HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-05-31  5:03 ` [PATCH RESEND 12/14] libxl/arm: Add ACPI module Shannon Zhao
2016-06-07 13:47   ` Julien Grall
2016-05-31  5:03 ` [PATCH RESEND 13/14] libxl/arm: initialize memory information of ACPI blob Shannon Zhao
2016-06-06 11:40   ` Stefano Stabellini
2016-06-06 14:35     ` Shannon Zhao
2016-05-31  5:03 ` [PATCH RESEND 14/14] libxc/xc_dom_core: Copy ACPI tables to guest memory space Shannon Zhao
2016-05-31 10:47 ` [PATCH RESEND 00/14] Xen ARM DomU ACPI support Julien Grall
2016-05-31 14:19   ` Shannon Zhao
2016-06-03 19:24 ` Wei Liu
2016-06-03 20:02   ` Konrad Rzeszutek Wilk
2016-06-03 20:20     ` Boris Ostrovsky
2016-06-03 20:27       ` Wei Liu
2016-06-03 20:36         ` Boris Ostrovsky
2016-06-06 11:41 ` Stefano Stabellini
2016-06-06 12:26 ` Wei Liu
2016-06-06 15:37   ` Boris Ostrovsky
2016-06-06 16:50     ` Boris Ostrovsky
2016-06-07 10:54       ` Julien Grall
2016-06-07 14:24         ` Boris Ostrovsky [this message]
2016-06-06 15:48   ` Julien Grall
2016-06-07  1:07     ` Shannon Zhao
2016-06-07 11:00       ` Julien Grall
2016-06-16 11:20         ` Wei Liu
2016-06-16 13:25           ` Boris Ostrovsky
2016-06-17 10:14             ` Wei Liu
2016-06-17  2:03           ` Shannon Zhao
2016-06-17  8:18           ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5756D91E.2070407@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=julien.grall@arm.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=shannon.zhao@linaro.org \
    --cc=sstabellini@kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.