All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] soc: brcmstb: fix warning from missing include
@ 2016-06-07 17:54 Ben Dooks
  2016-06-07 20:53 ` Florian Fainelli
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2016-06-07 17:54 UTC (permalink / raw)
  To: linux-arm-kernel

The brcmstb_biuctrl_init() is defined in the soc specific header
file, but wasn't included in the driver file. Fix the following
warning by including <linux/soc/brcmstb/brcmstb.h> in the driver:

drivers/soc/brcmstb/biuctrl.c:101:13: warning: symbol 'brcmstb_biuctrl_init' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Gregory Fong <gregory.0xf0@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: bcm-kernel-feedback-list at broadcom.com
---
 drivers/soc/brcmstb/biuctrl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/brcmstb/biuctrl.c b/drivers/soc/brcmstb/biuctrl.c
index 9049c076f..3c39415 100644
--- a/drivers/soc/brcmstb/biuctrl.c
+++ b/drivers/soc/brcmstb/biuctrl.c
@@ -19,6 +19,7 @@
 #include <linux/io.h>
 #include <linux/of_address.h>
 #include <linux/syscore_ops.h>
+#include <linux/soc/brcmstb/brcmstb.h>
 
 #define CPU_CREDIT_REG_OFFSET			0x184
 #define  CPU_CREDIT_REG_MCPx_WR_PAIRING_EN_MASK	0x70000000
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] soc: brcmstb: fix warning from missing include
  2016-06-07 17:54 [PATCH] soc: brcmstb: fix warning from missing include Ben Dooks
@ 2016-06-07 20:53 ` Florian Fainelli
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2016-06-07 20:53 UTC (permalink / raw)
  To: linux-arm-kernel

On 06/07/2016 10:54 AM, Ben Dooks wrote:
> The brcmstb_biuctrl_init() is defined in the soc specific header
> file, but wasn't included in the driver file. Fix the following
> warning by including <linux/soc/brcmstb/brcmstb.h> in the driver:
> 
> drivers/soc/brcmstb/biuctrl.c:101:13: warning: symbol 'brcmstb_biuctrl_init' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Applied, thanks Ben!
-- 
Florian

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-07 20:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-07 17:54 [PATCH] soc: brcmstb: fix warning from missing include Ben Dooks
2016-06-07 20:53 ` Florian Fainelli

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.