* [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too
@ 2016-06-08 8:13 Thomas Huth
2016-06-08 8:45 ` Daniel P. Berrange
2016-06-08 14:09 ` Stefan Hajnoczi
0 siblings, 2 replies; 5+ messages in thread
From: Thomas Huth @ 2016-06-08 8:13 UTC (permalink / raw)
To: Peter Maydell, Stefan Weil, qemu-devel
Cc: Stefan Hajnoczi, Daniel P. Berrange, Paolo Bonzini, Yuri Pudgorodskiy
MinGW seems to compile currently without warnings, so it should
be safe to enable -Werror now for this environment, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
... at least it compiles without errors for me here. I hope that's
also true for different versions of MinGW ... would be great if
everybody who has such a compiler installed could give it a try!
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 4627d2c..2e5b818 100755
--- a/configure
+++ b/configure
@@ -1393,7 +1393,7 @@ z_version=$(cut -f3 -d. $source_path/VERSION)
if test -z "$werror" ; then
if test -d "$source_path/.git" -a \
- "$linux" = "yes" ; then
+ \( "$linux" = "yes" -o "$mingw32" = "yes" \) ; then
werror="yes"
else
werror="no"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too
2016-06-08 8:13 [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too Thomas Huth
@ 2016-06-08 8:45 ` Daniel P. Berrange
2016-06-08 14:09 ` Stefan Hajnoczi
1 sibling, 0 replies; 5+ messages in thread
From: Daniel P. Berrange @ 2016-06-08 8:45 UTC (permalink / raw)
To: Thomas Huth
Cc: Peter Maydell, Stefan Weil, qemu-devel, Stefan Hajnoczi,
Paolo Bonzini, Yuri Pudgorodskiy
On Wed, Jun 08, 2016 at 10:13:26AM +0200, Thomas Huth wrote:
> MinGW seems to compile currently without warnings, so it should
> be safe to enable -Werror now for this environment, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> ... at least it compiles without errors for me here. I hope that's
> also true for different versions of MinGW ... would be great if
> everybody who has such a compiler installed could give it a try!
Heh, I have created exactly the same patch locally myself a few
months back after noticed that Mingw was now warning-free. I
never got around to sending it for some reason :-) I confirm that
it is still warning free today, on Fedora 23, x86_64 host.
>
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4627d2c..2e5b818 100755
> --- a/configure
> +++ b/configure
> @@ -1393,7 +1393,7 @@ z_version=$(cut -f3 -d. $source_path/VERSION)
>
> if test -z "$werror" ; then
> if test -d "$source_path/.git" -a \
> - "$linux" = "yes" ; then
> + \( "$linux" = "yes" -o "$mingw32" = "yes" \) ; then
> werror="yes"
> else
> werror="no"
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too
2016-06-08 8:13 [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too Thomas Huth
2016-06-08 8:45 ` Daniel P. Berrange
@ 2016-06-08 14:09 ` Stefan Hajnoczi
2016-06-08 18:55 ` Peter Maydell
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2016-06-08 14:09 UTC (permalink / raw)
To: Thomas Huth
Cc: Peter Maydell, Stefan Weil, qemu-devel, Daniel P. Berrange,
Paolo Bonzini, Yuri Pudgorodskiy
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Wed, Jun 08, 2016 at 10:13:26AM +0200, Thomas Huth wrote:
> MinGW seems to compile currently without warnings, so it should
> be safe to enable -Werror now for this environment, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> ... at least it compiles without errors for me here. I hope that's
> also true for different versions of MinGW ... would be great if
> everybody who has such a compiler installed could give it a try!
>
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
mingw 5.2.0-1.fc23 does not produce any warnings anymore.
Tested-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too
2016-06-08 14:09 ` Stefan Hajnoczi
@ 2016-06-08 18:55 ` Peter Maydell
2016-06-08 19:52 ` Stefan Weil
0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2016-06-08 18:55 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Thomas Huth, Stefan Weil, QEMU Developers, Daniel P. Berrange,
Paolo Bonzini, Yuri Pudgorodskiy
On 8 June 2016 at 15:09, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> On Wed, Jun 08, 2016 at 10:13:26AM +0200, Thomas Huth wrote:
>> MinGW seems to compile currently without warnings, so it should
>> be safe to enable -Werror now for this environment, too.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> ... at least it compiles without errors for me here. I hope that's
>> also true for different versions of MinGW ... would be great if
>> everybody who has such a compiler installed could give it a try!
>>
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> mingw 5.2.0-1.fc23 does not produce any warnings anymore.
>
> Tested-by: Stefan Hajnoczi <stefanha@redhat.com>
My w32/w64 builds need -Wno-unused-local-typedefs to build
with -Werror, but that's the fault of the glib headers I build
against and I already configure like that in order to use -Werror.
We should check whether we can enable -Werror for OSX too.
thanks
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too
2016-06-08 18:55 ` Peter Maydell
@ 2016-06-08 19:52 ` Stefan Weil
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Weil @ 2016-06-08 19:52 UTC (permalink / raw)
To: Peter Maydell, Stefan Hajnoczi
Cc: Thomas Huth, QEMU Developers, Daniel P. Berrange, Paolo Bonzini,
Yuri Pudgorodskiy
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
Am 08.06.2016 um 20:55 schrieb Peter Maydell:
> On 8 June 2016 at 15:09, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>> On Wed, Jun 08, 2016 at 10:13:26AM +0200, Thomas Huth wrote:
>>> MinGW seems to compile currently without warnings, so it should
>>> be safe to enable -Werror now for this environment, too.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>> ... at least it compiles without errors for me here. I hope that's
>>> also true for different versions of MinGW ... would be great if
>>> everybody who has such a compiler installed could give it a try!
>>>
>>> configure | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> mingw 5.2.0-1.fc23 does not produce any warnings anymore.
>>
>> Tested-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> My w32/w64 builds need -Wno-unused-local-typedefs to build
> with -Werror, but that's the fault of the glib headers I build
> against and I already configure like that in order to use -Werror.
>
> We should check whether we can enable -Werror for OSX too.
>
> thanks
> -- PMM
The last time when I tried OS X there were some deprecation warnings.
If those are fixed now we can enable -Werror for all target platforms
(we could do that anyway because in case of problems it's always
possible to disable it for individual builds).
Stefan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-08 19:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-08 8:13 [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too Thomas Huth
2016-06-08 8:45 ` Daniel P. Berrange
2016-06-08 14:09 ` Stefan Hajnoczi
2016-06-08 18:55 ` Peter Maydell
2016-06-08 19:52 ` Stefan Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.