From: Inki Dae <inki.dae@samsung.com> To: Javier Martinez Canillas <javier@osg.samsung.com>, linux-kernel@vger.kernel.org Cc: Marc Zyngier <marc.zyngier@arm.com>, Kukjin Kim <kgene@kernel.org>, Seung-Woo Kim <sw0312.kim@samsung.com>, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, Kyungmin Park <kyungmin.park@samsung.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, David Airlie <airlied@linux.ie>, Joonyoung Shim <jy0922.shim@samsung.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800 Date: Thu, 09 Jun 2016 08:09:01 +0900 [thread overview] Message-ID: <5758A58D.7050106@samsung.com> (raw) In-Reply-To: <1464877210-27207-1-git-send-email-javier@osg.samsung.com> Hi Javier, 2016년 06월 02일 23:20에 Javier Martinez Canillas 이(가) 쓴 글: > Commit a6f75aa161c5 ("drm/exynos: fimd: add HW trigger support") added > hardware trigger support to the FIMD controller driver. But this broke > the display in at least the Exynos5800 Peach Pi Chromebook. > > So until the issue is fixed, avoid using HW trigger for the Exynos5420 > based boards and use SW trigger as it was before the mentioned commit. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > Hello Inki, > > Since commit a6f75aa161c5 landed in v4.7-rc1, I think $SUBJECT should be > picked to make sure that v4.7 is released with the display working for > the Exynos5420 based Chromebooks. > > We can then figure out what's wrong with the HW trigger support and fix > it for v4.8. Agree. And below is a trivial comment. > > Best regards, > Javier > > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 1c23a8ff5e83..f10030ff00e6 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -170,14 +170,11 @@ static struct fimd_driver_data exynos5420_fimd_driver_data = { > .lcdblk_vt_shift = 24, > .lcdblk_bypass_shift = 15, > .lcdblk_mic_bypass_shift = 11, > - .trg_type = I80_HW_TRG, > .has_shadowcon = 1, > .has_vidoutcon = 1, > .has_vtsel = 1, > .has_mic_bypass = 1, > .has_dp_clk = 1, > - .has_hw_trigger = 1, > - .has_trigger_per_te = 1, We don't need to remove above two lines. It would be enough to remove 'trg_type = I80_HW_TRG', which makes FIMD to be worked with SW trigger in default. Thanks, Inki Dae > }; > > struct fimd_context { >
WARNING: multiple messages have this Message-ID (diff)
From: inki.dae@samsung.com (Inki Dae) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800 Date: Thu, 09 Jun 2016 08:09:01 +0900 [thread overview] Message-ID: <5758A58D.7050106@samsung.com> (raw) In-Reply-To: <1464877210-27207-1-git-send-email-javier@osg.samsung.com> Hi Javier, 2016? 06? 02? 23:20? Javier Martinez Canillas ?(?) ? ?: > Commit a6f75aa161c5 ("drm/exynos: fimd: add HW trigger support") added > hardware trigger support to the FIMD controller driver. But this broke > the display in at least the Exynos5800 Peach Pi Chromebook. > > So until the issue is fixed, avoid using HW trigger for the Exynos5420 > based boards and use SW trigger as it was before the mentioned commit. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > Hello Inki, > > Since commit a6f75aa161c5 landed in v4.7-rc1, I think $SUBJECT should be > picked to make sure that v4.7 is released with the display working for > the Exynos5420 based Chromebooks. > > We can then figure out what's wrong with the HW trigger support and fix > it for v4.8. Agree. And below is a trivial comment. > > Best regards, > Javier > > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 1c23a8ff5e83..f10030ff00e6 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -170,14 +170,11 @@ static struct fimd_driver_data exynos5420_fimd_driver_data = { > .lcdblk_vt_shift = 24, > .lcdblk_bypass_shift = 15, > .lcdblk_mic_bypass_shift = 11, > - .trg_type = I80_HW_TRG, > .has_shadowcon = 1, > .has_vidoutcon = 1, > .has_vtsel = 1, > .has_mic_bypass = 1, > .has_dp_clk = 1, > - .has_hw_trigger = 1, > - .has_trigger_per_te = 1, We don't need to remove above two lines. It would be enough to remove 'trg_type = I80_HW_TRG', which makes FIMD to be worked with SW trigger in default. Thanks, Inki Dae > }; > > struct fimd_context { >
next prev parent reply other threads:[~2016-06-08 23:09 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20160602142058epcas1p4f26bc6ab2acd0012962f90bb2c6c4141@epcas1p4.samsung.com> 2016-06-02 14:20 ` [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800 Javier Martinez Canillas 2016-06-02 14:20 ` Javier Martinez Canillas 2016-06-02 14:20 ` Javier Martinez Canillas 2016-06-08 23:09 ` Inki Dae [this message] 2016-06-08 23:09 ` Inki Dae 2016-06-09 0:17 ` Javier Martinez Canillas 2016-06-09 0:17 ` Javier Martinez Canillas 2016-06-09 22:35 ` Inki Dae 2016-06-09 22:35 ` Inki Dae 2016-06-09 22:35 ` Inki Dae 2016-06-10 0:24 ` Javier Martinez Canillas 2016-06-10 0:24 ` Javier Martinez Canillas 2016-06-10 0:24 ` Javier Martinez Canillas 2016-06-13 1:38 ` Inki Dae 2016-06-13 1:38 ` Inki Dae 2016-06-13 1:38 ` Inki Dae
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5758A58D.7050106@samsung.com \ --to=inki.dae@samsung.com \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=javier@osg.samsung.com \ --cc=jy0922.shim@samsung.com \ --cc=k.kozlowski@samsung.com \ --cc=kgene@kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=sw0312.kim@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.