From: Roger Quadros <rogerq@ti.com> To: <peter.chen@freescale.com>, Joe Perches <joe@perches.com> Cc: <balbi@kernel.org>, <tony@atomide.com>, <gregkh@linuxfoundation.org>, <dan.j.williams@intel.com>, <mathias.nyman@linux.intel.com>, <Joao.Pinto@synopsys.com>, <sergei.shtylyov@cogentembedded.com>, <jun.li@freescale.com>, <grygorii.strashko@ti.com>, <yoshihiro.shimoda.uh@renesas.com>, <robh@kernel.org>, <nsekhar@ti.com>, <b-liu@ti.com>, <linux-usb@vger.kernel.org>, <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <rogerq@ti.com> Subject: [PATCH v10 11/14] usb: otg: use dev_dbg() instead of VDBG() Date: Thu, 9 Jun 2016 10:55:05 +0300 [thread overview] Message-ID: <575920D9.7080905@ti.com> (raw) In-Reply-To: <1465376626-30122-12-git-send-email-rogerq@ti.com> Now that we have a device reference in struct usb_otg let's use dev_vdbg() for debug messages instead of VDBG(). Signed-off-by: Roger Quadros <rogerq@ti.com> Acked-by: Peter Chen <peter.chen@nxp.com> --- v10: - in the commit message say dev_vdbg() instead of dev_dbg() drivers/usb/common/usb-otg-fsm.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/usb-otg-fsm.c index 482d4c9..e6e58c2 100644 --- a/drivers/usb/common/usb-otg-fsm.c +++ b/drivers/usb/common/usb-otg-fsm.c @@ -30,13 +30,6 @@ #include <linux/usb/otg.h> #include <linux/usb/otg-fsm.h> -#ifdef VERBOSE -#define VDBG(fmt, args...) pr_debug("[%s] " fmt, \ - __func__, ## args) -#else -#define VDBG(stuff...) do {} while (0) -#endif - /* Change USB protocol when there is a protocol change */ static int otg_set_protocol(struct otg_fsm *fsm, int protocol) { @@ -44,8 +37,9 @@ static int otg_set_protocol(struct otg_fsm *fsm, int protocol) int ret = 0; if (fsm->protocol != protocol) { - VDBG("Changing role fsm->protocol= %d; new protocol= %d\n", - fsm->protocol, protocol); + dev_vdbg(otg->dev, + "Changing role fsm->protocol= %d; new protocol= %d\n", + fsm->protocol, protocol); /* stop old protocol */ if (fsm->protocol == PROTO_HOST) ret = otg_start_host(otg, 0); @@ -226,7 +220,7 @@ static int otg_set_state(struct otg_fsm *fsm, enum usb_otg_state new_state) if (otg->state == new_state) return 0; - VDBG("Set state: %s\n", usb_otg_state_string(new_state)); + dev_vdbg(otg->dev, "Set state: %s\n", usb_otg_state_string(new_state)); otg_leave_state(fsm, otg->state); switch (new_state) { case OTG_STATE_B_IDLE: @@ -358,7 +352,7 @@ int otg_statemachine(struct usb_otg *otg) switch (state) { case OTG_STATE_UNDEFINED: - VDBG("fsm->id = %d\n", fsm->id); + dev_vdbg(otg->dev, "fsm->id = %d\n", fsm->id); if (fsm->id) otg_set_state(fsm, OTG_STATE_B_IDLE); else @@ -466,7 +460,8 @@ int otg_statemachine(struct usb_otg *otg) } mutex_unlock(&fsm->lock); - VDBG("quit statemachine, changed = %d\n", fsm->state_changed); + dev_vdbg(otg->dev, "quit statemachine, changed = %d\n", + fsm->state_changed); return fsm->state_changed; } EXPORT_SYMBOL_GPL(otg_statemachine); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org> To: peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org, Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> Cc: balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org, jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org, grygorii.strashko-l0cyMroinI0@public.gmane.org, yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, b-liu-l0cyMroinI0@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rogerq-l0cyMroinI0@public.gmane.org Subject: [PATCH v10 11/14] usb: otg: use dev_dbg() instead of VDBG() Date: Thu, 9 Jun 2016 10:55:05 +0300 [thread overview] Message-ID: <575920D9.7080905@ti.com> (raw) In-Reply-To: <1465376626-30122-12-git-send-email-rogerq-l0cyMroinI0@public.gmane.org> Now that we have a device reference in struct usb_otg let's use dev_vdbg() for debug messages instead of VDBG(). Signed-off-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org> Acked-by: Peter Chen <peter.chen-3arQi8VN3Tc@public.gmane.org> --- v10: - in the commit message say dev_vdbg() instead of dev_dbg() drivers/usb/common/usb-otg-fsm.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/usb-otg-fsm.c index 482d4c9..e6e58c2 100644 --- a/drivers/usb/common/usb-otg-fsm.c +++ b/drivers/usb/common/usb-otg-fsm.c @@ -30,13 +30,6 @@ #include <linux/usb/otg.h> #include <linux/usb/otg-fsm.h> -#ifdef VERBOSE -#define VDBG(fmt, args...) pr_debug("[%s] " fmt, \ - __func__, ## args) -#else -#define VDBG(stuff...) do {} while (0) -#endif - /* Change USB protocol when there is a protocol change */ static int otg_set_protocol(struct otg_fsm *fsm, int protocol) { @@ -44,8 +37,9 @@ static int otg_set_protocol(struct otg_fsm *fsm, int protocol) int ret = 0; if (fsm->protocol != protocol) { - VDBG("Changing role fsm->protocol= %d; new protocol= %d\n", - fsm->protocol, protocol); + dev_vdbg(otg->dev, + "Changing role fsm->protocol= %d; new protocol= %d\n", + fsm->protocol, protocol); /* stop old protocol */ if (fsm->protocol == PROTO_HOST) ret = otg_start_host(otg, 0); @@ -226,7 +220,7 @@ static int otg_set_state(struct otg_fsm *fsm, enum usb_otg_state new_state) if (otg->state == new_state) return 0; - VDBG("Set state: %s\n", usb_otg_state_string(new_state)); + dev_vdbg(otg->dev, "Set state: %s\n", usb_otg_state_string(new_state)); otg_leave_state(fsm, otg->state); switch (new_state) { case OTG_STATE_B_IDLE: @@ -358,7 +352,7 @@ int otg_statemachine(struct usb_otg *otg) switch (state) { case OTG_STATE_UNDEFINED: - VDBG("fsm->id = %d\n", fsm->id); + dev_vdbg(otg->dev, "fsm->id = %d\n", fsm->id); if (fsm->id) otg_set_state(fsm, OTG_STATE_B_IDLE); else @@ -466,7 +460,8 @@ int otg_statemachine(struct usb_otg *otg) } mutex_unlock(&fsm->lock); - VDBG("quit statemachine, changed = %d\n", fsm->state_changed); + dev_vdbg(otg->dev, "quit statemachine, changed = %d\n", + fsm->state_changed); return fsm->state_changed; } EXPORT_SYMBOL_GPL(otg_statemachine); -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-09 7:56 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-08 9:03 [PATCH v9 00/14] USB OTG/dual-role framework Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 01/14] usb: hcd: Initialize hcd->flags to 0 Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 02/14] usb: otg-fsm: Prevent build warning "VDBG" redefined Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 03/14] usb: hcd.h: Add OTG to HCD interface Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 11:39 ` Sergei Shtylyov 2016-06-08 11:39 ` Sergei Shtylyov 2016-06-08 12:04 ` Roger Quadros 2016-06-08 12:04 ` Roger Quadros 2016-06-08 12:10 ` Sergei Shtylyov 2016-06-08 12:10 ` Sergei Shtylyov 2016-06-09 7:31 ` Roger Quadros 2016-06-09 7:31 ` Roger Quadros 2016-06-09 10:16 ` Sergei Shtylyov 2016-06-09 14:11 ` Alan Stern 2016-06-09 14:11 ` Alan Stern 2016-06-10 7:01 ` Roger Quadros 2016-06-10 7:01 ` Roger Quadros 2016-06-09 7:51 ` [PATCH v10 " Roger Quadros 2016-06-09 7:51 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 04/14] usb: otg-fsm: use usb_otg wherever possible Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 05/14] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 06/14] usb: gadget.h: Add OTG to gadget interface Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 07/14] usb: otg: get rid of CONFIG_USB_OTG_FSM in favour of CONFIG_USB_OTG Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 08/14] usb: otg: add OTG/dual-role core Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 9:53 ` Peter Chen 2016-06-08 10:12 ` Roger Quadros 2016-06-08 10:12 ` Roger Quadros 2016-06-08 12:42 ` Peter Chen 2016-06-08 12:42 ` Peter Chen 2016-06-09 7:24 ` Roger Quadros 2016-06-09 7:24 ` Roger Quadros 2016-06-12 6:26 ` Peter Chen 2016-06-12 6:26 ` Peter Chen 2016-06-12 10:56 ` Peter Chen 2016-06-09 7:53 ` [PATCH v10 " Roger Quadros 2016-06-09 7:53 ` Roger Quadros 2016-06-09 12:34 ` Sergei Shtylyov 2016-06-10 7:04 ` Roger Quadros 2016-06-10 7:04 ` Roger Quadros 2016-06-10 10:19 ` Roger Quadros 2016-06-10 10:19 ` Roger Quadros 2016-06-10 10:44 ` Sergei Shtylyov 2016-06-10 10:44 ` Sergei Shtylyov 2016-06-10 10:54 ` Roger Quadros 2016-06-10 10:54 ` Roger Quadros 2016-06-10 11:02 ` Felipe Balbi 2016-06-10 11:02 ` Felipe Balbi 2016-06-08 9:03 ` [PATCH v9 09/14] usb: of: add an API to get OTG device from USB controller node Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 10/14] usb: otg: add hcd companion support Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 11/14] usb: otg: use dev_dbg() instead of VDBG() Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 15:10 ` Joe Perches 2016-06-08 15:10 ` Joe Perches 2016-06-09 7:25 ` Roger Quadros 2016-06-09 7:25 ` Roger Quadros 2016-06-09 7:55 ` Roger Quadros [this message] 2016-06-09 7:55 ` [PATCH v10 " Roger Quadros 2016-06-09 15:43 ` Joe Perches 2016-06-09 15:43 ` Joe Perches 2016-06-10 7:05 ` Roger Quadros 2016-06-10 7:05 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 12/14] usb: hcd: Adapt to OTG core Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-08 11:42 ` Sergei Shtylyov 2016-06-08 12:06 ` Roger Quadros 2016-06-08 12:06 ` Roger Quadros 2016-06-08 12:11 ` Sergei Shtylyov 2016-06-09 7:27 ` Roger Quadros 2016-06-09 7:27 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 13/14] usb: gadget: udc: adapt " Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-09 10:49 ` Yoshihiro Shimoda 2016-06-09 10:49 ` Yoshihiro Shimoda 2016-06-10 7:06 ` Roger Quadros 2016-06-10 7:06 ` Roger Quadros 2016-06-08 9:03 ` [PATCH v9 14/14] usb: host: xhci-plat: Add otg device to platform data Roger Quadros 2016-06-08 9:03 ` Roger Quadros 2016-06-09 5:27 ` [PATCH v9 00/14] USB OTG/dual-role framework Peter Chen 2016-06-09 5:27 ` Peter Chen 2016-06-09 7:30 ` Roger Quadros 2016-06-09 7:30 ` Roger Quadros 2016-06-09 10:13 ` Yoshihiro Shimoda 2016-06-09 10:13 ` Yoshihiro Shimoda
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=575920D9.7080905@ti.com \ --to=rogerq@ti.com \ --cc=Joao.Pinto@synopsys.com \ --cc=b-liu@ti.com \ --cc=balbi@kernel.org \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=grygorii.strashko@ti.com \ --cc=joe@perches.com \ --cc=jun.li@freescale.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@linux.intel.com \ --cc=nsekhar@ti.com \ --cc=peter.chen@freescale.com \ --cc=robh@kernel.org \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=tony@atomide.com \ --cc=yoshihiro.shimoda.uh@renesas.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.