* [PATCH] bcache: Remove deprecated create_workqueue
@ 2016-06-07 20:27 Bhaktipriya Shridhar
2016-06-11 22:52 ` Tejun Heo
0 siblings, 1 reply; 4+ messages in thread
From: Bhaktipriya Shridhar @ 2016-06-07 20:27 UTC (permalink / raw)
To: Kent Overstreet, Shaohua Li, Jens Axboe, Eric Wheeler, Zheng Liu,
Hannes Reinecke, Jeff Moyer, Pekka Enberg, Al Viro
Cc: Tejun Heo, linux-bcache, linux-raid, linux-kernel
alloc_workqueue replaces deprecated create_workqueue().
Dedicated workqueues have been used since bcache_wq and moving_gc_wq
are workqueues for writes and are being used on a memory reclaim path.
WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.
Since there are only a fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/md/bcache/super.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index f5dbb4e..055c869 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1518,7 +1518,8 @@ struct cache_set *bch_cache_set_alloc(struct cache_sb *sb)
!(c->fill_iter = mempool_create_kmalloc_pool(1, iter_size)) ||
!(c->bio_split = bioset_create(4, offsetof(struct bbio, bio))) ||
!(c->uuids = alloc_bucket_pages(GFP_KERNEL, c)) ||
- !(c->moving_gc_wq = create_workqueue("bcache_gc")) ||
+ !(c->moving_gc_wq = alloc_workqueue("bcache_gc",
+ WQ_MEM_RECLAIM, 0)) ||
bch_journal_alloc(c) ||
bch_btree_cache_alloc(c) ||
bch_open_buckets_alloc(c) ||
@@ -2097,7 +2098,7 @@ static int __init bcache_init(void)
return bcache_major;
}
- if (!(bcache_wq = create_workqueue("bcache")) ||
+ if (!(bcache_wq = alloc_workqueue("bcache", WQ_MEM_RECLAIM, 0)) ||
!(bcache_kobj = kobject_create_and_add("bcache", fs_kobj)) ||
sysfs_create_files(bcache_kobj, files) ||
bch_request_init() ||
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] bcache: Remove deprecated create_workqueue
2016-06-07 20:27 [PATCH] bcache: Remove deprecated create_workqueue Bhaktipriya Shridhar
@ 2016-06-11 22:52 ` Tejun Heo
2016-06-12 2:03 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2016-06-11 22:52 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Kent Overstreet, Shaohua Li, Jens Axboe, Eric Wheeler, Zheng Liu,
Hannes Reinecke, Jeff Moyer, Pekka Enberg, Al Viro, linux-bcache,
linux-raid, linux-kernel
On Wed, Jun 08, 2016 at 01:57:19AM +0530, Bhaktipriya Shridhar wrote:
> alloc_workqueue replaces deprecated create_workqueue().
>
> Dedicated workqueues have been used since bcache_wq and moving_gc_wq
> are workqueues for writes and are being used on a memory reclaim path.
> WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> pressure.
> Since there are only a fixed number of work items, explicit concurrency
> limit is unnecessary here.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bcache: Remove deprecated create_workqueue
2016-06-11 22:52 ` Tejun Heo
@ 2016-06-12 2:03 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2016-06-12 2:03 UTC (permalink / raw)
To: Tejun Heo, Bhaktipriya Shridhar
Cc: Kent Overstreet, Shaohua Li, Eric Wheeler, Zheng Liu,
Hannes Reinecke, Jeff Moyer, Pekka Enberg, Al Viro, linux-bcache,
linux-raid, linux-kernel
On 06/11/2016 04:52 PM, Tejun Heo wrote:
> On Wed, Jun 08, 2016 at 01:57:19AM +0530, Bhaktipriya Shridhar wrote:
>> alloc_workqueue replaces deprecated create_workqueue().
>>
>> Dedicated workqueues have been used since bcache_wq and moving_gc_wq
>> are workqueues for writes and are being used on a memory reclaim path.
>> WQ_MEM_RECLAIM has been set to ensure forward progress under memory
>> pressure.
>> Since there are only a fixed number of work items, explicit concurrency
>> limit is unnecessary here.
>>
>> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
>
> Acked-by: Tejun Heo <tj@kernel.org>
Added to 4.8, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bcache: Remove deprecated create_workqueue
@ 2016-06-12 2:03 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2016-06-12 2:03 UTC (permalink / raw)
To: Tejun Heo, Bhaktipriya Shridhar
Cc: Kent Overstreet, Shaohua Li, Eric Wheeler, Zheng Liu,
Hannes Reinecke, Jeff Moyer, Pekka Enberg, Al Viro, linux-bcache,
linux-raid, linux-kernel
On 06/11/2016 04:52 PM, Tejun Heo wrote:
> On Wed, Jun 08, 2016 at 01:57:19AM +0530, Bhaktipriya Shridhar wrote:
>> alloc_workqueue replaces deprecated create_workqueue().
>>
>> Dedicated workqueues have been used since bcache_wq and moving_gc_wq
>> are workqueues for writes and are being used on a memory reclaim path.
>> WQ_MEM_RECLAIM has been set to ensure forward progress under memory
>> pressure.
>> Since there are only a fixed number of work items, explicit concurrency
>> limit is unnecessary here.
>>
>> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
>
> Acked-by: Tejun Heo <tj@kernel.org>
Added to 4.8, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-12 2:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-07 20:27 [PATCH] bcache: Remove deprecated create_workqueue Bhaktipriya Shridhar
2016-06-11 22:52 ` Tejun Heo
2016-06-12 2:03 ` Jens Axboe
2016-06-12 2:03 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.