From: Neil Armstrong <narmstrong@baylibre.com>
To: Kevin Hilman <khilman@baylibre.com>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node
Date: Tue, 14 Jun 2016 06:59:16 +0200 [thread overview]
Message-ID: <575F8F24.5000803@baylibre.com> (raw)
In-Reply-To: <m2ziqoviz0.fsf@baylibre.com>
On 06/14/2016 12:09 AM, Kevin Hilman wrote:
> Hi Neil,
>
> Neil Armstrong <narmstrong@baylibre.com> writes:
>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> index 832815d..8353621 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> @@ -167,6 +167,11 @@
>> };
>> };
>>
>> + rng {
>> + compatible = "amlogic,meson-rng";
>> + reg = <0x0 0xc8834000 0x0 0x4>;
>> + };
>
> This should be under the periphs bus, with an offset of 0x0 instead of
> at the top level.
>
> See the for-next branch in the linux-amlogic tree[1] which has separate
> busses for periphs and hiu.
Yes, It was introduced lately.
Herbert,
I'll repost this patch separately to arm-soc directly rebased on [1].
Thanks,
Neil
> Kevin
>
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git
>
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node
Date: Tue, 14 Jun 2016 06:59:16 +0200 [thread overview]
Message-ID: <575F8F24.5000803@baylibre.com> (raw)
In-Reply-To: <m2ziqoviz0.fsf@baylibre.com>
On 06/14/2016 12:09 AM, Kevin Hilman wrote:
> Hi Neil,
>
> Neil Armstrong <narmstrong@baylibre.com> writes:
>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> index 832815d..8353621 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> @@ -167,6 +167,11 @@
>> };
>> };
>>
>> + rng {
>> + compatible = "amlogic,meson-rng";
>> + reg = <0x0 0xc8834000 0x0 0x4>;
>> + };
>
> This should be under the periphs bus, with an offset of 0x0 instead of
> at the top level.
>
> See the for-next branch in the linux-amlogic tree[1] which has separate
> busses for periphs and hiu.
Yes, It was introduced lately.
Herbert,
I'll repost this patch separately to arm-soc directly rebased on [1].
Thanks,
Neil
> Kevin
>
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git
>
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node
Date: Tue, 14 Jun 2016 06:59:16 +0200 [thread overview]
Message-ID: <575F8F24.5000803@baylibre.com> (raw)
In-Reply-To: <m2ziqoviz0.fsf@baylibre.com>
On 06/14/2016 12:09 AM, Kevin Hilman wrote:
> Hi Neil,
>
> Neil Armstrong <narmstrong@baylibre.com> writes:
>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> index 832815d..8353621 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> @@ -167,6 +167,11 @@
>> };
>> };
>>
>> + rng {
>> + compatible = "amlogic,meson-rng";
>> + reg = <0x0 0xc8834000 0x0 0x4>;
>> + };
>
> This should be under the periphs bus, with an offset of 0x0 instead of
> at the top level.
>
> See the for-next branch in the linux-amlogic tree[1] which has separate
> busses for periphs and hiu.
Yes, It was introduced lately.
Herbert,
I'll repost this patch separately to arm-soc directly rebased on [1].
Thanks,
Neil
> Kevin
>
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git
>
next prev parent reply other threads:[~2016-06-14 4:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 8:21 [PATCH v2 0/3] hw_random: Add Amlogic Meson SoCs Random Generator driver Neil Armstrong
2016-06-10 8:21 ` Neil Armstrong
2016-06-10 8:21 ` Neil Armstrong
2016-06-10 8:21 ` [PATCH v2 1/3] char: hw_random: Add Amlogic Meson Hardware Random Generator Neil Armstrong
2016-06-10 8:21 ` Neil Armstrong
2016-06-10 8:21 ` Neil Armstrong
2016-06-10 8:21 ` [PATCH v2 2/3] dt-bindings: hwrng: Add Amlogic Meson Hardware Random Generator bindings Neil Armstrong
2016-06-10 8:21 ` Neil Armstrong
2016-06-10 8:21 ` Neil Armstrong
2016-06-10 8:21 ` Neil Armstrong
2016-06-10 8:21 ` [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node Neil Armstrong
2016-06-10 8:21 ` Neil Armstrong
2016-06-10 8:21 ` Neil Armstrong
2016-06-13 22:09 ` Kevin Hilman
2016-06-13 22:09 ` Kevin Hilman
2016-06-13 22:09 ` Kevin Hilman
2016-06-14 4:59 ` Neil Armstrong [this message]
2016-06-14 4:59 ` Neil Armstrong
2016-06-14 4:59 ` Neil Armstrong
2016-06-13 12:31 ` [PATCH v2 0/3] hw_random: Add Amlogic Meson SoCs Random Generator driver Herbert Xu
2016-06-13 12:31 ` Herbert Xu
2016-06-13 12:31 ` Herbert Xu
2016-06-13 22:10 ` Kevin Hilman
2016-06-13 22:10 ` Kevin Hilman
2016-06-13 22:10 ` Kevin Hilman
2016-06-14 10:33 ` Herbert Xu
2016-06-14 10:33 ` Herbert Xu
2016-06-14 10:33 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575F8F24.5000803@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.