* + mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask.patch added to -mm tree
@ 2016-06-10 21:22 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2016-06-10 21:22 UTC (permalink / raw)
To: mgorman, mw, stable, vbabka, mm-commits
The patch titled
Subject: mm, sl[au]b: add __GFP_ATOMIC to the GFP reclaim mask
has been added to the -mm tree. Its filename is
mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Mel Gorman <mgorman@techsingularity.net>
Subject: mm, sl[au]b: add __GFP_ATOMIC to the GFP reclaim mask
Commit d0164adc89f6 ("mm, page_alloc: distinguish between being unable to
sleep, unwilling to sleep and avoiding waking kswapd") modified __GFP_WAIT
to explicitly identify the difference between atomic callers and those
that were unwilling to sleep. Later the definition was removed entirely.
The GFP_RECLAIM_MASK is the set of flags that affect watermark checking
and reclaim behaviour but __GFP_ATOMIC was never added. Without it, atomic
users of the slab allocator strip the __GFP_ATOMIC flag and cannot access
the page allocator atomic reserves. This patch addresses the problem.
The user-visible impact depends on the workload but potentially atomic
allocations unnecessarily fail without this path.
Link: http://lkml.kernel.org/r/20160610093832.GK2527@techsingularity.net
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Reported-by: Marcin Wojtas <mw@semihalf.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: <stable@vger.kernel.org> [4.4+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/internal.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN mm/internal.h~mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask mm/internal.h
--- a/mm/internal.h~mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask
+++ a/mm/internal.h
@@ -24,7 +24,8 @@
*/
#define GFP_RECLAIM_MASK (__GFP_RECLAIM|__GFP_HIGH|__GFP_IO|__GFP_FS|\
__GFP_NOWARN|__GFP_REPEAT|__GFP_NOFAIL|\
- __GFP_NORETRY|__GFP_MEMALLOC|__GFP_NOMEMALLOC)
+ __GFP_NORETRY|__GFP_MEMALLOC|__GFP_NOMEMALLOC|\
+ __GFP_ATOMIC)
/* The GFP flags allowed during early boot */
#define GFP_BOOT_MASK (__GFP_BITS_MASK & ~(__GFP_RECLAIM|__GFP_IO|__GFP_FS))
_
Patches currently in -mm which might be from mgorman@techsingularity.net are
mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
* + mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask.patch added to -mm tree
@ 2016-06-10 21:22 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2016-06-10 21:22 UTC (permalink / raw)
To: mgorman, mw, stable, vbabka, mm-commits
The patch titled
Subject: mm, sl[au]b: add __GFP_ATOMIC to the GFP reclaim mask
has been added to the -mm tree. Its filename is
mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Mel Gorman <mgorman@techsingularity.net>
Subject: mm, sl[au]b: add __GFP_ATOMIC to the GFP reclaim mask
Commit d0164adc89f6 ("mm, page_alloc: distinguish between being unable to
sleep, unwilling to sleep and avoiding waking kswapd") modified __GFP_WAIT
to explicitly identify the difference between atomic callers and those
that were unwilling to sleep. Later the definition was removed entirely.
The GFP_RECLAIM_MASK is the set of flags that affect watermark checking
and reclaim behaviour but __GFP_ATOMIC was never added. Without it, atomic
users of the slab allocator strip the __GFP_ATOMIC flag and cannot access
the page allocator atomic reserves. This patch addresses the problem.
The user-visible impact depends on the workload but potentially atomic
allocations unnecessarily fail without this path.
Link: http://lkml.kernel.org/r/20160610093832.GK2527@techsingularity.net
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Reported-by: Marcin Wojtas <mw@semihalf.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: <stable@vger.kernel.org> [4.4+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/internal.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN mm/internal.h~mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask mm/internal.h
--- a/mm/internal.h~mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask
+++ a/mm/internal.h
@@ -24,7 +24,8 @@
*/
#define GFP_RECLAIM_MASK (__GFP_RECLAIM|__GFP_HIGH|__GFP_IO|__GFP_FS|\
__GFP_NOWARN|__GFP_REPEAT|__GFP_NOFAIL|\
- __GFP_NORETRY|__GFP_MEMALLOC|__GFP_NOMEMALLOC)
+ __GFP_NORETRY|__GFP_MEMALLOC|__GFP_NOMEMALLOC|\
+ __GFP_ATOMIC)
/* The GFP flags allowed during early boot */
#define GFP_BOOT_MASK (__GFP_BITS_MASK & ~(__GFP_RECLAIM|__GFP_IO|__GFP_FS))
_
Patches currently in -mm which might be from mgorman@techsingularity.net are
mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-10 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-10 21:22 + mm-slaub-add-__gfp_atomic-to-the-gfp-reclaim-mask.patch added to -mm tree akpm
-- strict thread matches above, loose matches on Subject: below --
2016-06-10 21:22 akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.