* [PATCH] travis.yml: Use the libfdt from the distro instead of the submodule
@ 2023-01-19 13:55 Thomas Huth
2023-01-19 15:03 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2023-01-19 13:55 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Philippe Mathieu-Daudé
No need to compile-test third party submodules over and over again if
we can simply use the pre-build library from the distribution instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
.travis.yml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/.travis.yml b/.travis.yml
index fb3baabca9..e24c99fdb9 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -128,6 +128,7 @@ jobs:
- libbrlapi-dev
- libcacard-dev
- libcap-ng-dev
+ - libfdt-dev
- libgcrypt20-dev
- libgnutls28-dev
- libgtk-3-dev
@@ -162,6 +163,7 @@ jobs:
- libbrlapi-dev
- libcacard-dev
- libcap-ng-dev
+ - libfdt-dev
- libgcrypt20-dev
- libgnutls28-dev
- libgtk-3-dev
@@ -195,6 +197,7 @@ jobs:
- libbrlapi-dev
- libcacard-dev
- libcap-ng-dev
+ - libfdt-dev
- libgcrypt20-dev
- libgnutls28-dev
- libgtk-3-dev
@@ -237,6 +240,7 @@ jobs:
- libattr1-dev
- libcacard-dev
- libcap-ng-dev
+ - libfdt-dev
- libgnutls28-dev
- libiscsi-dev
- liblttng-ust-dev
@@ -281,6 +285,7 @@ jobs:
- libbrlapi-dev
- libcacard-dev
- libcap-ng-dev
+ - libfdt-dev
- libgcrypt20-dev
- libgnutls28-dev
- libgtk-3-dev
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] travis.yml: Use the libfdt from the distro instead of the submodule
2023-01-19 13:55 [PATCH] travis.yml: Use the libfdt from the distro instead of the submodule Thomas Huth
@ 2023-01-19 15:03 ` Philippe Mathieu-Daudé
2023-01-19 16:04 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-01-19 15:03 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: Alex Bennée, Paolo Bonzini
On 19/1/23 14:55, Thomas Huth wrote:
> No need to compile-test third party submodules over and over again if
> we can simply use the pre-build library from the distribution instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .travis.yml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index fb3baabca9..e24c99fdb9 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -128,6 +128,7 @@ jobs:
> - libbrlapi-dev
> - libcacard-dev
> - libcap-ng-dev
> + - libfdt-dev
> - libgcrypt20-dev
> - libgnutls28-dev
> - libgtk-3-dev
Could we remove cloning the submodule in the 'enabled' case now?
See ./configure:
1518 case "$fdt" in
1519 auto | enabled | internal)
1520 # Simpler to always update submodule, even if not needed.
1521 git_submodules="${git_submodules} dtc"
1522 ;;
1523 esac
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] travis.yml: Use the libfdt from the distro instead of the submodule
2023-01-19 15:03 ` Philippe Mathieu-Daudé
@ 2023-01-19 16:04 ` Thomas Huth
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2023-01-19 16:04 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Alex Bennée, Paolo Bonzini
On 19/01/2023 16.03, Philippe Mathieu-Daudé wrote:
> On 19/1/23 14:55, Thomas Huth wrote:
>> No need to compile-test third party submodules over and over again if
>> we can simply use the pre-build library from the distribution instead.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> .travis.yml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index fb3baabca9..e24c99fdb9 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -128,6 +128,7 @@ jobs:
>> - libbrlapi-dev
>> - libcacard-dev
>> - libcap-ng-dev
>> + - libfdt-dev
>> - libgcrypt20-dev
>> - libgnutls28-dev
>> - libgtk-3-dev
>
> Could we remove cloning the submodule in the 'enabled' case now?
> See ./configure:
>
> 1518 case "$fdt" in
> 1519 auto | enabled | internal)
> 1520 # Simpler to always update submodule, even if not needed.
> 1521 git_submodules="${git_submodules} dtc"
> 1522 ;;
> 1523 esac
I think currently "enabled" still means either "internal" or "system" ? ...
so since we cannot know here yet whether there is a usable libfdt installed
available or not, we cannot remove this yet.
If we want to avoid the unnecessary git cloning, we have to explicitly use
--enable-fdt=system ... which would make sense here, indeed. I'll send a v2
with that added.
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-19 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-19 13:55 [PATCH] travis.yml: Use the libfdt from the distro instead of the submodule Thomas Huth
2023-01-19 15:03 ` Philippe Mathieu-Daudé
2023-01-19 16:04 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.