From: YOSHIFUJI Hideaki <hideaki.yoshifuji-GmhWrQMWH5w7YuNMryXyOw@public.gmane.org> To: Alexander Aring <aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, linux-wpan-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: hideaki.yoshifuji-GmhWrQMWH5w7YuNMryXyOw@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org, jukka.rissanen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, hannes-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org, stefan-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, mcr-SWp7JaYWvAQV+D8aMU/kSg@public.gmane.org, werner-SEdMjqphH88wryQfseakQg@public.gmane.org, linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S . Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>, Alexey Kuznetsov <kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org>, James Morris <jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org>, Hideaki YOSHIFUJI <yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org>, Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org> Subject: Re: [PATCHv3 net-next 05/12] ndisc: add __ndisc_opt_addr_data function Date: Wed, 15 Jun 2016 20:07:49 +0900 [thread overview] Message-ID: <57613705.1040101@miraclelinux.com> (raw) In-Reply-To: <20160614115239.17788-6-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Alexander Aring wrote: > This patch adds __ndisc_opt_addr_data as low-level function for > ndisc_opt_addr_data which doesn't depend on net_device parameter. > > Cc: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> > Cc: Alexey Kuznetsov <kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org> > Cc: James Morris <jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org> > Cc: Hideaki YOSHIFUJI <yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org> > Cc: Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org> > Signed-off-by: Alexander Aring <aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Acked-by: YOSHIFUJI Hideaki <yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org> > --- > include/net/ndisc.h | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/include/net/ndisc.h b/include/net/ndisc.h > index 4cee826..c8962ad 100644 > --- a/include/net/ndisc.h > +++ b/include/net/ndisc.h > @@ -138,17 +138,23 @@ static inline int ndisc_opt_addr_space(struct net_device *dev) > ndisc_addr_option_pad(dev->type)); > } > > -static inline u8 *ndisc_opt_addr_data(struct nd_opt_hdr *p, > - struct net_device *dev) > +static inline u8 *__ndisc_opt_addr_data(struct nd_opt_hdr *p, > + unsigned char addr_len, int prepad) > { > u8 *lladdr = (u8 *)(p + 1); > int lladdrlen = p->nd_opt_len << 3; > - int prepad = ndisc_addr_option_pad(dev->type); > - if (lladdrlen != ndisc_opt_addr_space(dev)) > + if (lladdrlen != __ndisc_opt_addr_space(addr_len, prepad)) > return NULL; > return lladdr + prepad; > } > > +static inline u8 *ndisc_opt_addr_data(struct nd_opt_hdr *p, > + struct net_device *dev) > +{ > + return __ndisc_opt_addr_data(p, dev->addr_len, > + ndisc_addr_option_pad(dev->type)); > +} > + > static inline u32 ndisc_hashfn(const void *pkey, const struct net_device *dev, __u32 *hash_rnd) > { > const u32 *p32 = pkey; > -- Hideaki Yoshifuji <hideaki.yoshifuji-GmhWrQMWH5w7YuNMryXyOw@public.gmane.org> Technical Division, MIRACLE LINUX CORPORATION
WARNING: multiple messages have this Message-ID (diff)
From: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com> To: Alexander Aring <aar@pengutronix.de>, linux-wpan@vger.kernel.org Cc: hideaki.yoshifuji@miraclelinux.com, kernel@pengutronix.de, marcel@holtmann.org, jukka.rissanen@linux.intel.com, hannes@stressinduktion.org, stefan@osg.samsung.com, mcr@sandelman.ca, werner@almesberger.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>, James Morris <jmorris@namei.org>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, Patrick McHardy <kaber@trash.net> Subject: Re: [PATCHv3 net-next 05/12] ndisc: add __ndisc_opt_addr_data function Date: Wed, 15 Jun 2016 20:07:49 +0900 [thread overview] Message-ID: <57613705.1040101@miraclelinux.com> (raw) In-Reply-To: <20160614115239.17788-6-aar@pengutronix.de> Alexander Aring wrote: > This patch adds __ndisc_opt_addr_data as low-level function for > ndisc_opt_addr_data which doesn't depend on net_device parameter. > > Cc: David S. Miller <davem@davemloft.net> > Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> > Cc: James Morris <jmorris@namei.org> > Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org> > Cc: Patrick McHardy <kaber@trash.net> > Signed-off-by: Alexander Aring <aar@pengutronix.de> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> > --- > include/net/ndisc.h | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/include/net/ndisc.h b/include/net/ndisc.h > index 4cee826..c8962ad 100644 > --- a/include/net/ndisc.h > +++ b/include/net/ndisc.h > @@ -138,17 +138,23 @@ static inline int ndisc_opt_addr_space(struct net_device *dev) > ndisc_addr_option_pad(dev->type)); > } > > -static inline u8 *ndisc_opt_addr_data(struct nd_opt_hdr *p, > - struct net_device *dev) > +static inline u8 *__ndisc_opt_addr_data(struct nd_opt_hdr *p, > + unsigned char addr_len, int prepad) > { > u8 *lladdr = (u8 *)(p + 1); > int lladdrlen = p->nd_opt_len << 3; > - int prepad = ndisc_addr_option_pad(dev->type); > - if (lladdrlen != ndisc_opt_addr_space(dev)) > + if (lladdrlen != __ndisc_opt_addr_space(addr_len, prepad)) > return NULL; > return lladdr + prepad; > } > > +static inline u8 *ndisc_opt_addr_data(struct nd_opt_hdr *p, > + struct net_device *dev) > +{ > + return __ndisc_opt_addr_data(p, dev->addr_len, > + ndisc_addr_option_pad(dev->type)); > +} > + > static inline u32 ndisc_hashfn(const void *pkey, const struct net_device *dev, __u32 *hash_rnd) > { > const u32 *p32 = pkey; > -- Hideaki Yoshifuji <hideaki.yoshifuji@miraclelinux.com> Technical Division, MIRACLE LINUX CORPORATION
next prev parent reply other threads:[~2016-06-15 11:07 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-14 11:52 [PATCHv3 net-next 00/12] 6lowpan: introduce 6lowpan-nd Alexander Aring 2016-06-14 11:52 ` Alexander Aring [not found] ` <20160614115239.17788-1-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-06-14 11:52 ` [PATCHv3 net-next 01/12] 6lowpan: add private neighbour data Alexander Aring 2016-06-14 11:52 ` Alexander Aring [not found] ` <20160614115239.17788-2-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-06-15 11:05 ` YOSHIFUJI Hideaki 2016-06-15 11:05 ` YOSHIFUJI Hideaki 2016-06-14 11:52 ` [PATCHv3 net-next 03/12] 6lowpan: remove ipv6 module request Alexander Aring 2016-06-14 11:52 ` Alexander Aring 2016-06-14 11:52 ` [PATCHv3 net-next 05/12] ndisc: add __ndisc_opt_addr_data function Alexander Aring 2016-06-14 11:52 ` Alexander Aring [not found] ` <20160614115239.17788-6-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-06-15 11:07 ` YOSHIFUJI Hideaki [this message] 2016-06-15 11:07 ` YOSHIFUJI Hideaki 2016-06-15 15:11 ` Stefan Schmidt 2016-06-14 11:52 ` [PATCHv3 net-next 10/12] 6lowpan: introduce 6lowpan-nd Alexander Aring 2016-06-14 11:52 ` Alexander Aring 2016-06-15 11:12 ` YOSHIFUJI Hideaki 2016-06-14 11:52 ` [PATCHv3 net-next 11/12] 6lowpan: add support for getting short address Alexander Aring 2016-06-14 11:52 ` Alexander Aring 2016-06-15 11:03 ` [PATCHv3 net-next 00/12] 6lowpan: introduce 6lowpan-nd YOSHIFUJI Hideaki 2016-06-15 11:03 ` YOSHIFUJI Hideaki 2016-06-14 11:52 ` [PATCHv3 net-next 02/12] 6lowpan: add 802.15.4 short addr slaac Alexander Aring 2016-06-14 11:52 ` [PATCHv3 net-next 04/12] ndisc: add __ndisc_opt_addr_space function Alexander Aring 2016-06-15 11:07 ` YOSHIFUJI Hideaki [not found] ` <20160614115239.17788-5-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-06-15 15:09 ` Stefan Schmidt 2016-06-15 15:09 ` Stefan Schmidt 2016-06-14 11:52 ` [PATCHv3 net-next 06/12] ndisc: add __ndisc_fill_addr_option function Alexander Aring 2016-06-15 11:08 ` YOSHIFUJI Hideaki 2016-06-15 15:13 ` Stefan Schmidt 2016-06-14 11:52 ` [PATCHv3 net-next 07/12] addrconf: put prefix address add in an own function Alexander Aring [not found] ` <20160614115239.17788-8-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-06-15 11:09 ` YOSHIFUJI Hideaki 2016-06-15 11:09 ` YOSHIFUJI Hideaki 2016-06-14 11:52 ` [PATCHv3 net-next 08/12] ipv6: introduce neighbour discovery ops Alexander Aring [not found] ` <20160614115239.17788-9-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-06-15 11:10 ` YOSHIFUJI Hideaki/吉藤英明 2016-06-15 11:10 ` YOSHIFUJI Hideaki/吉藤英明 2016-06-14 11:52 ` [PATCHv3 net-next 09/12] ipv6: export several functions Alexander Aring 2016-06-15 11:11 ` YOSHIFUJI Hideaki 2016-06-15 15:18 ` Stefan Schmidt 2016-06-14 11:52 ` [PATCHv3 net-next 12/12] 6lowpan: add support for 802.15.4 short addr handling Alexander Aring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=57613705.1040101@miraclelinux.com \ --to=hideaki.yoshifuji-gmhwrqmwh5w7yunmryxyow@public.gmane.org \ --cc=aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \ --cc=hannes-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org \ --cc=jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org \ --cc=jukka.rissanen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ --cc=kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org \ --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org \ --cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-wpan-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \ --cc=mcr-SWp7JaYWvAQV+D8aMU/kSg@public.gmane.org \ --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=stefan-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \ --cc=werner-SEdMjqphH88wryQfseakQg@public.gmane.org \ --cc=yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.