From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
"David S. Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
ldv-project@linuxtesting.org
Subject: Re: [BUG] act_ife: sleeping functions called in atomic context
Date: Fri, 17 Jun 2016 07:07:34 -0400 [thread overview]
Message-ID: <5763D9F6.6020305@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpXokKbXS8TiOgYqEZgLMY-01X8ebJQ-b6VrnM2x6=GFhg@mail.gmail.com>
On 16-06-17 01:38 AM, Cong Wang wrote:
> On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>
>> I think we can just remove that tcf_lock, I am testing a patch now.
>
> Please try the attached patch, I will do more tests tomorrow.
>
> Thanks!
>
Cong, What tree are you using? I dont see the time aggregation patches
that I sent (and Dave took in) in your changes.
Comments:
Is GFP_ATOMIC really necessary? Thats user->kernel interface. GFP_KERNEL
should be sufficient.
Also, it would be nice to kill the lock - but this feels like two
patches in one. 1) to fix the alloc not to be under the lock 2) to
kill said lock. Maybe split it as such for easier review.
I am using this action extensively so will be happy to test.
I think my patch is a good beginning to #1 - if you fix the forgotten
unlock and ensure we lock around updating ife fields when it exists
already (you said it in your earlier email and I thought about
that afterwards).
cheers,
jamal
next prev parent reply other threads:[~2016-06-17 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 20:50 [BUG] act_ife: sleeping functions called in atomic context Alexey Khoroshilov
2016-06-16 21:43 ` Cong Wang
2016-06-17 0:38 ` Jamal Hadi Salim
2016-06-17 2:14 ` Cong Wang
2016-06-17 5:38 ` Cong Wang
2016-06-17 11:05 ` Alexey Khoroshilov
2016-06-17 17:16 ` Cong Wang
2016-06-17 11:07 ` Jamal Hadi Salim [this message]
2016-06-17 17:31 ` Cong Wang
2016-06-18 14:38 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5763D9F6.6020305@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.