From: Cong Wang <xiyou.wangcong@gmail.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
"David S. Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
ldv-project@linuxtesting.org
Subject: Re: [BUG] act_ife: sleeping functions called in atomic context
Date: Fri, 17 Jun 2016 10:16:44 -0700 [thread overview]
Message-ID: <CAM_iQpUV1OaHCNkXWwGpkAPkSMzk5Rdw0ptijt4QFk9xa0FkxQ@mail.gmail.com> (raw)
In-Reply-To: <5763D970.3030504@ispras.ru>
On Fri, Jun 17, 2016 at 4:05 AM, Alexey Khoroshilov
<khoroshilov@ispras.ru> wrote:
> On 17.06.2016 08:38, Cong Wang wrote:
>> On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>>
>>> I think we can just remove that tcf_lock, I am testing a patch now.
>>
>> Please try the attached patch, I will do more tests tomorrow.
>>
>> Thanks!
>>
>
> Looks good with two notes:
> 1. add_metainfo() still contains
> ret = ops->alloc(mi, metaval);
> that allocates memory with GFP_KERNEL.
> So, I would add gfpflag argument to alloc() operation.
I thought about this too, but we just allocate 32+ bytes here,
not sure if it is really worth to pass a gfp flag.
>
> 2. It makes sense to mention ife_mod_lock in the comment before
> add_metainfo(), because ife_mod_lock is the reason to use GFP_ATOMIC there.
Don't worry, it is in a separated patch, I will explain this
in the changelog. (I sent a combined patch just for review/tests.)
Thanks!
next prev parent reply other threads:[~2016-06-17 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 20:50 [BUG] act_ife: sleeping functions called in atomic context Alexey Khoroshilov
2016-06-16 21:43 ` Cong Wang
2016-06-17 0:38 ` Jamal Hadi Salim
2016-06-17 2:14 ` Cong Wang
2016-06-17 5:38 ` Cong Wang
2016-06-17 11:05 ` Alexey Khoroshilov
2016-06-17 17:16 ` Cong Wang [this message]
2016-06-17 11:07 ` Jamal Hadi Salim
2016-06-17 17:31 ` Cong Wang
2016-06-18 14:38 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpUV1OaHCNkXWwGpkAPkSMzk5Rdw0ptijt4QFk9xa0FkxQ@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.