All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xing Zheng <zhengxing@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org, roger.chen@rock-chips.com,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	"David S. Miller" <davem@davemloft.net>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-rk: add rk322x-specific data
Date: Tue, 21 Jun 2016 20:12:50 +0800	[thread overview]
Message-ID: <57692F42.30709@rock-chips.com> (raw)
In-Reply-To: <3520853.j0ALyW964u@diego>

Hi Heiko,

On 2016年06月21日 17:43, Heiko Stübner wrote:
> devicetree names are normally expected to be real, aka no "x" as catchall. So
> I guess either just add compatibles for both the rk3228 and rk3229 which point
> to the same structure in the driver. (So driver-side can stay as it is below,
> just add a second compatible).
OK, I try to just use "rockchip,rk3228-gmac" to point to "rk322x_ops" 
which is the same structure in MAC driver,
and both rk3228 and rk3229 use it.

Thanks

-- 
- Xing Zheng

WARNING: multiple messages have this Message-ID (diff)
From: zhengxing@rock-chips.com (Xing Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: stmmac: dwmac-rk: add rk322x-specific data
Date: Tue, 21 Jun 2016 20:12:50 +0800	[thread overview]
Message-ID: <57692F42.30709@rock-chips.com> (raw)
In-Reply-To: <3520853.j0ALyW964u@diego>

Hi Heiko,

On 2016?06?21? 17:43, Heiko St?bner wrote:
> devicetree names are normally expected to be real, aka no "x" as catchall. So
> I guess either just add compatibles for both the rk3228 and rk3229 which point
> to the same structure in the driver. (So driver-side can stay as it is below,
> just add a second compatible).
OK, I try to just use "rockchip,rk3228-gmac" to point to "rk322x_ops" 
which is the same structure in MAC driver,
and both rk3228 and rk3229 use it.

Thanks

-- 
- Xing Zheng

  reply	other threads:[~2016-06-21 12:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21  7:13 [PATCH] net: stmmac: dwmac-rk: add rk322x-specific data Xing Zheng
2016-06-21  7:13 ` Xing Zheng
2016-06-21  7:13 ` Xing Zheng
2016-06-21  9:43 ` Heiko Stübner
2016-06-21  9:43   ` Heiko Stübner
2016-06-21  9:43   ` Heiko Stübner
2016-06-21 12:12   ` Xing Zheng [this message]
2016-06-21 12:12     ` Xing Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57692F42.30709@rock-chips.com \
    --to=zhengxing@rock-chips.com \
    --cc=alexandre.torgue@st.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=peppe.cavallaro@st.com \
    --cc=robh+dt@kernel.org \
    --cc=roger.chen@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.