* [PATCH] ARM: hisi: make unexported symbols static
@ 2016-06-21 12:28 Ben Dooks
2016-06-22 16:30 ` Wei Xu
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2016-06-21 12:28 UTC (permalink / raw)
To: linux-arm-kernel
The two functions hix5hd2_set_scu_boot_addr() and
hip01_set_boot_addr() are not declared or exported
outside arch/arm/mach-hisi/platsmp.c file. Avoid
the following warnings by making them static:
arch/arm/mach-hisi/platsmp.c:142:6: warning: symbol 'hip01_set_boot_addr' was not declared. Should it be static?
arch/arm/mach-hisi/platsmp.c:106:6: warning: symbol 'hix5hd2_set_scu_boot_addr' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: linux-arm-kernel at lists.infradead.org
---
arch/arm/mach-hisi/platsmp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c
index 47ed32c..e1d6764 100644
--- a/arch/arm/mach-hisi/platsmp.c
+++ b/arch/arm/mach-hisi/platsmp.c
@@ -103,7 +103,7 @@ static void __init hisi_common_smp_prepare_cpus(unsigned int max_cpus)
hisi_enable_scu_a9();
}
-void hix5hd2_set_scu_boot_addr(phys_addr_t start_addr, phys_addr_t jump_addr)
+static void hix5hd2_set_scu_boot_addr(phys_addr_t start_addr, phys_addr_t jump_addr)
{
void __iomem *virt;
@@ -139,7 +139,7 @@ static const struct smp_operations hix5hd2_smp_ops __initconst = {
#define HIP01_BOOT_ADDRESS 0x80000000
#define REG_SC_CTRL 0x000
-void hip01_set_boot_addr(phys_addr_t start_addr, phys_addr_t jump_addr)
+static void hip01_set_boot_addr(phys_addr_t start_addr, phys_addr_t jump_addr)
{
void __iomem *virt;
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: hisi: make unexported symbols static
2016-06-21 12:28 [PATCH] ARM: hisi: make unexported symbols static Ben Dooks
@ 2016-06-22 16:30 ` Wei Xu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Xu @ 2016-06-22 16:30 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ben,
On 21/06/2016 13:28, Ben Dooks wrote:
> The two functions hix5hd2_set_scu_boot_addr() and
> hip01_set_boot_addr() are not declared or exported
> outside arch/arm/mach-hisi/platsmp.c file. Avoid
> the following warnings by making them static:
>
> arch/arm/mach-hisi/platsmp.c:142:6: warning: symbol 'hip01_set_boot_addr' was not declared. Should it be static?
> arch/arm/mach-hisi/platsmp.c:106:6: warning: symbol 'hix5hd2_set_scu_boot_addr' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: linux-arm-kernel at lists.infradead.org
> ---
> arch/arm/mach-hisi/platsmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks!
Applied to the hisilicon git tree.
Best Regards,
Wei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-22 16:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-21 12:28 [PATCH] ARM: hisi: make unexported symbols static Ben Dooks
2016-06-22 16:30 ` Wei Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.