[PATCH 0/2] Add gcc version and tclibc to build summary

[PATCH 0/2] Add gcc version and tclibc to build summary

[Armin Kuster]

Since there are two gcc versions supported and any number of tcglibc,
it would be nice to know which ones are being used.
Add those to the build summary.

Build summary
TCLIBC            = "glibc"
GCC_VERSION       = "6.1"

Not sure if the gcc version bit is best practice.

Armin Kuster (2):
  build summary: add gcc version being used.
  build summary: add TCLIBC being used

 meta/classes/base.bbclass | 2 ++
 meta/conf/bitbake.conf    | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.3.5

[PATCH 1/2] build summary: add gcc version being used.

[Armin Kuster]

From: Armin Kuster <akuster@mvista.com>

Signed-off-by: Armin Kuster <akuster@mvista.com>
---
 meta/classes/base.bbclass | 2 ++
 meta/conf/bitbake.conf    | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 5d8e8d6..b90e9ce 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -195,6 +195,8 @@ def buildcfg_vars(d):
         if value is not None:
             yield '%-17s = "%s"' % (var, value)
 
+    yield '%-17s = "%s"' % ("GCC_VERSION", d.getVar("GCCVERSION", True).strip('%'))
+
 def buildcfg_neededvars(d):
     needed_vars = oe.data.typed_value("BUILDCFG_NEEDEDVARS", d)
     pesteruser = []
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 942b8b1..7132922 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -650,7 +650,7 @@ PREFERRED_PROVIDER_virtual/fakeroot-native ?= "pseudo-native"
 
 # Pre-build configuration output
 BUILDCFG_HEADER = "Build Configuration:"
-BUILDCFG_VARS = "BB_VERSION BUILD_SYS NATIVELSBSTRING TARGET_SYS MACHINE DISTRO DISTRO_VERSION TUNE_FEATURES TARGET_FPU"
+BUILDCFG_VARS = "BB_VERSION BUILD_SYS NATIVELSBSTRING TARGET_SYS MACHINE DISTRO DISTRO_VERSION TUNE_FEATURES TARGET_FPU GCC_VERSION"
 BUILDCFG_VARS[type] = "list"
 BUILDCFG_NEEDEDVARS = "TARGET_ARCH TARGET_OS"
 BUILDCFG_NEEDEDVARS[type] = "list"
-- 
2.3.5

[PATCH 2/2] build summary: add TCLIBC being used

[Armin Kuster]

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 7132922..c575f55 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -650,7 +650,7 @@ PREFERRED_PROVIDER_virtual/fakeroot-native ?= "pseudo-native"
 
 # Pre-build configuration output
 BUILDCFG_HEADER = "Build Configuration:"
-BUILDCFG_VARS = "BB_VERSION BUILD_SYS NATIVELSBSTRING TARGET_SYS MACHINE DISTRO DISTRO_VERSION TUNE_FEATURES TARGET_FPU GCC_VERSION"
+BUILDCFG_VARS = "BB_VERSION BUILD_SYS NATIVELSBSTRING TARGET_SYS MACHINE DISTRO DISTRO_VERSION TUNE_FEATURES TARGET_FPU GCC_VERSION TCLIBC"
 BUILDCFG_VARS[type] = "list"
 BUILDCFG_NEEDEDVARS = "TARGET_ARCH TARGET_OS"
 BUILDCFG_NEEDEDVARS[type] = "list"
-- 
2.3.5

Re: [PATCH 0/2] Add gcc version and tclibc to build summary

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]


> On Jun 22, 2016, at 8:29 AM, Armin Kuster <akuster808@gmail.com> wrote:
> 
> Since there are two gcc versions supported and any number of tcglibc,
> it would be nice to know which ones are being used.
> Add those to the build summary.
> 
> Build summary
> TCLIBC            = “glibc"

libc is evident from TARGET_SYS

> GCC_VERSION       = "6.1"
> 
> Not sure if the gcc version bit is best practice.
> 
> Armin Kuster (2):
>  build summary: add gcc version being used.
>  build summary: add TCLIBC being used
> 
> meta/classes/base.bbclass | 2 ++
> meta/conf/bitbake.conf    | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
> 
> --
> 2.3.5
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH 0/2] Add gcc version and tclibc to build summary

[akuster808]

On 06/22/2016 09:52 AM, Khem Raj wrote:
> 
>> On Jun 22, 2016, at 8:29 AM, Armin Kuster <akuster808@gmail.com> wrote:
>>
>> Since there are two gcc versions supported and any number of tcglibc,
>> it would be nice to know which ones are being used.
>> Add those to the build summary.
>>
>> Build summary
>> TCLIBC            = “glibc"
> 
> libc is evident from TARGET_SYS

TARGET_SYS="x86_64-oe-linux", this is not the my intent.


The intent is to track which libc is being used. I changed TCLIBC =
"musl" local.conf and now build summary show.

TCLIBC            = "musl"
GCC_VERSION       = "6.1"

Is there a clearer / better way to display this?

- armin
> 
>> GCC_VERSION       = "6.1"
>>
>> Not sure if the gcc version bit is best practice.
>>
>> Armin Kuster (2):
>>  build summary: add gcc version being used.
>>  build summary: add TCLIBC being used
>>
>> meta/classes/base.bbclass | 2 ++
>> meta/conf/bitbake.conf    | 2 +-
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> --
>> 2.3.5
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 

Re: [PATCH 0/2] Add gcc version and tclibc to build summary

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]


> On Jun 22, 2016, at 10:05 AM, akuster808 <akuster808@gmail.com> wrote:
> 
> 
> 
> On 06/22/2016 09:52 AM, Khem Raj wrote:
>> 
>>> On Jun 22, 2016, at 8:29 AM, Armin Kuster <akuster808@gmail.com> wrote:
>>> 
>>> Since there are two gcc versions supported and any number of tcglibc,
>>> it would be nice to know which ones are being used.
>>> Add those to the build summary.
>>> 
>>> Build summary
>>> TCLIBC            = “glibc"
>> 
>> libc is evident from TARGET_SYS
> 
> TARGET_SYS="x86_64-oe-linux", this is not the my intent.
> 
> 
> The intent is to track which libc is being used. I changed TCLIBC =
> "musl" local.conf and now build summary show.
> 
> TCLIBC            = "musl"
> GCC_VERSION       = "6.1"
> 
> Is there a clearer / better way to display this?

if you set TCLIBC = “musl” then TARGET_SYS should have changed to x86_64-oe-linux-musl
and TARGET_SYS is displayed with build configuration.

> 
> - armin
>> 
>>> GCC_VERSION       = "6.1"
>>> 
>>> Not sure if the gcc version bit is best practice.
>>> 
>>> Armin Kuster (2):
>>> build summary: add gcc version being used.
>>> build summary: add TCLIBC being used
>>> 
>>> meta/classes/base.bbclass | 2 ++
>>> meta/conf/bitbake.conf    | 2 +-
>>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>> 
>>> --
>>> 2.3.5
>>> 
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> 


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH 0/2] Add gcc version and tclibc to build summary

[akuster808]

On 06/22/2016 10:21 AM, Khem Raj wrote:
> 
>> On Jun 22, 2016, at 10:05 AM, akuster808 <akuster808@gmail.com> wrote:
>>
>>
>>
>> On 06/22/2016 09:52 AM, Khem Raj wrote:
>>>
>>>> On Jun 22, 2016, at 8:29 AM, Armin Kuster <akuster808@gmail.com> wrote:
>>>>
>>>> Since there are two gcc versions supported and any number of tcglibc,
>>>> it would be nice to know which ones are being used.
>>>> Add those to the build summary.
>>>>
>>>> Build summary
>>>> TCLIBC            = “glibc"
>>>
>>> libc is evident from TARGET_SYS
>>
>> TARGET_SYS="x86_64-oe-linux", this is not the my intent.
>>
>>
>> The intent is to track which libc is being used. I changed TCLIBC =
>> "musl" local.conf and now build summary show.
>>
>> TCLIBC            = "musl"
>> GCC_VERSION       = "6.1"
>>
>> Is there a clearer / better way to display this?
> 
> if you set TCLIBC = “musl” then TARGET_SYS should have changed to x86_64-oe-linux-musl
> and TARGET_SYS is displayed with build configuration.

Ah, ok. now I get it.

Would TCMODE be more useful?


is the GCC summary part OK?

- armin
> 
>>
>> - armin
>>>
>>>> GCC_VERSION       = "6.1"
>>>>
>>>> Not sure if the gcc version bit is best practice.
>>>>
>>>> Armin Kuster (2):
>>>> build summary: add gcc version being used.
>>>> build summary: add TCLIBC being used
>>>>
>>>> meta/classes/base.bbclass | 2 ++
>>>> meta/conf/bitbake.conf    | 2 +-
>>>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> --
>>>> 2.3.5
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
> 

Re: [PATCH 0/2] Add gcc version and tclibc to build summary

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2052 bytes --]

On Jun 25, 2016 8:30 AM, "akuster808" <akuster808@gmail.com> wrote:
>
>
>
> On 06/22/2016 10:21 AM, Khem Raj wrote:
> >
> >> On Jun 22, 2016, at 10:05 AM, akuster808 <akuster808@gmail.com> wrote:
> >>
> >>
> >>
> >> On 06/22/2016 09:52 AM, Khem Raj wrote:
> >>>
> >>>> On Jun 22, 2016, at 8:29 AM, Armin Kuster <akuster808@gmail.com>
wrote:
> >>>>
> >>>> Since there are two gcc versions supported and any number of tcglibc,
> >>>> it would be nice to know which ones are being used.
> >>>> Add those to the build summary.
> >>>>
> >>>> Build summary
> >>>> TCLIBC            = “glibc"
> >>>
> >>> libc is evident from TARGET_SYS
> >>
> >> TARGET_SYS="x86_64-oe-linux", this is not the my intent.
> >>
> >>
> >> The intent is to track which libc is being used. I changed TCLIBC =
> >> "musl" local.conf and now build summary show.
> >>
> >> TCLIBC            = "musl"
> >> GCC_VERSION       = "6.1"
> >>
> >> Is there a clearer / better way to display this?
> >
> > if you set TCLIBC = “musl” then TARGET_SYS should have changed to
x86_64-oe-linux-musl
> > and TARGET_SYS is displayed with build configuration.
>
> Ah, ok. now I get it.
>
> Would TCMODE be more useful?

Probably if external toolchain vendor versions are similar to internal
toolchain
>
>
> is the GCC summary part OK?

Yes

>
> - armin
> >
> >>
> >> - armin
> >>>
> >>>> GCC_VERSION       = "6.1"
> >>>>
> >>>> Not sure if the gcc version bit is best practice.
> >>>>
> >>>> Armin Kuster (2):
> >>>> build summary: add gcc version being used.
> >>>> build summary: add TCLIBC being used
> >>>>
> >>>> meta/classes/base.bbclass | 2 ++
> >>>> meta/conf/bitbake.conf    | 2 +-
> >>>> 2 files changed, 3 insertions(+), 1 deletion(-)
> >>>>
> >>>> --
> >>>> 2.3.5
> >>>>
> >>>> --
> >>>> _______________________________________________
> >>>> Openembedded-core mailing list
> >>>> Openembedded-core@lists.openembedded.org
> >>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >>>
> >

[-- Attachment #2: Type: text/html, Size: 3483 bytes --]

Re: [PATCH 1/2] build summary: add gcc version being used.

[akuster808]

I noticed this patch was being carried in mut builds and no is missing.

does that mean this is rejected?

- armin


On 06/22/2016 08:29 AM, Armin Kuster wrote:
> From: Armin Kuster <akuster@mvista.com>
> 
> Signed-off-by: Armin Kuster <akuster@mvista.com>
> ---
>  meta/classes/base.bbclass | 2 ++
>  meta/conf/bitbake.conf    | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index 5d8e8d6..b90e9ce 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -195,6 +195,8 @@ def buildcfg_vars(d):
>          if value is not None:
>              yield '%-17s = "%s"' % (var, value)
>  
> +    yield '%-17s = "%s"' % ("GCC_VERSION", d.getVar("GCCVERSION", True).strip('%'))
> +
>  def buildcfg_neededvars(d):
>      needed_vars = oe.data.typed_value("BUILDCFG_NEEDEDVARS", d)
>      pesteruser = []
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 942b8b1..7132922 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -650,7 +650,7 @@ PREFERRED_PROVIDER_virtual/fakeroot-native ?= "pseudo-native"
>  
>  # Pre-build configuration output
>  BUILDCFG_HEADER = "Build Configuration:"
> -BUILDCFG_VARS = "BB_VERSION BUILD_SYS NATIVELSBSTRING TARGET_SYS MACHINE DISTRO DISTRO_VERSION TUNE_FEATURES TARGET_FPU"
> +BUILDCFG_VARS = "BB_VERSION BUILD_SYS NATIVELSBSTRING TARGET_SYS MACHINE DISTRO DISTRO_VERSION TUNE_FEATURES TARGET_FPU GCC_VERSION"
>  BUILDCFG_VARS[type] = "list"
>  BUILDCFG_NEEDEDVARS = "TARGET_ARCH TARGET_OS"
>  BUILDCFG_NEEDEDVARS[type] = "list"
> 

Re: [PATCH 1/2] build summary: add gcc version being used.

[Richard Purdie]

On Wed, 2016-07-20 at 07:41 -0700, akuster808 wrote:
> I noticed this patch was being carried in mut builds and no is
> missing.
> 
> does that mean this is rejected?

I've been meaning to reply to this. I can certainly understand why we
might want to add things to the summary, equally, we do need to
carefully select what we display here. My own personal belief is that
we need to rationalise what is there as there are some key things
missing which are probably more important than gcc version.

With gcc version, I'm very tempted to try and get OE-Core back to a
single gcc version rather than try and put better debug messages in
place as we never intended to have multiple versions.

So I guess I'd prefer we try and rationalise things a bit and put more
thought into this...

Cheers,

Richard