From: Robin Murphy <robin.murphy@arm.com> To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Jon Masters <jcm@redhat.com>, Marc Zyngier <marc.zyngier@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>, Sinan Kaya <okaya@codeaurora.org>, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, Hanjun Guo <hanjun.guo@linaro.org>, linux-pci@vger.kernel.org, Tomasz Nowicki <tn@semihalf.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH v2 03/15] arm64: mm: change IOMMU notifier action to attach DMA ops Date: Thu, 23 Jun 2016 12:32:12 +0100 [thread overview] Message-ID: <576BC8BC.6090400@arm.com> (raw) In-Reply-To: <20160617141536.GA24840@red-moon> Hi Lorenzo, On 17/06/16 15:15, Lorenzo Pieralisi wrote: >> I think this patch makes sense even independent of the rest of the >> series, one nit inline notwithstanding. > > Thanks. Yes I added it to this series since it is not strictly > necessary (ie it does not fix anything) in the mainline, but > it *is* necessary for this whole series to function when we > boot through ACPI. > > I will send it out in a separate patch and fold changes you > request below, it would be good to have some coverage for > it before merging it. Having considered it a bit more, triggering on BIND_DRIVER also means the silly "process the whole list every time" behaviour should go away. There's little point in trying to configure a device's ops before we know they're actually needed, and once a driver has bound it's too late to change anything anyway. What do you think of squashing in something like the below? Robin. ----->8----- diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index 7d3fa9ae8a11..02484dc3f369 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -854,10 +854,11 @@ static int __iommu_attach_notifier(struct notifier_block *nb, mutex_lock(&iommu_dma_notifier_lock); list_for_each_entry_safe(master, tmp, &iommu_dma_masters, list) { - if (do_iommu_attach(master->dev, master->ops, - master->dma_base, master->size)) { + if (data == master->dev && do_iommu_attach(master->dev, + master->ops, master->dma_base, master->size)) { list_del(&master->list); kfree(master); + break; } } mutex_unlock(&iommu_dma_notifier_lock);
WARNING: multiple messages have this Message-ID (diff)
From: robin.murphy@arm.com (Robin Murphy) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH v2 03/15] arm64: mm: change IOMMU notifier action to attach DMA ops Date: Thu, 23 Jun 2016 12:32:12 +0100 [thread overview] Message-ID: <576BC8BC.6090400@arm.com> (raw) In-Reply-To: <20160617141536.GA24840@red-moon> Hi Lorenzo, On 17/06/16 15:15, Lorenzo Pieralisi wrote: >> I think this patch makes sense even independent of the rest of the >> series, one nit inline notwithstanding. > > Thanks. Yes I added it to this series since it is not strictly > necessary (ie it does not fix anything) in the mainline, but > it *is* necessary for this whole series to function when we > boot through ACPI. > > I will send it out in a separate patch and fold changes you > request below, it would be good to have some coverage for > it before merging it. Having considered it a bit more, triggering on BIND_DRIVER also means the silly "process the whole list every time" behaviour should go away. There's little point in trying to configure a device's ops before we know they're actually needed, and once a driver has bound it's too late to change anything anyway. What do you think of squashing in something like the below? Robin. ----->8----- diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index 7d3fa9ae8a11..02484dc3f369 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -854,10 +854,11 @@ static int __iommu_attach_notifier(struct notifier_block *nb, mutex_lock(&iommu_dma_notifier_lock); list_for_each_entry_safe(master, tmp, &iommu_dma_masters, list) { - if (do_iommu_attach(master->dev, master->ops, - master->dma_base, master->size)) { + if (data == master->dev && do_iommu_attach(master->dev, + master->ops, master->dma_base, master->size)) { list_del(&master->list); kfree(master); + break; } } mutex_unlock(&iommu_dma_notifier_lock);
next prev parent reply other threads:[~2016-06-23 11:32 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-07 13:30 [RFC PATCH v2 00/15] ACPI IORT ARM SMMU v3 support Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi [not found] ` <1465306270-27076-1-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org> 2016-06-07 13:30 ` [RFC PATCH v2 01/15] drivers: acpi: iort: fix struct pci_dev compiler warnings Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi 2016-06-07 13:30 ` [RFC PATCH v2 02/15] drivers: irqchip: its: fix its_acpi_probe() prototype Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi 2016-06-07 13:30 ` [RFC PATCH v2 03/15] arm64: mm: change IOMMU notifier action to attach DMA ops Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi 2016-06-17 9:27 ` Robin Murphy 2016-06-17 9:27 ` Robin Murphy [not found] ` <5763C27A.9030306-5wv7dgnIgG8@public.gmane.org> 2016-06-17 14:15 ` Lorenzo Pieralisi 2016-06-17 14:15 ` Lorenzo Pieralisi 2016-06-17 14:15 ` Lorenzo Pieralisi 2016-06-23 11:32 ` Robin Murphy [this message] 2016-06-23 11:32 ` Robin Murphy 2016-06-21 7:53 ` Marek Szyprowski 2016-06-21 7:53 ` Marek Szyprowski 2016-06-21 7:53 ` Marek Szyprowski 2016-06-21 7:53 ` Marek Szyprowski [not found] ` <03c537e7-0acf-edca-d0e0-369490c828df-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2016-06-21 16:06 ` Lorenzo Pieralisi 2016-06-21 16:06 ` Lorenzo Pieralisi 2016-06-21 16:06 ` Lorenzo Pieralisi 2016-06-21 16:06 ` Lorenzo Pieralisi 2016-06-23 6:13 ` Marek Szyprowski 2016-06-23 6:13 ` Marek Szyprowski 2016-06-07 13:30 ` [RFC PATCH v2 04/15] drivers: acpi: iort: add support for IOMMU registration Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi 2016-06-07 13:30 ` Lorenzo Pieralisi 2016-06-07 13:31 ` [RFC PATCH v2 05/15] drivers: acpi: iort: add support for named component look-up Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` [RFC PATCH v2 06/15] drivers: acpi: iort: enhance device identifiers mappings Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` [RFC PATCH v2 08/15] drivers: acpi: iort: add support for ARM SMMU platform devices creation Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` [RFC PATCH v2 09/15] drivers: iommu: arm-smmu-v3: split probe functions into DT/generic portions Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-14 18:09 ` Will Deacon 2016-06-14 18:09 ` Will Deacon 2016-06-07 13:31 ` [RFC PATCH v2 10/15] drivers: iommu: arm-smmu-v3: enable ACPI driver initialization Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-14 18:12 ` Will Deacon 2016-06-14 18:12 ` Will Deacon 2016-06-07 13:31 ` [RFC PATCH v2 13/15] drivers: acpi: iort: introduce iort_iommu_configure Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-10 12:46 ` Tomasz Nowicki 2016-06-10 12:46 ` Tomasz Nowicki 2016-06-10 12:46 ` Tomasz Nowicki 2016-06-07 13:31 ` [RFC PATCH v2 07/15] drivers: acpi: iort: add node match function Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` [RFC PATCH v2 11/15] drivers: iommu: arm-smmu-v3: add IORT iommu configuration Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-14 18:39 ` Will Deacon 2016-06-14 18:39 ` Will Deacon [not found] ` <20160614183939.GL16531-5wv7dgnIgG8@public.gmane.org> 2016-06-15 8:52 ` Lorenzo Pieralisi 2016-06-15 8:52 ` Lorenzo Pieralisi 2016-06-15 8:52 ` Lorenzo Pieralisi 2016-06-07 13:31 ` [RFC PATCH v2 12/15] drivers: acpi: implement acpi_dma_configure Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi [not found] ` <1465306270-27076-13-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org> 2016-06-10 16:25 ` Bjorn Helgaas 2016-06-10 16:25 ` Bjorn Helgaas 2016-06-10 16:25 ` Bjorn Helgaas 2016-06-07 13:31 ` [RFC PATCH v2 14/15] drivers: acpi: iort: add function to retrieve IOMMU platform devices Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-07 13:31 ` [RFC PATCH v2 15/15] drivers: iommu: arm-smmu-v3: allow ACPI based streamid translation Lorenzo Pieralisi 2016-06-07 13:31 ` Lorenzo Pieralisi 2016-06-21 10:37 ` [RFC PATCH v2 00/15] ACPI IORT ARM SMMU v3 support Hanjun Guo 2016-06-21 10:37 ` Hanjun Guo 2016-06-21 10:37 ` Hanjun Guo [not found] ` <b00f33ad-be24-21a9-b03b-611756bbc8e9-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-06-21 14:27 ` Lorenzo Pieralisi 2016-06-21 14:27 ` Lorenzo Pieralisi 2016-06-21 14:27 ` Lorenzo Pieralisi 2016-06-21 14:27 ` Lorenzo Pieralisi 2016-06-22 2:45 ` Hanjun Guo 2016-06-22 2:45 ` Hanjun Guo 2016-06-22 2:45 ` Hanjun Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=576BC8BC.6090400@arm.com \ --to=robin.murphy@arm.com \ --cc=catalin.marinas@arm.com \ --cc=hanjun.guo@linaro.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jcm@redhat.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=marc.zyngier@arm.com \ --cc=okaya@codeaurora.org \ --cc=rjw@rjwysocki.net \ --cc=tn@semihalf.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.