Re: [Qemu-devel] [PATCH 06/12] monitor: remove mhandler.cmd_new

From: Eric Blake <eblake@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 06/12] monitor: remove mhandler.cmd_new
Date: Fri, 24 Jun 2016 09:04:14 -0600	[thread overview]
Message-ID: <576D4BEE.8040403@redhat.com> (raw)
In-Reply-To: <CAJ+F1CJKafsXMd=GpcDEaRR-qZEgbGz8=u3T3+HgHLYKgzBGXA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1932 bytes --]

On 06/24/2016 08:20 AM, Marc-André Lureau wrote:
> Hi
> 
> On Fri, Jun 24, 2016 at 6:39 AM, Eric Blake <eblake@redhat.com> wrote:
>> On 06/22/2016 06:08 PM, marcandre.lureau@redhat.com wrote:
>>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>>
>>> This is no longer necessary, now that middle mode has been removed.
>>>
>>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>>> ---
>>>  docs/writing-qmp-commands.txt |   8 +-
>>>  hmp-commands-info.hx          | 118 ++++++++++++------------
>>>  hmp-commands.hx               | 206 +++++++++++++++++++++---------------------
>>>  monitor.c                     |  11 +--
>>>  4 files changed, 168 insertions(+), 175 deletions(-)
>>
>> The changes to hmp-commands*.hx are mechanical; you may want to set up
>> git to order the diff so that more relevant files like monitor.c are
>> listed first.  Do that by 'git config diff.orderFile /path/to/file',
>> then in that file, listing globs in the order that you want to prioritize.
>>
> 
> Nice tip, didn't know about it. I wonder if it would be worth to have
> one in qemu source tree..

Maybe not: it still requires a local setting to be useful (the file
existing in-tree doesn't mean that 'git diff' will automatically know to
use it without users editing .git/config); having it version-controlled
means that the diff you list now may depend on the version of the file
in your tree now rather than the version at the time the patch was first
generated for some confusing results; and there are still cases where I
personally find that I don't necessarily want the same order as last
time (so I'm frequently tweaking my own order file according to the
series I'm currently posting).

Hmm - maybe it should get a mention on the SubmitAPatch wiki page, though.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]