All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] e2fsprogs: add fuse2fs libintl fix patch
@ 2016-06-23  0:09 Gustavo Zacarias
  2016-06-25 13:44 ` Thomas Petazzoni
  2016-06-26 21:08 ` Thomas Petazzoni
  0 siblings, 2 replies; 4+ messages in thread
From: Gustavo Zacarias @ 2016-06-23  0:09 UTC (permalink / raw)
  To: buildroot

Fixes:
http://autobuild.buildroot.net/results/ab5/ab5c5b0e234f3d9db78c968334a61a7aef206b7a/

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/e2fsprogs/0003-fuse2fs-needs-SYSLIBS.patch | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 package/e2fsprogs/0003-fuse2fs-needs-SYSLIBS.patch

diff --git a/package/e2fsprogs/0003-fuse2fs-needs-SYSLIBS.patch b/package/e2fsprogs/0003-fuse2fs-needs-SYSLIBS.patch
new file mode 100644
index 0000000..61c6965
--- /dev/null
+++ b/package/e2fsprogs/0003-fuse2fs-needs-SYSLIBS.patch
@@ -0,0 +1,30 @@
+From ff6147dd7197519e561e796d56545c4e11eb43fa Mon Sep 17 00:00:00 2001
+From: Gustavo Zacarias <gustavo@zacarias.com.ar>
+Date: Wed, 22 Jun 2016 20:55:35 -0300
+Subject: [PATCH e2fsprogs] fuse2fs: needs SYSLIBS
+
+It otherwise leads to build failure when using an unbundled libintl.
+
+Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
+---
+Status: sent to ML http://marc.info/?l=linux-ext4&m=146664003825136&w=2
+
+ misc/Makefile.in | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/misc/Makefile.in b/misc/Makefile.in
+index f67c9c7..e487692 100644
+--- a/misc/Makefile.in
++++ b/misc/Makefile.in
+@@ -389,7 +389,7 @@ fuse2fs: $(FUSE2FS_OBJS) $(DEPLIBS) $(DEPLIBBLKID) $(DEPLIBUUID) \
+ 	$(E) "	LD $@"
+ 	$(Q) $(CC) $(ALL_LDFLAGS) -o fuse2fs $(FUSE2FS_OBJS) $(LIBS) \
+ 		$(LIBFUSE) $(LIBBLKID) $(LIBUUID) $(LIBEXT2FS) $(LIBINTL) \
+-		$(CLOCK_GETTIME_LIB)
++		$(CLOCK_GETTIME_LIB) $(SYSLIBS)
+ 
+ journal.o: $(srcdir)/../debugfs/journal.c
+ 	$(E) "	CC $@"
+-- 
+2.7.3
+
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] e2fsprogs: add fuse2fs libintl fix patch
  2016-06-23  0:09 [Buildroot] [PATCH] e2fsprogs: add fuse2fs libintl fix patch Gustavo Zacarias
@ 2016-06-25 13:44 ` Thomas Petazzoni
  2016-06-25 13:47   ` Gustavo Zacarias
  2016-06-26 21:08 ` Thomas Petazzoni
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2016-06-25 13:44 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed, 22 Jun 2016 21:09:34 -0300, Gustavo Zacarias wrote:

> +diff --git a/misc/Makefile.in b/misc/Makefile.in
> +index f67c9c7..e487692 100644
> +--- a/misc/Makefile.in
> ++++ b/misc/Makefile.in
> +@@ -389,7 +389,7 @@ fuse2fs: $(FUSE2FS_OBJS) $(DEPLIBS) $(DEPLIBBLKID) $(DEPLIBUUID) \
> + 	$(E) "	LD $@"
> + 	$(Q) $(CC) $(ALL_LDFLAGS) -o fuse2fs $(FUSE2FS_OBJS) $(LIBS) \
> + 		$(LIBFUSE) $(LIBBLKID) $(LIBUUID) $(LIBEXT2FS) $(LIBINTL) \

Isn't $(LIBINTL) supposed to contain -lintl ?

> +-		$(CLOCK_GETTIME_LIB)
> ++		$(CLOCK_GETTIME_LIB) $(SYSLIBS)

Why would -lintl be in $(SYSLIBS) instead of in $(LIBINTL) ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] e2fsprogs: add fuse2fs libintl fix patch
  2016-06-25 13:44 ` Thomas Petazzoni
@ 2016-06-25 13:47   ` Gustavo Zacarias
  0 siblings, 0 replies; 4+ messages in thread
From: Gustavo Zacarias @ 2016-06-25 13:47 UTC (permalink / raw)
  To: buildroot

On 25/06/16 10:44, Thomas Petazzoni wrote:

> Hello,
>
> On Wed, 22 Jun 2016 21:09:34 -0300, Gustavo Zacarias wrote:
>
>> +diff --git a/misc/Makefile.in b/misc/Makefile.in
>> +index f67c9c7..e487692 100644
>> +--- a/misc/Makefile.in
>> ++++ b/misc/Makefile.in
>> +@@ -389,7 +389,7 @@ fuse2fs: $(FUSE2FS_OBJS) $(DEPLIBS) $(DEPLIBBLKID) $(DEPLIBUUID) \
>> + 	$(E) "	LD $@"
>> + 	$(Q) $(CC) $(ALL_LDFLAGS) -o fuse2fs $(FUSE2FS_OBJS) $(LIBS) \
>> + 		$(LIBFUSE) $(LIBBLKID) $(LIBUUID) $(LIBEXT2FS) $(LIBINTL) \
>
> Isn't $(LIBINTL) supposed to contain -lintl ?
>
>> +-		$(CLOCK_GETTIME_LIB)
>> ++		$(CLOCK_GETTIME_LIB) $(SYSLIBS)
>
> Why would -lintl be in $(SYSLIBS) instead of in $(LIBINTL) ?

Hi.
Apparently $(LIBINTL) is for bundled libintl support (internal dep), if 
it's external (normally out case) then it's in $(SYSLIBS).
Regards.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] e2fsprogs: add fuse2fs libintl fix patch
  2016-06-23  0:09 [Buildroot] [PATCH] e2fsprogs: add fuse2fs libintl fix patch Gustavo Zacarias
  2016-06-25 13:44 ` Thomas Petazzoni
@ 2016-06-26 21:08 ` Thomas Petazzoni
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-06-26 21:08 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed, 22 Jun 2016 21:09:34 -0300, Gustavo Zacarias wrote:
> Fixes:
> http://autobuild.buildroot.net/results/ab5/ab5c5b0e234f3d9db78c968334a61a7aef206b7a/
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/e2fsprogs/0003-fuse2fs-needs-SYSLIBS.patch | 30 ++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 package/e2fsprogs/0003-fuse2fs-needs-SYSLIBS.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-06-26 21:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-23  0:09 [Buildroot] [PATCH] e2fsprogs: add fuse2fs libintl fix patch Gustavo Zacarias
2016-06-25 13:44 ` Thomas Petazzoni
2016-06-25 13:47   ` Gustavo Zacarias
2016-06-26 21:08 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.