* + make-compile_test-depend-on-uml.patch added to -mm tree
@ 2016-06-24 20:14 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2016-06-24 20:14 UTC (permalink / raw)
To: richard, arnd, viro, mm-commits
The patch titled
Subject: init/Kconfig: make COMPILE_TEST depend on !UML
has been added to the -mm tree. Its filename is
make-compile_test-depend-on-uml.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/make-compile_test-depend-on-uml.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/make-compile_test-depend-on-uml.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Richard Weinberger <richard@nod.at>
Subject: init/Kconfig: make COMPILE_TEST depend on !UML
UML is a bit special since it does not have iomem nor dma. That means a
lot of drivers will not build if they miss a dependency on HAS_IOMEM.
s390 used to have the same issues but since it gained PCI support UML is
the only stranger.
We are tired of patching dozens of new drivers after every merge window
just to un-break allmod/yesconfig UML builds. One could argue that a
decent driver has to know on what it depends and therefore a missing
HAS_IOMEM dependency is a clear driver bug. But the dependency not
obvious and not everyone does UML builds with COMPILE_TEST enabled when
developing a device driver.
A possible solution to make these builds succeed on UML would be providing
stub functions for ioremap() and friends which fail upon runtime. Another
one is simply disabling COMPILE_TEST for UML. Since it is the least
hassle and does not force use to fake iomem support let's do the latter.
Link: http://lkml.kernel.org/r/1466152995-28367-1-git-send-email-richard@nod.at
Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
init/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -puN init/Kconfig~make-compile_test-depend-on-uml init/Kconfig
--- a/init/Kconfig~make-compile_test-depend-on-uml
+++ a/init/Kconfig
@@ -55,6 +55,7 @@ config CROSS_COMPILE
config COMPILE_TEST
bool "Compile also drivers which will not load"
+ depends on !UML
default n
help
Some drivers can be compiled on a different platform than they are
_
Patches currently in -mm which might be from richard@nod.at are
make-compile_test-depend-on-uml.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-06-24 20:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-24 20:14 + make-compile_test-depend-on-uml.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.