From: David Long <dave.long@linaro.org> To: Huang Shijie <shijie.huang@arm.com> Cc: "Catalin Marinas" <catalin.marinas@arm.com>, "James Morse" <james.morse@arm.com>, "Marc Zyngier" <marc.zyngier@arm.com>, "Pratyush Anand" <panand@redhat.com>, "Sandeepa Prabhu" <sandeepa.s.prabhu@gmail.com>, "Will Deacon" <will.deacon@arm.com>, "William Cohen" <wcohen@redhat.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Steve Capper" <steve.capper@linaro.org>, "Masami Hiramatsu" <mhiramat@kernel.org>, "Li Bin" <huawei.libin@huawei.com>, "Adam Buchbinder" <adam.buchbinder@gmail.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Andrew Morton" <akpm@linux-foundation.org>, "Andrey Ryabinin" <ryabinin.a.a@gmail.com>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Christoffer Dall" <christoffer.dall@linaro.org>, "Daniel Thompson" <daniel.thompson@linaro.org>, "Dave P Martin" <Dave.Martin@arm.com>, "Jens Wiklander" <jens.wiklander@linaro.org>, "Jisheng Zhang" <jszhang@marvell.com>, "John Blackwood" <john.blackwood@ccur.com>, "Mark Rutland" <mark.rutland@arm.com>, "Petr Mladek" <pmladek@suse.com>, "Robin Murphy" <robin.murphy@arm.com>, "Suzuki K Poulose" <suzuki.poulose@arm.com>, "Vladimir Murzin" <Vladimir.Murzin@arm.com>, "Yang Shi" <yang.shi@linaro.org>, "Zi Shen Lim" <zlim.lnx@gmail.com>, "yalin wang" <yalin.wang2010@gmail.com>, "Mark Brown" <broonie@kernel.org>, nd@arm.com Subject: Re: [PATCH v13 10/10] kprobes: Add arm64 case in kprobe example module Date: Sun, 26 Jun 2016 22:54:51 -0400 [thread overview] Message-ID: <5770957B.4090104@linaro.org> (raw) In-Reply-To: <20160608054903.GA8198@sha-win-210.asiapac.arm.com> On 06/08/2016 01:49 AM, Huang Shijie wrote: > On Thu, Jun 02, 2016 at 11:26:24PM -0400, David Long wrote: >> From: Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com> >> >> Add info prints in sample kprobe handlers for ARM64 >> >> Signed-off-by: Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com> >> --- >> samples/kprobes/kprobe_example.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c >> index ed0ca0c..aad8e6f 100644 >> --- a/samples/kprobes/kprobe_example.c >> +++ b/samples/kprobes/kprobe_example.c >> @@ -46,6 +46,10 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs) >> " ex1 = 0x%lx\n", >> p->symbol_name, p->addr, regs->pc, regs->ex1); >> #endif >> +#ifdef CONFIG_ARM64 >> + pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n", >> + p->addr, (long)regs->pc); > Please add the "p->symbol_name" for the log, just as the above line. > The v14 patch set will have changes that align more closely to how this works on other architectures. >> +#endif >> >> /* A dump_stack() here will give a stack backtrace */ >> return 0; >> @@ -71,6 +75,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs, >> printk(KERN_INFO "<%s> post_handler: p->addr = 0x%p, ex1 = 0x%lx\n", >> p->symbol_name, p->addr, regs->ex1); >> #endif >> +#ifdef CONFIG_ARM64 >> + pr_info("post_handler: p->addr = 0x%p, pc = 0x%lx\n", >> + p->addr, (long)regs->pc); >> +#endif >> } > Ditto. > > thanks > Huang Shijie > Thanks, -dl
WARNING: multiple messages have this Message-ID (diff)
From: dave.long@linaro.org (David Long) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v13 10/10] kprobes: Add arm64 case in kprobe example module Date: Sun, 26 Jun 2016 22:54:51 -0400 [thread overview] Message-ID: <5770957B.4090104@linaro.org> (raw) In-Reply-To: <20160608054903.GA8198@sha-win-210.asiapac.arm.com> On 06/08/2016 01:49 AM, Huang Shijie wrote: > On Thu, Jun 02, 2016 at 11:26:24PM -0400, David Long wrote: >> From: Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com> >> >> Add info prints in sample kprobe handlers for ARM64 >> >> Signed-off-by: Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com> >> --- >> samples/kprobes/kprobe_example.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c >> index ed0ca0c..aad8e6f 100644 >> --- a/samples/kprobes/kprobe_example.c >> +++ b/samples/kprobes/kprobe_example.c >> @@ -46,6 +46,10 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs) >> " ex1 = 0x%lx\n", >> p->symbol_name, p->addr, regs->pc, regs->ex1); >> #endif >> +#ifdef CONFIG_ARM64 >> + pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n", >> + p->addr, (long)regs->pc); > Please add the "p->symbol_name" for the log, just as the above line. > The v14 patch set will have changes that align more closely to how this works on other architectures. >> +#endif >> >> /* A dump_stack() here will give a stack backtrace */ >> return 0; >> @@ -71,6 +75,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs, >> printk(KERN_INFO "<%s> post_handler: p->addr = 0x%p, ex1 = 0x%lx\n", >> p->symbol_name, p->addr, regs->ex1); >> #endif >> +#ifdef CONFIG_ARM64 >> + pr_info("post_handler: p->addr = 0x%p, pc = 0x%lx\n", >> + p->addr, (long)regs->pc); >> +#endif >> } > Ditto. > > thanks > Huang Shijie > Thanks, -dl
next prev parent reply other threads:[~2016-06-27 2:55 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-03 3:26 [PATCH v13 00/10] arm64: Add kernel probes (kprobes) support David Long 2016-06-03 3:26 ` David Long 2016-06-03 3:26 ` [PATCH v13 01/10] arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature David Long 2016-06-03 3:26 ` David Long 2016-06-03 11:36 ` Masami Hiramatsu 2016-06-03 11:36 ` Masami Hiramatsu 2016-06-20 2:43 ` Li Bin 2016-06-20 2:43 ` Li Bin 2016-06-23 13:48 ` David Long 2016-06-23 13:48 ` David Long 2016-06-03 3:26 ` [PATCH v13 02/10] arm64: Add more test functions to insn.c David Long 2016-06-03 3:26 ` David Long 2016-06-08 1:14 ` Masami Hiramatsu 2016-06-08 1:14 ` Masami Hiramatsu 2016-06-10 14:54 ` David Long 2016-06-10 14:54 ` David Long 2016-06-03 3:26 ` [PATCH v13 03/10] arm64: add conditional instruction simulation support David Long 2016-06-03 3:26 ` David Long 2016-06-04 3:53 ` Masami Hiramatsu 2016-06-04 3:53 ` Masami Hiramatsu 2016-06-13 4:19 ` David Long 2016-06-13 4:19 ` David Long 2016-06-03 3:26 ` [PATCH v13 04/10] arm64: Blacklist non-kprobe-able symbol David Long 2016-06-03 3:26 ` David Long 2016-06-04 3:40 ` Masami Hiramatsu 2016-06-04 3:40 ` Masami Hiramatsu 2016-06-07 3:52 ` David Long 2016-06-07 3:52 ` David Long 2016-06-10 19:16 ` David Long 2016-06-10 19:16 ` David Long 2016-06-03 3:26 ` [PATCH v13 05/10] arm64: Kprobes with single stepping support David Long 2016-06-03 3:26 ` David Long 2016-06-08 1:07 ` Masami Hiramatsu 2016-06-08 1:07 ` Masami Hiramatsu 2016-06-13 4:10 ` David Long 2016-06-13 4:10 ` David Long 2016-06-13 6:50 ` Masami Hiramatsu 2016-06-13 6:50 ` Masami Hiramatsu 2016-06-13 15:22 ` David Long 2016-06-13 15:22 ` David Long 2016-06-14 0:45 ` Masami Hiramatsu 2016-06-14 0:45 ` Masami Hiramatsu 2016-06-22 18:28 ` David Long 2016-06-22 18:28 ` David Long 2016-06-14 1:42 ` Masami Hiramatsu 2016-06-14 1:42 ` Masami Hiramatsu 2016-06-03 3:26 ` [PATCH v13 06/10] arm64: Treat all entry code as non-kprobe-able David Long 2016-06-03 3:26 ` David Long 2016-06-07 0:34 ` Masami Hiramatsu 2016-06-07 0:34 ` Masami Hiramatsu 2016-06-03 3:26 ` [PATCH v13 07/10] arm64: kprobes instruction simulation support David Long 2016-06-03 3:26 ` David Long 2016-06-03 3:26 ` [PATCH v13 08/10] arm64: Add trampoline code for kretprobes David Long 2016-06-03 3:26 ` David Long 2016-06-07 10:38 ` Masami Hiramatsu 2016-06-07 10:38 ` Masami Hiramatsu 2016-06-13 4:23 ` David Long 2016-06-13 4:23 ` David Long 2016-06-03 3:26 ` [PATCH v13 09/10] arm64: Add kernel return probes support (kretprobes) David Long 2016-06-03 3:26 ` David Long 2016-06-07 10:28 ` Masami Hiramatsu 2016-06-07 10:28 ` Masami Hiramatsu 2016-06-22 18:16 ` David Long 2016-06-22 18:16 ` David Long 2016-06-03 3:26 ` [PATCH v13 10/10] kprobes: Add arm64 case in kprobe example module David Long 2016-06-03 3:26 ` David Long 2016-06-07 10:12 ` Masami Hiramatsu 2016-06-07 10:12 ` Masami Hiramatsu 2016-06-08 5:49 ` Huang Shijie 2016-06-08 5:49 ` Huang Shijie 2016-06-27 2:54 ` David Long [this message] 2016-06-27 2:54 ` David Long
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5770957B.4090104@linaro.org \ --to=dave.long@linaro.org \ --cc=Dave.Martin@arm.com \ --cc=Vladimir.Murzin@arm.com \ --cc=adam.buchbinder@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=alex.bennee@linaro.org \ --cc=ard.biesheuvel@linaro.org \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=christoffer.dall@linaro.org \ --cc=daniel.thompson@linaro.org \ --cc=huawei.libin@huawei.com \ --cc=james.morse@arm.com \ --cc=jens.wiklander@linaro.org \ --cc=john.blackwood@ccur.com \ --cc=jszhang@marvell.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=mhiramat@kernel.org \ --cc=nd@arm.com \ --cc=panand@redhat.com \ --cc=pmladek@suse.com \ --cc=robin.murphy@arm.com \ --cc=ryabinin.a.a@gmail.com \ --cc=sandeepa.s.prabhu@gmail.com \ --cc=shijie.huang@arm.com \ --cc=steve.capper@linaro.org \ --cc=suzuki.poulose@arm.com \ --cc=wcohen@redhat.com \ --cc=will.deacon@arm.com \ --cc=yalin.wang2010@gmail.com \ --cc=yang.shi@linaro.org \ --cc=zlim.lnx@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.