RE: [PATCH 00/21] UFS patches for kernel v5.15

RE: [PATCH 00/21] UFS patches for kernel v5.15

[Avri Altman]

Hi,

>Hi Martin,
>
>Please consider the patches in this series for kernel v5.15. As one can see
>this patch series includes one ATA patch, four SCSI core patches and 16 UFS
>patches.

May I suggest to re-group the ufs part of this series so it can be reviewed more effectively:
 - Cleanups (relatively simple & intuitive, so can it be picked up ?)
  ufs: Reduce power management code duplication
  ufs: Only include power management code if necessary
  ufs: Rename the second ufshcd_probe_hba() argument
  ufs: Use DECLARE_COMPLETION_ONSTACK() where appropriate
  ufs: Remove ufshcd_valid_tag()
  ufs: Verify UIC locking requirements at runtime
  ufs: Improve static type checking for the host controller state
  ufs: Remove several wmb() calls
  ufs: Inline ufshcd_outstanding_req_clear()
  ufs: Rename __ufshcd_transfer_req_compl()

- Fixes of "Optimize host lock" (can those 2 be squashed ?)
  ufs: Fix a race in the completion path
  ufs: Use the doorbell register instead of the UTRLCNR register
  
 - Revamping ufs error handling
  ufs: Fix the SCSI abort handler
  ufs: Request sense data asynchronously
  ufs: Synchronize SCSI and UFS error handling
  ufs: Retry aborted SCSI commands instead of completing these successfully


Thanks,
Avri

Re: [PATCH 00/21] UFS patches for kernel v5.15

[Bart Van Assche]

On 7/6/21 4:28 AM, Avri Altman wrote:
> May I suggest to re-group the ufs part of this series so it can be reviewed more effectively:
>  - Cleanups (relatively simple & intuitive, so can it be picked up ?)
>   ufs: Reduce power management code duplication
>   ufs: Only include power management code if necessary
>   ufs: Rename the second ufshcd_probe_hba() argument
>   ufs: Use DECLARE_COMPLETION_ONSTACK() where appropriate
>   ufs: Remove ufshcd_valid_tag()
>   ufs: Verify UIC locking requirements at runtime
>   ufs: Improve static type checking for the host controller state
>   ufs: Remove several wmb() calls
>   ufs: Inline ufshcd_outstanding_req_clear()
>   ufs: Rename __ufshcd_transfer_req_compl()
> 
> - Fixes of "Optimize host lock" (can those 2 be squashed ?)
>   ufs: Fix a race in the completion path
>   ufs: Use the doorbell register instead of the UTRLCNR register
>   
>  - Revamping ufs error handling
>   ufs: Fix the SCSI abort handler
>   ufs: Request sense data asynchronously
>   ufs: Synchronize SCSI and UFS error handling
>   ufs: Retry aborted SCSI commands instead of completing these successfully

So this comes down to moving the "ufs: Fix the SCSI abort handler" later
in this series? I will make this change.

Thanks,

Bart.

[PATCH 00/21] UFS patches for kernel v5.15

[Bart Van Assche]

Hi Martin,

Please consider the patches in this series for kernel v5.15. As one can see
this patch series includes one ATA patch, four SCSI core patches and 16 UFS
patches.

Thanks,

Bart.

Bart Van Assche (21):
  Fix the documentation of the scsi_execute() time parameter
  libsas: Only abort commands from inside the error handler
  Clear host_eh_scheduled from inside the SCSI error handler
  libsas: Stop clearing host_eh_scheduled from the error handler
  ata: Stop clearing host_eh_scheduled from error handlers
  ufs: Reduce power management code duplication
  ufs: Only include power management code if necessary
  ufs: Rename the second ufshcd_probe_hba() argument
  ufs: Use DECLARE_COMPLETION_ONSTACK() where appropriate
  ufs: Remove ufshcd_valid_tag()
  ufs: Verify UIC locking requirements at runtime
  ufs: Improve static type checking for the host controller state
  ufs: Remove several wmb() calls
  ufs: Inline ufshcd_outstanding_req_clear()
  ufs: Rename __ufshcd_transfer_req_compl()
  ufs: Fix the SCSI abort handler
  ufs: Fix a race in the completion path
  ufs: Use the doorbell register instead of the UTRLCNR register
  ufs: Request sense data asynchronously
  ufs: Synchronize SCSI and UFS error handling
  ufs: Retry aborted SCSI commands instead of completing these
    successfully

 drivers/ata/libata-core.c             |   2 -
 drivers/ata/libata-eh.c               |  30 +-
 drivers/scsi/libsas/sas_scsi_host.c   |   9 +-
 drivers/scsi/scsi_error.c             |   7 +
 drivers/scsi/scsi_lib.c               |   2 +-
 drivers/scsi/ufs/cdns-pltfrm.c        |   7 +-
 drivers/scsi/ufs/tc-dwc-g210-pci.c    |  32 +-
 drivers/scsi/ufs/tc-dwc-g210-pltfrm.c |   7 +-
 drivers/scsi/ufs/ufs-exynos.c         |   7 +-
 drivers/scsi/ufs/ufs-hisi.c           |   7 +-
 drivers/scsi/ufs/ufs-mediatek.c       |   7 +-
 drivers/scsi/ufs/ufs-qcom.c           |   7 +-
 drivers/scsi/ufs/ufshcd-pci.c         |  48 +--
 drivers/scsi/ufs/ufshcd-pltfrm.c      |  47 ---
 drivers/scsi/ufs/ufshcd-pltfrm.h      |  18 -
 drivers/scsi/ufs/ufshcd.c             | 467 +++++++++++---------------
 drivers/scsi/ufs/ufshcd.h             |  48 ++-
 include/linux/libata.h                |   1 -
 include/scsi/libsas.h                 |   1 +
 19 files changed, 271 insertions(+), 483 deletions(-)