* [PACTH i-g-t v1] lib/drmtest: Change DRIVER_INTEL check to avoid running GEM on non-Intel
@ 2016-06-27 17:53 robert.foss
2016-06-28 9:06 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: robert.foss @ 2016-06-27 17:53 UTC (permalink / raw)
To: daniel.vetter, daniel.stone, marius.c.vlad, tomeu.vizoso, chris; +Cc: intel-gfx
From: Robert Foss <robert.foss@collabora.com>
Avoid running gem_quiescent_gpu() on non-Intel hardware.
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
lib/drmtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index 632fec4..6427657 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -338,7 +338,7 @@ int drm_open_driver(int chipset)
if (__sync_fetch_and_add(&open_count, 1))
return fd;
- if(chipset & DRIVER_INTEL){
+ if(chipset == DRIVER_INTEL){
gem_quiescent_gpu(fd);
igt_install_exit_handler(quiescent_gpu_at_exit);
}
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PACTH i-g-t v1] lib/drmtest: Change DRIVER_INTEL check to avoid running GEM on non-Intel
2016-06-27 17:53 [PACTH i-g-t v1] lib/drmtest: Change DRIVER_INTEL check to avoid running GEM on non-Intel robert.foss
@ 2016-06-28 9:06 ` Chris Wilson
2016-06-28 9:46 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2016-06-28 9:06 UTC (permalink / raw)
To: robert.foss; +Cc: daniel.vetter, intel-gfx, tomeu.vizoso, daniel.stone
On Mon, Jun 27, 2016 at 01:53:13PM -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
>
> Avoid running gem_quiescent_gpu() on non-Intel hardware.
>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> ---
> lib/drmtest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 632fec4..6427657 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -338,7 +338,7 @@ int drm_open_driver(int chipset)
> if (__sync_fetch_and_add(&open_count, 1))
> return fd;
>
> - if(chipset & DRIVER_INTEL){
> + if(chipset == DRIVER_INTEL){
That doesn't work. You need an is_i915_device()
Took the liberty of making that change and pushing with your credit.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PACTH i-g-t v1] lib/drmtest: Change DRIVER_INTEL check to avoid running GEM on non-Intel
2016-06-28 9:06 ` Chris Wilson
@ 2016-06-28 9:46 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2016-06-28 9:46 UTC (permalink / raw)
To: Chris Wilson, daniel.vetter, daniel.stone, marius.c.vlad,
tomeu.vizoso, intel-gfx
Thanks Chris!
On 2016-06-28 05:06 AM, Chris Wilson wrote:
> On Mon, Jun 27, 2016 at 01:53:13PM -0400, robert.foss@collabora.com wrote:
>> From: Robert Foss <robert.foss@collabora.com>
>>
>> Avoid running gem_quiescent_gpu() on non-Intel hardware.
>>
>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>> ---
>> lib/drmtest.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/drmtest.c b/lib/drmtest.c
>> index 632fec4..6427657 100644
>> --- a/lib/drmtest.c
>> +++ b/lib/drmtest.c
>> @@ -338,7 +338,7 @@ int drm_open_driver(int chipset)
>> if (__sync_fetch_and_add(&open_count, 1))
>> return fd;
>>
>> - if(chipset & DRIVER_INTEL){
>> + if(chipset == DRIVER_INTEL){
>
> That doesn't work. You need an is_i915_device()
> Took the liberty of making that change and pushing with your credit.
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-28 9:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-27 17:53 [PACTH i-g-t v1] lib/drmtest: Change DRIVER_INTEL check to avoid running GEM on non-Intel robert.foss
2016-06-28 9:06 ` Chris Wilson
2016-06-28 9:46 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.