From: Kishon Vijay Abraham I <kishon@ti.com> To: David Lechner <david@lechnology.com>, <nsekhar@ti.com>, Bin Liu <b-liu@ti.com> Cc: <khilman@kernel.org>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Alan Stern <stern@rowland.harvard.edu>, Lee Jones <lee.jones@linaro.org>, <petr@barix.com>, <sergei.shtylyov@cogentembedded.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org> Subject: Re: [PATCH v5 3/7] phy: Add set_mode callback Date: Mon, 4 Jul 2016 18:22:10 +0530 [thread overview] Message-ID: <577A5BFA.5010308@ti.com> (raw) In-Reply-To: <57712075.1090202@ti.com> Hi Bin, On Monday 27 June 2016 06:17 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 10 May 2016 05:09 AM, David Lechner wrote: >> The initial use for this is for PHYs that have a mode related to USB OTG. >> There are several SoCs (e.g. TI OMAP and DA8xx) that have a mode setting >> in the USB PHY to override OTG VBUS and ID signals. >> >> Of course, the enum can be expaned in the future to include modes for >> other types of PHYs as well. >> >> Suggested-by: Kishon Vijay Abraham I <kishon@ti.com> >> Signed-off-by: David Lechner <david@lechnology.com> > > I've created a immutable branch for this patch and it can be found here. > git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git > tags/phy-set-mode There was a build error in the above tag with allyesconfig. So I have created a new tag which includes the fix patch in addition to this patch. new tag: tags/phy-set-mode-v2 In the patches you sent to Greg [1], I didn't see this series included. However if you are planning to send another pull request for the next merge window, request you to use the new tag. Thanks Kishon [1] -> http://www.spinics.net/lists/linux-usb/msg142788.html > > I've merged this tag to my -next. > > Thanks > Kishon > >> --- >> drivers/phy/phy-core.c | 15 +++++++++++++++ >> include/linux/phy/phy.h | 17 +++++++++++++++++ >> 2 files changed, 32 insertions(+) >> >> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c >> index e7e574d..fe0344c 100644 >> --- a/drivers/phy/phy-core.c >> +++ b/drivers/phy/phy-core.c >> @@ -342,6 +342,21 @@ int phy_power_off(struct phy *phy) >> } >> EXPORT_SYMBOL_GPL(phy_power_off); >> >> +int phy_set_mode(struct phy *phy, enum phy_mode mode) >> +{ >> + int ret; >> + >> + if (!phy || !phy->ops->set_mode) >> + return 0; >> + >> + mutex_lock(&phy->mutex); >> + ret = phy->ops->set_mode(phy, mode); >> + mutex_unlock(&phy->mutex); >> + >> + return ret; >> +} >> +EXPORT_SYMBOL_GPL(phy_set_mode); >> + >> /** >> * _of_phy_get() - lookup and obtain a reference to a phy by phandle >> * @np: device_node for which to get the phy >> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h >> index 8cf05e3..4248ade 100644 >> --- a/include/linux/phy/phy.h >> +++ b/include/linux/phy/phy.h >> @@ -22,12 +22,20 @@ >> >> struct phy; >> >> +enum phy_mode { >> + PHY_MODE_INVALID, >> + PHY_MODE_USB_HOST, >> + PHY_MODE_USB_DEVICE, >> + PHY_MODE_USB_OTG, >> +}; >> + >> /** >> * struct phy_ops - set of function pointers for performing phy operations >> * @init: operation to be performed for initializing phy >> * @exit: operation to be performed while exiting >> * @power_on: powering on the phy >> * @power_off: powering off the phy >> + * @set_mode: set the mode of the phy >> * @owner: the module owner containing the ops >> */ >> struct phy_ops { >> @@ -35,6 +43,7 @@ struct phy_ops { >> int (*exit)(struct phy *phy); >> int (*power_on)(struct phy *phy); >> int (*power_off)(struct phy *phy); >> + int (*set_mode)(struct phy *phy, enum phy_mode mode); >> struct module *owner; >> }; >> >> @@ -119,6 +128,7 @@ int phy_init(struct phy *phy); >> int phy_exit(struct phy *phy); >> int phy_power_on(struct phy *phy); >> int phy_power_off(struct phy *phy); >> +int phy_set_mode(struct phy *phy, enum phy_mode mode); >> static inline int phy_get_bus_width(struct phy *phy) >> { >> return phy->attrs.bus_width; >> @@ -224,6 +234,13 @@ static inline int phy_power_off(struct phy *phy) >> return -ENOSYS; >> } >> >> +static inline int phy_set_mode(struct phy *phy, enum phy_mode mode) >> +{ >> + if (!phy) >> + return 0; >> + return -ENOSYS; >> +} >> + >> static inline int phy_get_bus_width(struct phy *phy) >> { >> return -ENOSYS; >>
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com> To: David Lechner <david@lechnology.com>, nsekhar@ti.com, Bin Liu <b-liu@ti.com> Cc: khilman@kernel.org, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Alan Stern <stern@rowland.harvard.edu>, Lee Jones <lee.jones@linaro.org>, petr@barix.com, sergei.shtylyov@cogentembedded.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v5 3/7] phy: Add set_mode callback Date: Mon, 4 Jul 2016 18:22:10 +0530 [thread overview] Message-ID: <577A5BFA.5010308@ti.com> (raw) In-Reply-To: <57712075.1090202@ti.com> Hi Bin, On Monday 27 June 2016 06:17 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 10 May 2016 05:09 AM, David Lechner wrote: >> The initial use for this is for PHYs that have a mode related to USB OTG. >> There are several SoCs (e.g. TI OMAP and DA8xx) that have a mode setting >> in the USB PHY to override OTG VBUS and ID signals. >> >> Of course, the enum can be expaned in the future to include modes for >> other types of PHYs as well. >> >> Suggested-by: Kishon Vijay Abraham I <kishon@ti.com> >> Signed-off-by: David Lechner <david@lechnology.com> > > I've created a immutable branch for this patch and it can be found here. > git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git > tags/phy-set-mode There was a build error in the above tag with allyesconfig. So I have created a new tag which includes the fix patch in addition to this patch. new tag: tags/phy-set-mode-v2 In the patches you sent to Greg [1], I didn't see this series included. However if you are planning to send another pull request for the next merge window, request you to use the new tag. Thanks Kishon [1] -> http://www.spinics.net/lists/linux-usb/msg142788.html > > I've merged this tag to my -next. > > Thanks > Kishon > >> --- >> drivers/phy/phy-core.c | 15 +++++++++++++++ >> include/linux/phy/phy.h | 17 +++++++++++++++++ >> 2 files changed, 32 insertions(+) >> >> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c >> index e7e574d..fe0344c 100644 >> --- a/drivers/phy/phy-core.c >> +++ b/drivers/phy/phy-core.c >> @@ -342,6 +342,21 @@ int phy_power_off(struct phy *phy) >> } >> EXPORT_SYMBOL_GPL(phy_power_off); >> >> +int phy_set_mode(struct phy *phy, enum phy_mode mode) >> +{ >> + int ret; >> + >> + if (!phy || !phy->ops->set_mode) >> + return 0; >> + >> + mutex_lock(&phy->mutex); >> + ret = phy->ops->set_mode(phy, mode); >> + mutex_unlock(&phy->mutex); >> + >> + return ret; >> +} >> +EXPORT_SYMBOL_GPL(phy_set_mode); >> + >> /** >> * _of_phy_get() - lookup and obtain a reference to a phy by phandle >> * @np: device_node for which to get the phy >> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h >> index 8cf05e3..4248ade 100644 >> --- a/include/linux/phy/phy.h >> +++ b/include/linux/phy/phy.h >> @@ -22,12 +22,20 @@ >> >> struct phy; >> >> +enum phy_mode { >> + PHY_MODE_INVALID, >> + PHY_MODE_USB_HOST, >> + PHY_MODE_USB_DEVICE, >> + PHY_MODE_USB_OTG, >> +}; >> + >> /** >> * struct phy_ops - set of function pointers for performing phy operations >> * @init: operation to be performed for initializing phy >> * @exit: operation to be performed while exiting >> * @power_on: powering on the phy >> * @power_off: powering off the phy >> + * @set_mode: set the mode of the phy >> * @owner: the module owner containing the ops >> */ >> struct phy_ops { >> @@ -35,6 +43,7 @@ struct phy_ops { >> int (*exit)(struct phy *phy); >> int (*power_on)(struct phy *phy); >> int (*power_off)(struct phy *phy); >> + int (*set_mode)(struct phy *phy, enum phy_mode mode); >> struct module *owner; >> }; >> >> @@ -119,6 +128,7 @@ int phy_init(struct phy *phy); >> int phy_exit(struct phy *phy); >> int phy_power_on(struct phy *phy); >> int phy_power_off(struct phy *phy); >> +int phy_set_mode(struct phy *phy, enum phy_mode mode); >> static inline int phy_get_bus_width(struct phy *phy) >> { >> return phy->attrs.bus_width; >> @@ -224,6 +234,13 @@ static inline int phy_power_off(struct phy *phy) >> return -ENOSYS; >> } >> >> +static inline int phy_set_mode(struct phy *phy, enum phy_mode mode) >> +{ >> + if (!phy) >> + return 0; >> + return -ENOSYS; >> +} >> + >> static inline int phy_get_bus_width(struct phy *phy) >> { >> return -ENOSYS; >>
next prev parent reply other threads:[~2016-07-04 12:53 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-09 23:39 [PATCH v5 0/7] da8xx USB PHY (was da8xx USB clocks) David Lechner 2016-05-09 23:39 ` [PATCH v5 1/7] mfd: da8xx-cfgchip: New header file for CFGCHIP registers David Lechner 2016-07-21 13:23 ` Kishon Vijay Abraham I 2016-07-21 13:23 ` Kishon Vijay Abraham I 2016-05-09 23:39 ` [PATCH v5 2/7] dt-bindings: Add bindings for phy-da8xx-usb David Lechner 2016-05-09 23:39 ` [PATCH v5 3/7] phy: Add set_mode callback David Lechner 2016-06-22 5:57 ` Kishon Vijay Abraham I 2016-06-22 5:57 ` Kishon Vijay Abraham I 2016-06-22 17:00 ` David Lechner 2016-06-22 17:00 ` David Lechner 2016-06-27 12:47 ` Kishon Vijay Abraham I 2016-06-27 12:47 ` Kishon Vijay Abraham I 2016-07-04 12:52 ` Kishon Vijay Abraham I [this message] 2016-07-04 12:52 ` Kishon Vijay Abraham I 2016-05-09 23:40 ` [PATCH v5 4/7] phy: da8xx-usb: new driver for DA8xx SoC USB PHY David Lechner 2016-06-10 13:16 ` Sekhar Nori 2016-06-10 13:16 ` Sekhar Nori 2016-06-22 16:58 ` David Lechner 2016-06-22 16:58 ` David Lechner 2016-06-22 17:15 ` David Lechner 2016-05-09 23:40 ` [PATCH v5 5/7] usb: ohci-da8xx: Remove code that references mach David Lechner 2016-05-09 23:40 ` David Lechner 2016-05-09 23:40 ` [PATCH v5 6/7] usb: musb: da8xx: Use devm in probe David Lechner 2016-05-09 23:40 ` [PATCH v5 7/7] usb: musb: da8xx: Remove mach code David Lechner 2016-05-09 23:40 ` David Lechner 2016-06-27 12:48 ` [PATCH v5 0/7] da8xx USB PHY (was da8xx USB clocks) Kishon Vijay Abraham I 2016-06-27 12:48 ` Kishon Vijay Abraham I
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=577A5BFA.5010308@ti.com \ --to=kishon@ti.com \ --cc=b-liu@ti.com \ --cc=david@lechnology.com \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=gregkh@linuxfoundation.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=khilman@kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nsekhar@ti.com \ --cc=pawel.moll@arm.com \ --cc=petr@barix.com \ --cc=robh+dt@kernel.org \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=stern@rowland.harvard.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.