All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Alberto Garcia <berto@igalia.com>
Subject: Re: [Qemu-devel] [PATCH v1 2/2] Revert "block: don't register quorum driver if SHA256 support is unavailable"
Date: Tue, 5 Jul 2016 09:04:56 -0600	[thread overview]
Message-ID: <577BCC98.3000007@redhat.com> (raw)
In-Reply-To: <1467715800-20379-3-git-send-email-berrange@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

On 07/05/2016 04:50 AM, Daniel P. Berrange wrote:
> The qcrypto hash APIs now guarantee that sha256 is available at
> compile time, so skipping registration is rarely needed. A check
> at time of open is kept to ensure good error reporting in the
> (unlikely) case sha256 is runtime disabled.
> 
> This reverts commit e94867ed5f241008d0f53142b2704a075f9ed505.
> ---
>  block/quorum.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2016-07-05 15:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05 10:49 [Qemu-devel] [PATCH v1 0/2] Use GChecksum as fallback hash impl Daniel P. Berrange
2016-07-05 10:49 ` [Qemu-devel] [PATCH v1 1/2] crypto: use glib as fallback for hash algorithm Daniel P. Berrange
2016-07-05 15:03   ` Eric Blake
2016-07-05 15:32     ` Daniel P. Berrange
2016-07-06 11:58   ` Alberto Garcia
2016-07-06 14:53     ` Eric Blake
2016-07-07  9:18       ` Daniel P. Berrange
2016-07-07  8:52   ` Alberto Garcia
2016-07-05 10:50 ` [Qemu-devel] [PATCH v1 2/2] Revert "block: don't register quorum driver if SHA256 support is unavailable" Daniel P. Berrange
2016-07-05 15:04   ` Eric Blake [this message]
2016-07-07  8:53   ` Alberto Garcia
2016-07-05 16:43 ` [Qemu-devel] [PATCH v1 3/2] crypto: don't open-code qcrypto_hash_supports Daniel P. Berrange
2016-07-05 22:26   ` Eric Blake
2016-07-07  8:55   ` Alberto Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577BCC98.3000007@redhat.com \
    --to=eblake@redhat.com \
    --cc=berrange@redhat.com \
    --cc=berto@igalia.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.