* [RESEND/BUG PATCH v3] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0
@ 2016-07-05 15:32 Jeremy Linton
2016-07-05 18:45 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Jeremy Linton @ 2016-07-05 15:32 UTC (permalink / raw)
To: netdev; +Cc: davem, steve.glendinning, andrew, sergei.shtylyov
By default, mdiobus_alloc() sets the PHYs to polling mode, but a
pointer size memcpy means that a couple IRQs end up being overwritten
with a value of 0. This means that PHY_POLL is disabled and results
in unpredictable behavior depending on the PHY's location on the
MDIO bus. Remove that memcpy and the now unused phy_irq member to
force the SMSC911x PHYs into polling mode 100% of the time.
Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 8af2556..b5ab5e1 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -116,7 +116,6 @@ struct smsc911x_data {
struct phy_device *phy_dev;
struct mii_bus *mii_bus;
- int phy_irq[PHY_MAX_ADDR];
unsigned int using_extphy;
int last_duplex;
int last_carrier;
@@ -1073,7 +1072,6 @@ static int smsc911x_mii_init(struct platform_device *pdev,
pdata->mii_bus->priv = pdata;
pdata->mii_bus->read = smsc911x_mii_read;
pdata->mii_bus->write = smsc911x_mii_write;
- memcpy(pdata->mii_bus->irq, pdata->phy_irq, sizeof(pdata->mii_bus));
pdata->mii_bus->parent = &pdev->dev;
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND/BUG PATCH v3] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0
2016-07-05 15:32 [RESEND/BUG PATCH v3] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0 Jeremy Linton
@ 2016-07-05 18:45 ` Sergei Shtylyov
2016-07-05 19:02 ` Jeremy Linton
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2016-07-05 18:45 UTC (permalink / raw)
To: Jeremy Linton, netdev; +Cc: davem, steve.glendinning, andrew
The patch has been merged to 4.7-rc6, why resend it?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND/BUG PATCH v3] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0
2016-07-05 18:45 ` Sergei Shtylyov
@ 2016-07-05 19:02 ` Jeremy Linton
0 siblings, 0 replies; 3+ messages in thread
From: Jeremy Linton @ 2016-07-05 19:02 UTC (permalink / raw)
To: Sergei Shtylyov, netdev; +Cc: davem, steve.glendinning, andrew
On 07/05/2016 01:45 PM, Sergei Shtylyov wrote:
> The patch has been merged to 4.7-rc6, why resend it?
Sorry, I must have missed the merge.
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-05 19:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-05 15:32 [RESEND/BUG PATCH v3] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0 Jeremy Linton
2016-07-05 18:45 ` Sergei Shtylyov
2016-07-05 19:02 ` Jeremy Linton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.