All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Linton <jeremy.linton@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
	mark.rutland@arm.com, catalin.marinas@arm.com,
	Lorenzo.Pieralisi@arm.com, alexander.shishkin@linux.intel.com,
	acme@kernel.org, mingo@redhat.com, peterz@infradead.org,
	mlangsdorf@redhat.com, punit.agrawal@arm.com,
	Steve.Capper@arm.com
Subject: Re: [PATCH 06/11] arm: arm64: Add routine to determine cpuid of other cpus
Date: Wed, 6 Jul 2016 19:34:23 -0500	[thread overview]
Message-ID: <577DA38F.1000709@arm.com> (raw)
In-Reply-To: <20160706163001.GC31910@arm.com>

On 07/06/2016 11:30 AM, Will Deacon wrote:
> On Tue, Jun 21, 2016 at 12:11:44PM -0500, Jeremy Linton wrote:
>> It is helpful if we can read the cpuid/midr of other CPUs
>> in the system independent of arm/arm64.
>>
>> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
>> ---
>>   arch/arm/include/asm/cputype.h   | 6 +++++-
>>   arch/arm64/include/asm/cputype.h | 4 ++++
>>   2 files changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/include/asm/cputype.h b/arch/arm/include/asm/cputype.h
>> index 1ee94c7..e391b67 100644
>> --- a/arch/arm/include/asm/cputype.h
>> +++ b/arch/arm/include/asm/cputype.h
>> @@ -81,6 +81,8 @@
>>   #define ARM_CPU_XSCALE_ARCH_V2		0x4000
>>   #define ARM_CPU_XSCALE_ARCH_V3		0x6000
>>
>> +#define ARM_PARTNUM(cpuid_id) (cpuid_id & ARM_CPU_PART_MASK)
>> +
>>   extern unsigned int processor_id;
>>
>>   #ifdef CONFIG_CPU_CP15
>> @@ -180,7 +182,7 @@ static inline unsigned int __attribute_const__ read_cpuid_implementor(void)
>>    */
>>   static inline unsigned int __attribute_const__ read_cpuid_part(void)
>>   {
>> -	return read_cpuid_id() & ARM_CPU_PART_MASK;
>> +	return ARM_PARTNUM(read_cpuid_id());
>
> I don't understand why you need to make this change.

The short answer is that the ARM_PARTNUM stuff is left over from v4 (?) 
of the patch, where it seemed a good idea to create a macro that was 
arm/arm64 independent for use in arm_pmu.c. Somewhere along there I 
reverted the ARM_PARTNUM to MIDR_PARTNUM in the arm_pmu_acpi.c but 
didn't drop that portion from this patch. Partially because it seems 
like a good idea. OTOH, your right probably doesn't belong here without 
the large cleanup which would form their own patch set.




WARNING: multiple messages have this Message-ID (diff)
From: jeremy.linton@arm.com (Jeremy Linton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/11] arm: arm64: Add routine to determine cpuid of other cpus
Date: Wed, 6 Jul 2016 19:34:23 -0500	[thread overview]
Message-ID: <577DA38F.1000709@arm.com> (raw)
In-Reply-To: <20160706163001.GC31910@arm.com>

On 07/06/2016 11:30 AM, Will Deacon wrote:
> On Tue, Jun 21, 2016 at 12:11:44PM -0500, Jeremy Linton wrote:
>> It is helpful if we can read the cpuid/midr of other CPUs
>> in the system independent of arm/arm64.
>>
>> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
>> ---
>>   arch/arm/include/asm/cputype.h   | 6 +++++-
>>   arch/arm64/include/asm/cputype.h | 4 ++++
>>   2 files changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/include/asm/cputype.h b/arch/arm/include/asm/cputype.h
>> index 1ee94c7..e391b67 100644
>> --- a/arch/arm/include/asm/cputype.h
>> +++ b/arch/arm/include/asm/cputype.h
>> @@ -81,6 +81,8 @@
>>   #define ARM_CPU_XSCALE_ARCH_V2		0x4000
>>   #define ARM_CPU_XSCALE_ARCH_V3		0x6000
>>
>> +#define ARM_PARTNUM(cpuid_id) (cpuid_id & ARM_CPU_PART_MASK)
>> +
>>   extern unsigned int processor_id;
>>
>>   #ifdef CONFIG_CPU_CP15
>> @@ -180,7 +182,7 @@ static inline unsigned int __attribute_const__ read_cpuid_implementor(void)
>>    */
>>   static inline unsigned int __attribute_const__ read_cpuid_part(void)
>>   {
>> -	return read_cpuid_id() & ARM_CPU_PART_MASK;
>> +	return ARM_PARTNUM(read_cpuid_id());
>
> I don't understand why you need to make this change.

The short answer is that the ARM_PARTNUM stuff is left over from v4 (?) 
of the patch, where it seemed a good idea to create a macro that was 
arm/arm64 independent for use in arm_pmu.c. Somewhere along there I 
reverted the ARM_PARTNUM to MIDR_PARTNUM in the arm_pmu_acpi.c but 
didn't drop that portion from this patch. Partially because it seems 
like a good idea. OTOH, your right probably doesn't belong here without 
the large cleanup which would form their own patch set.

  reply	other threads:[~2016-07-07  0:34 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 17:11 [PATCH v6 00/11] Enable PMUs in ACPI systems Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 01/11] arm64: pmu: add fallback probe table Jeremy Linton
2016-06-21 17:11   ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 02/11] arm64: pmu: Probe default hw/cache counters Jeremy Linton
2016-06-21 17:11   ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 03/11] arm64: pmu: Hoist pmu platform device name Jeremy Linton
2016-06-21 17:11   ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 04/11] arm64: Rename the common MADT parse routine Jeremy Linton
2016-06-21 17:11   ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 05/11] arm64: pmu: Add support for probing with ACPI Jeremy Linton
2016-06-21 17:11   ` Jeremy Linton
2016-07-06 16:45   ` Will Deacon
2016-07-06 16:45     ` Will Deacon
2016-06-21 17:11 ` [PATCH 06/11] arm: arm64: Add routine to determine cpuid of other cpus Jeremy Linton
2016-06-21 17:11   ` Jeremy Linton
2016-07-06 16:30   ` Will Deacon
2016-07-06 16:30     ` Will Deacon
2016-07-07  0:34     ` Jeremy Linton [this message]
2016-07-07  0:34       ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 07/11] arm: arm64: pmu: Assign platform PMU CPU affinity Jeremy Linton
2016-06-21 17:11   ` Jeremy Linton
2016-07-01 14:00   ` Punit Agrawal
2016-07-01 14:00     ` Punit Agrawal
2016-06-21 17:11 ` [PATCH 08/11] arm64: pmu: Provide cpumask attribute for PMU Jeremy Linton
2016-06-21 17:11   ` Jeremy Linton
2016-07-07 16:21   ` Mark Rutland
2016-07-07 16:21     ` Mark Rutland
2016-07-11 15:05     ` Jeremy Linton
2016-07-11 15:05       ` Jeremy Linton
2016-07-11 15:58       ` Mark Rutland
2016-07-11 15:58         ` Mark Rutland
2016-07-11 16:14         ` Will Deacon
2016-07-11 16:14           ` Will Deacon
2016-06-21 17:11 ` [PATCH 09/11] arm64: pmu: Add routines for detecting differing PMU types in the system Jeremy Linton
2016-06-21 17:11   ` Jeremy Linton
2016-07-01 13:58   ` Punit Agrawal
2016-07-01 13:58     ` Punit Agrawal
2016-07-01 14:54     ` Jeremy Linton
2016-07-01 14:54       ` Jeremy Linton
2016-07-01 15:43       ` Punit Agrawal
2016-07-01 15:43         ` Punit Agrawal
2016-07-01 16:21         ` Jeremy Linton
2016-07-01 16:21           ` Jeremy Linton
2016-07-01 15:28     ` Jeremy Linton
2016-07-01 15:28       ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 10/11] arm64: pmu: Enable multiple PMUs in an ACPI system Jeremy Linton
2016-06-21 17:11   ` Jeremy Linton
2016-07-01 13:57   ` Punit Agrawal
2016-07-01 13:57     ` Punit Agrawal
2016-06-21 17:11 ` [PATCH 11/11] MAINTAINERS: Tweak ARM PMU maintainers Jeremy Linton
2016-06-21 17:11   ` Jeremy Linton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577DA38F.1000709@arm.com \
    --to=jeremy.linton@arm.com \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=Steve.Capper@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=mlangsdorf@redhat.com \
    --cc=peterz@infradead.org \
    --cc=punit.agrawal@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.