All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad
       [not found] <cover.1467421035.git.joseph.salisbury@canonical.com>
@ 2016-07-06 21:53 ` Joseph Salisbury
  2016-07-06 23:10   ` Greg KH
  2016-07-08  1:05   ` Lu Baolu
  0 siblings, 2 replies; 4+ messages in thread
From: Joseph Salisbury @ 2016-07-06 21:53 UTC (permalink / raw)
  To: gregkh, hdegoede, adrienverge, yaowen, vpalatin, stern
  Cc: linux-kernel, linux-usb, stable

BugLink: http://bugs.launchpad.net/bugs/1498667

As reported in BugLink, this device has an issue with Linux Power Management so 
adding a quirk.  This quirk was reccomended by Alan Stern:

http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html

Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: stable <stable@vger.kernel.org>

---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 944a6dc..a33d003 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -198,6 +198,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* Protocol and OTG Electrical Test Device */
 	{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
 			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
+
+	/* ELAN Microelectronics Touchscreen */
+	{ USB_DEVICE(0x04f3, 0x0381), .driver_info = USB_QUIRK_NO_LPM },
 
 	/* Acer C120 LED Projector */
 	{ USB_DEVICE(0x1de1, 0xc102), .driver_info = USB_QUIRK_NO_LPM },
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad
  2016-07-06 21:53 ` [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad Joseph Salisbury
@ 2016-07-06 23:10   ` Greg KH
  2016-07-07  0:24     ` Joseph Salisbury
  2016-07-08  1:05   ` Lu Baolu
  1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2016-07-06 23:10 UTC (permalink / raw)
  To: Joseph Salisbury
  Cc: hdegoede, adrienverge, yaowen, vpalatin, stern, linux-kernel,
	linux-usb, stable

On Wed, Jul 06, 2016 at 05:53:47PM -0400, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1498667
> 
> As reported in BugLink, this device has an issue with Linux Power Management so 
> adding a quirk.  This quirk was reccomended by Alan Stern:
> 
> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
> 
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> Cc: stable <stable@vger.kernel.org>
> 
> ---
>  drivers/usb/core/quirks.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 944a6dc..a33d003 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -198,6 +198,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	/* Protocol and OTG Electrical Test Device */
>  	{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
>  			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
> +
> +	/* ELAN Microelectronics Touchscreen */
> +	{ USB_DEVICE(0x04f3, 0x0381), .driver_info = USB_QUIRK_NO_LPM },

Please put this next to the other Elan touchscreen quirk entries, don't
put them in random order, it's a pain to maintain that way...

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad
  2016-07-06 23:10   ` Greg KH
@ 2016-07-07  0:24     ` Joseph Salisbury
  0 siblings, 0 replies; 4+ messages in thread
From: Joseph Salisbury @ 2016-07-07  0:24 UTC (permalink / raw)
  To: Greg KH
  Cc: hdegoede, adrienverge, yaowen, vpalatin, stern, linux-kernel,
	linux-usb, stable

On 07/06/2016 07:10 PM, Greg KH wrote:
> On Wed, Jul 06, 2016 at 05:53:47PM -0400, Joseph Salisbury wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1498667
>>
>> As reported in BugLink, this device has an issue with Linux Power Management so 
>> adding a quirk.  This quirk was reccomended by Alan Stern:
>>
>> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
>>
>> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
>> Cc: stable <stable@vger.kernel.org>
>>
>> ---
>>  drivers/usb/core/quirks.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index 944a6dc..a33d003 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -198,6 +198,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>>  	/* Protocol and OTG Electrical Test Device */
>>  	{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
>>  			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>> +
>> +	/* ELAN Microelectronics Touchscreen */
>> +	{ USB_DEVICE(0x04f3, 0x0381), .driver_info = USB_QUIRK_NO_LPM },
> Please put this next to the other Elan touchscreen quirk entries, don't
> put them in random order, it's a pain to maintain that way...
>
> thanks,
>
> greg k-h
Sorry, I grouped it with the other USB_QUIRK_NO_LPM entries.  I'll send
a V2 patch and make a note to group by manufacturer from now on.

Thanks,

Joe

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad
  2016-07-06 21:53 ` [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad Joseph Salisbury
  2016-07-06 23:10   ` Greg KH
@ 2016-07-08  1:05   ` Lu Baolu
  1 sibling, 0 replies; 4+ messages in thread
From: Lu Baolu @ 2016-07-08  1:05 UTC (permalink / raw)
  To: Joseph Salisbury, gregkh, hdegoede, adrienverge, yaowen, vpalatin, stern
  Cc: linux-kernel, linux-usb, stable

Hi,

On 07/07/2016 05:53 AM, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1498667
>
> As reported in BugLink, this device has an issue with Linux Power Management so 

s/"Linux Power Management"/"USB Link Power Management"

Best regards,
Lu Baolu

> adding a quirk.  This quirk was reccomended by Alan Stern:
>
> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> Cc: stable <stable@vger.kernel.org>
>
> ---
>  drivers/usb/core/quirks.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 944a6dc..a33d003 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -198,6 +198,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	/* Protocol and OTG Electrical Test Device */
>  	{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
>  			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
> +
> +	/* ELAN Microelectronics Touchscreen */
> +	{ USB_DEVICE(0x04f3, 0x0381), .driver_info = USB_QUIRK_NO_LPM },
>  
>  	/* Acer C120 LED Projector */
>  	{ USB_DEVICE(0x1de1, 0xc102), .driver_info = USB_QUIRK_NO_LPM },

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-08  1:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <cover.1467421035.git.joseph.salisbury@canonical.com>
2016-07-06 21:53 ` [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad Joseph Salisbury
2016-07-06 23:10   ` Greg KH
2016-07-07  0:24     ` Joseph Salisbury
2016-07-08  1:05   ` Lu Baolu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.