* [PATCH 1/1] ARM: add printf format attribute to early_print()
@ 2016-08-28 16:58 ` Nicolas Iooss
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Iooss @ 2016-08-28 16:58 UTC (permalink / raw)
To: Russell King, linux-arm-kernel; +Cc: linux-kernel, Nicolas Iooss
Adding such an attribute is helpful to detect errors related to printf
formats at compile-time.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
arch/arm/include/asm/setup.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h
index 3613d7e9fc40..797b8505b49a 100644
--- a/arch/arm/include/asm/setup.h
+++ b/arch/arm/include/asm/setup.h
@@ -22,7 +22,7 @@
static const struct tagtable __tagtable_##fn __tag = { tag, fn }
extern int arm_add_memory(u64 start, u64 size);
-extern void early_print(const char *str, ...);
+extern __printf(1, 2) void early_print(const char *str, ...);
extern void dump_machine_table(void);
#ifdef CONFIG_ATAGS_PROC
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 1/1] ARM: add printf format attribute to early_print()
@ 2016-08-28 16:58 ` Nicolas Iooss
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Iooss @ 2016-08-28 16:58 UTC (permalink / raw)
To: linux-arm-kernel
Adding such an attribute is helpful to detect errors related to printf
formats at compile-time.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
arch/arm/include/asm/setup.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h
index 3613d7e9fc40..797b8505b49a 100644
--- a/arch/arm/include/asm/setup.h
+++ b/arch/arm/include/asm/setup.h
@@ -22,7 +22,7 @@
static const struct tagtable __tagtable_##fn __tag = { tag, fn }
extern int arm_add_memory(u64 start, u64 size);
-extern void early_print(const char *str, ...);
+extern __printf(1, 2) void early_print(const char *str, ...);
extern void dump_machine_table(void);
#ifdef CONFIG_ATAGS_PROC
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] ARM: add printf format attribute to early_print()
2016-08-28 16:58 ` Nicolas Iooss
@ 2016-09-24 12:31 ` Nicolas Iooss
-1 siblings, 0 replies; 6+ messages in thread
From: Nicolas Iooss @ 2016-09-24 12:31 UTC (permalink / raw)
To: Russell King, linux-arm-kernel; +Cc: linux-kernel
On 28/08/16 18:58, Nicolas Iooss wrote:
> Adding such an attribute is helpful to detect errors related to printf
> formats at compile-time.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
> arch/arm/include/asm/setup.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h
> index 3613d7e9fc40..797b8505b49a 100644
> --- a/arch/arm/include/asm/setup.h
> +++ b/arch/arm/include/asm/setup.h
> @@ -22,7 +22,7 @@
> static const struct tagtable __tagtable_##fn __tag = { tag, fn }
>
> extern int arm_add_memory(u64 start, u64 size);
> -extern void early_print(const char *str, ...);
> +extern __printf(1, 2) void early_print(const char *str, ...);
> extern void dump_machine_table(void);
>
> #ifdef CONFIG_ATAGS_PROC
Hello,
I sent this patch a few weeks ago and got no reply (and nothing showed
up on https://patchwork.kernel.org/patch/9302825/). Could you please
consider it for 4.9?
Thanks,
Nicolas
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/1] ARM: add printf format attribute to early_print()
@ 2016-09-24 12:31 ` Nicolas Iooss
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Iooss @ 2016-09-24 12:31 UTC (permalink / raw)
To: linux-arm-kernel
On 28/08/16 18:58, Nicolas Iooss wrote:
> Adding such an attribute is helpful to detect errors related to printf
> formats at compile-time.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
> arch/arm/include/asm/setup.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h
> index 3613d7e9fc40..797b8505b49a 100644
> --- a/arch/arm/include/asm/setup.h
> +++ b/arch/arm/include/asm/setup.h
> @@ -22,7 +22,7 @@
> static const struct tagtable __tagtable_##fn __tag = { tag, fn }
>
> extern int arm_add_memory(u64 start, u64 size);
> -extern void early_print(const char *str, ...);
> +extern __printf(1, 2) void early_print(const char *str, ...);
> extern void dump_machine_table(void);
>
> #ifdef CONFIG_ATAGS_PROC
Hello,
I sent this patch a few weeks ago and got no reply (and nothing showed
up on https://patchwork.kernel.org/patch/9302825/). Could you please
consider it for 4.9?
Thanks,
Nicolas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] ARM: add printf format attribute to early_print()
2016-08-28 16:58 ` Nicolas Iooss
@ 2021-10-21 9:24 ` Geert Uytterhoeven
-1 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-10-21 9:24 UTC (permalink / raw)
To: Nicolas Iooss; +Cc: Russell King, Linux ARM, Linux Kernel Mailing List
On Sun, Aug 28, 2016 at 6:59 PM Nicolas Iooss
<nicolas.iooss_linux@m4x.org> wrote:
> Adding such an attribute is helpful to detect errors related to printf
> formats at compile-time.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
and submitted to rmk's patch tracker.
https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9147/1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] ARM: add printf format attribute to early_print()
@ 2021-10-21 9:24 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-10-21 9:24 UTC (permalink / raw)
To: Nicolas Iooss; +Cc: Russell King, Linux ARM, Linux Kernel Mailing List
On Sun, Aug 28, 2016 at 6:59 PM Nicolas Iooss
<nicolas.iooss_linux@m4x.org> wrote:
> Adding such an attribute is helpful to detect errors related to printf
> formats at compile-time.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
and submitted to rmk's patch tracker.
https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9147/1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-21 9:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-28 16:58 [PATCH 1/1] ARM: add printf format attribute to early_print() Nicolas Iooss
2016-08-28 16:58 ` Nicolas Iooss
2016-09-24 12:31 ` Nicolas Iooss
2016-09-24 12:31 ` Nicolas Iooss
2021-10-21 9:24 ` Geert Uytterhoeven
2021-10-21 9:24 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.