* [Qemu-devel] [PATCH] net: fix incorrect argument to iov_to_buf
@ 2016-07-15 8:41 Paolo Bonzini
2016-07-18 5:58 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2016-07-15 8:41 UTC (permalink / raw)
To: qemu-devel; +Cc: jasowang
Coverity reports a "suspicious sizeof" which is indeed wrong.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
net/eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/eth.c b/net/eth.c
index 95fe15c..0be59c2 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -418,7 +418,7 @@ _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int pkt_frags,
bytes_read = iov_to_buf(pkt, pkt_frags,
rthdr_offset + sizeof(*ext_hdr),
- dst_addr, sizeof(dst_addr));
+ dst_addr, sizeof(*dst_addr));
return bytes_read == sizeof(dst_addr);
}
@@ -467,7 +467,7 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, int pkt_frags,
bytes_read = iov_to_buf(pkt, pkt_frags,
opt_offset + sizeof(opthdr),
- src_addr, sizeof(src_addr));
+ src_addr, sizeof(*src_addr));
return bytes_read == sizeof(src_addr);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] net: fix incorrect argument to iov_to_buf
2016-07-15 8:41 [Qemu-devel] [PATCH] net: fix incorrect argument to iov_to_buf Paolo Bonzini
@ 2016-07-18 5:58 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2016-07-18 5:58 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 2016年07月15日 16:41, Paolo Bonzini wrote:
> Coverity reports a "suspicious sizeof" which is indeed wrong.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> net/eth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/eth.c b/net/eth.c
> index 95fe15c..0be59c2 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -418,7 +418,7 @@ _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int pkt_frags,
>
> bytes_read = iov_to_buf(pkt, pkt_frags,
> rthdr_offset + sizeof(*ext_hdr),
> - dst_addr, sizeof(dst_addr));
> + dst_addr, sizeof(*dst_addr));
>
> return bytes_read == sizeof(dst_addr);
> }
> @@ -467,7 +467,7 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, int pkt_frags,
>
> bytes_read = iov_to_buf(pkt, pkt_frags,
> opt_offset + sizeof(opthdr),
> - src_addr, sizeof(src_addr));
> + src_addr, sizeof(*src_addr));
>
> return bytes_read == sizeof(src_addr);
> }
Applied to -net. Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-18 5:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-15 8:41 [Qemu-devel] [PATCH] net: fix incorrect argument to iov_to_buf Paolo Bonzini
2016-07-18 5:58 ` Jason Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.