[Qemu-devel] [PATCH] e1000e: fix incorrect access to pointer

[Qemu-devel] [PATCH] e1000e: fix incorrect access to pointer

[Paolo Bonzini]

This is not dereferencing the pointer, and instead checking only
the value of the pointer.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/net/e1000e_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index 6050d8b..badb1fe 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -281,7 +281,7 @@ e1000e_intrmgr_delay_rx_causes(E1000ECore *core, uint32_t *causes)
 
     /* Check if delayed RX interrupts disabled by client
        or if there are causes that cannot be delayed */
-    if ((rdtr == 0) || (causes != 0)) {
+    if ((rdtr == 0) || (*causes != 0)) {
         return false;
     }
 
@@ -322,7 +322,7 @@ e1000e_intrmgr_delay_tx_causes(E1000ECore *core, uint32_t *causes)
     *causes &= ~delayable_causes;
 
     /* If there are causes that cannot be delayed */
-    if (causes != 0) {
+    if (*causes != 0) {
         return false;
     }
 
-- 
2.7.4

Re: [Qemu-devel] [PATCH] e1000e: fix incorrect access to pointer

[Jason Wang]

On 2016年07月15日 16:44, Paolo Bonzini wrote:
> This is not dereferencing the pointer, and instead checking only
> the value of the pointer.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hw/net/e1000e_core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
> index 6050d8b..badb1fe 100644
> --- a/hw/net/e1000e_core.c
> +++ b/hw/net/e1000e_core.c
> @@ -281,7 +281,7 @@ e1000e_intrmgr_delay_rx_causes(E1000ECore *core, uint32_t *causes)
>   
>       /* Check if delayed RX interrupts disabled by client
>          or if there are causes that cannot be delayed */
> -    if ((rdtr == 0) || (causes != 0)) {
> +    if ((rdtr == 0) || (*causes != 0)) {
>           return false;
>       }
>   
> @@ -322,7 +322,7 @@ e1000e_intrmgr_delay_tx_causes(E1000ECore *core, uint32_t *causes)
>       *causes &= ~delayable_causes;
>   
>       /* If there are causes that cannot be delayed */
> -    if (causes != 0) {
> +    if (*causes != 0) {
>           return false;
>       }
>   

Applied to -net. Thanks