* [PATCH] PCI: dra7xx: Fix return value in case of error
@ 2016-07-14 21:18 ` Christophe JAILLET
0 siblings, 0 replies; 9+ messages in thread
From: Christophe JAILLET @ 2016-07-14 21:18 UTC (permalink / raw)
To: kishon, bhelgaas
Cc: linux-omap, linux-pci, linux-kernel, kernel-janitors, Christophe JAILLET
In function 'dra7xx_pcie_init_irq_domain', the pattern used to check and
return error is:
if (!var) {
dev_err(...);
return PTR_ERR(var);
}
So the returned value in case of error is always 0, which means 'success'.
Change it to return -ENODEV instead.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/pci/host/pci-dra7xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
index f441130..81b3949 100644
--- a/drivers/pci/host/pci-dra7xx.c
+++ b/drivers/pci/host/pci-dra7xx.c
@@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
if (!pcie_intc_node) {
dev_err(dev, "No PCIe Intc node found\n");
- return PTR_ERR(pcie_intc_node);
+ return -ENODEV;
}
pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
&intx_domain_ops, pp);
if (!pp->irq_domain) {
dev_err(dev, "Failed to get a INTx IRQ domain\n");
- return PTR_ERR(pp->irq_domain);
+ return -ENODEV;
}
return 0;
--
2.7.4
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] PCI: dra7xx: Fix return value in case of error
@ 2016-07-14 21:18 ` Christophe JAILLET
0 siblings, 0 replies; 9+ messages in thread
From: Christophe JAILLET @ 2016-07-14 21:18 UTC (permalink / raw)
To: kishon, bhelgaas
Cc: linux-omap, linux-pci, linux-kernel, kernel-janitors, Christophe JAILLET
In function 'dra7xx_pcie_init_irq_domain', the pattern used to check and
return error is:
if (!var) {
dev_err(...);
return PTR_ERR(var);
}
So the returned value in case of error is always 0, which means 'success'.
Change it to return -ENODEV instead.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/pci/host/pci-dra7xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
index f441130..81b3949 100644
--- a/drivers/pci/host/pci-dra7xx.c
+++ b/drivers/pci/host/pci-dra7xx.c
@@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
if (!pcie_intc_node) {
dev_err(dev, "No PCIe Intc node found\n");
- return PTR_ERR(pcie_intc_node);
+ return -ENODEV;
}
pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
&intx_domain_ops, pp);
if (!pp->irq_domain) {
dev_err(dev, "Failed to get a INTx IRQ domain\n");
- return PTR_ERR(pp->irq_domain);
+ return -ENODEV;
}
return 0;
--
2.7.4
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] PCI: dra7xx: Fix return value in case of error
@ 2016-07-14 21:18 ` Christophe JAILLET
0 siblings, 0 replies; 9+ messages in thread
From: Christophe JAILLET @ 2016-07-14 21:18 UTC (permalink / raw)
To: kishon, bhelgaas
Cc: linux-omap, linux-pci, linux-kernel, kernel-janitors, Christophe JAILLET
In function 'dra7xx_pcie_init_irq_domain', the pattern used to check and
return error is:
if (!var) {
dev_err(...);
return PTR_ERR(var);
}
So the returned value in case of error is always 0, which means 'success'.
Change it to return -ENODEV instead.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/pci/host/pci-dra7xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
index f441130..81b3949 100644
--- a/drivers/pci/host/pci-dra7xx.c
+++ b/drivers/pci/host/pci-dra7xx.c
@@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
if (!pcie_intc_node) {
dev_err(dev, "No PCIe Intc node found\n");
- return PTR_ERR(pcie_intc_node);
+ return -ENODEV;
}
pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
&intx_domain_ops, pp);
if (!pp->irq_domain) {
dev_err(dev, "Failed to get a INTx IRQ domain\n");
- return PTR_ERR(pp->irq_domain);
+ return -ENODEV;
}
return 0;
--
2.7.4
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] PCI: dra7xx: Fix return value in case of error
2016-07-14 21:18 ` Christophe JAILLET
(?)
@ 2016-07-18 6:29 ` Kishon Vijay Abraham I
-1 siblings, 0 replies; 9+ messages in thread
From: Kishon Vijay Abraham I @ 2016-07-18 6:29 UTC (permalink / raw)
To: Christophe JAILLET, bhelgaas
Cc: linux-omap, linux-pci, linux-kernel, kernel-janitors
On Friday 15 July 2016 02:48 AM, Christophe JAILLET wrote:
> In function 'dra7xx_pcie_init_irq_domain', the pattern used to check and
> return error is:
>
> if (!var) {
> dev_err(...);
> return PTR_ERR(var);
> }
>
> So the returned value in case of error is always 0, which means 'success'.
> Change it to return -ENODEV instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/pci/host/pci-dra7xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index f441130..81b3949 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
>
> if (!pcie_intc_node) {
> dev_err(dev, "No PCIe Intc node found\n");
> - return PTR_ERR(pcie_intc_node);
> + return -ENODEV;
> }
>
> pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
> &intx_domain_ops, pp);
> if (!pp->irq_domain) {
> dev_err(dev, "Failed to get a INTx IRQ domain\n");
> - return PTR_ERR(pp->irq_domain);
> + return -ENODEV;
> }
>
> return 0;
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] PCI: dra7xx: Fix return value in case of error
@ 2016-07-18 6:29 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 9+ messages in thread
From: Kishon Vijay Abraham I @ 2016-07-18 6:29 UTC (permalink / raw)
To: Christophe JAILLET, bhelgaas
Cc: linux-omap, linux-pci, linux-kernel, kernel-janitors
On Friday 15 July 2016 02:48 AM, Christophe JAILLET wrote:
> In function 'dra7xx_pcie_init_irq_domain', the pattern used to check and
> return error is:
>
> if (!var) {
> dev_err(...);
> return PTR_ERR(var);
> }
>
> So the returned value in case of error is always 0, which means 'success'.
> Change it to return -ENODEV instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/pci/host/pci-dra7xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index f441130..81b3949 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
>
> if (!pcie_intc_node) {
> dev_err(dev, "No PCIe Intc node found\n");
> - return PTR_ERR(pcie_intc_node);
> + return -ENODEV;
> }
>
> pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
> &intx_domain_ops, pp);
> if (!pp->irq_domain) {
> dev_err(dev, "Failed to get a INTx IRQ domain\n");
> - return PTR_ERR(pp->irq_domain);
> + return -ENODEV;
> }
>
> return 0;
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] PCI: dra7xx: Fix return value in case of error
@ 2016-07-18 6:29 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 9+ messages in thread
From: Kishon Vijay Abraham I @ 2016-07-18 6:41 UTC (permalink / raw)
To: Christophe JAILLET, bhelgaas
Cc: linux-omap, linux-pci, linux-kernel, kernel-janitors
On Friday 15 July 2016 02:48 AM, Christophe JAILLET wrote:
> In function 'dra7xx_pcie_init_irq_domain', the pattern used to check and
> return error is:
>
> if (!var) {
> dev_err(...);
> return PTR_ERR(var);
> }
>
> So the returned value in case of error is always 0, which means 'success'.
> Change it to return -ENODEV instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/pci/host/pci-dra7xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index f441130..81b3949 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
>
> if (!pcie_intc_node) {
> dev_err(dev, "No PCIe Intc node found\n");
> - return PTR_ERR(pcie_intc_node);
> + return -ENODEV;
> }
>
> pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
> &intx_domain_ops, pp);
> if (!pp->irq_domain) {
> dev_err(dev, "Failed to get a INTx IRQ domain\n");
> - return PTR_ERR(pp->irq_domain);
> + return -ENODEV;
> }
>
> return 0;
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] PCI: dra7xx: Fix return value in case of error
2016-07-14 21:18 ` Christophe JAILLET
(?)
@ 2016-07-25 17:30 ` Bjorn Helgaas
-1 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2016-07-25 17:30 UTC (permalink / raw)
To: Christophe JAILLET
Cc: kishon, bhelgaas, linux-omap, linux-pci, linux-kernel, kernel-janitors
On Thu, Jul 14, 2016 at 11:18:27PM +0200, Christophe JAILLET wrote:
> In function 'dra7xx_pcie_init_irq_domain', the pattern used to check and
> return error is:
>
> if (!var) {
> dev_err(...);
> return PTR_ERR(var);
> }
>
> So the returned value in case of error is always 0, which means 'success'.
> Change it to return -ENODEV instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied with Kishon's reviewed-by to pci/host-dra7xx for v4.8, thanks!
> ---
> drivers/pci/host/pci-dra7xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index f441130..81b3949 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
>
> if (!pcie_intc_node) {
> dev_err(dev, "No PCIe Intc node found\n");
> - return PTR_ERR(pcie_intc_node);
> + return -ENODEV;
> }
>
> pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
> &intx_domain_ops, pp);
> if (!pp->irq_domain) {
> dev_err(dev, "Failed to get a INTx IRQ domain\n");
> - return PTR_ERR(pp->irq_domain);
> + return -ENODEV;
> }
>
> return 0;
> --
> 2.7.4
>
>
> ---
> L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
> https://www.avast.com/antivirus
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] PCI: dra7xx: Fix return value in case of error
@ 2016-07-25 17:30 ` Bjorn Helgaas
0 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2016-07-25 17:30 UTC (permalink / raw)
To: Christophe JAILLET
Cc: kishon, bhelgaas, linux-omap, linux-pci, linux-kernel, kernel-janitors
On Thu, Jul 14, 2016 at 11:18:27PM +0200, Christophe JAILLET wrote:
> In function 'dra7xx_pcie_init_irq_domain', the pattern used to check and
> return error is:
>
> if (!var) {
> dev_err(...);
> return PTR_ERR(var);
> }
>
> So the returned value in case of error is always 0, which means 'success'.
> Change it to return -ENODEV instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied with Kishon's reviewed-by to pci/host-dra7xx for v4.8, thanks!
> ---
> drivers/pci/host/pci-dra7xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index f441130..81b3949 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
>
> if (!pcie_intc_node) {
> dev_err(dev, "No PCIe Intc node found\n");
> - return PTR_ERR(pcie_intc_node);
> + return -ENODEV;
> }
>
> pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
> &intx_domain_ops, pp);
> if (!pp->irq_domain) {
> dev_err(dev, "Failed to get a INTx IRQ domain\n");
> - return PTR_ERR(pp->irq_domain);
> + return -ENODEV;
> }
>
> return 0;
> --
> 2.7.4
>
>
> ---
> L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
> https://www.avast.com/antivirus
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] PCI: dra7xx: Fix return value in case of error
@ 2016-07-25 17:30 ` Bjorn Helgaas
0 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2016-07-25 17:30 UTC (permalink / raw)
To: Christophe JAILLET
Cc: kishon, bhelgaas, linux-omap, linux-pci, linux-kernel, kernel-janitors
On Thu, Jul 14, 2016 at 11:18:27PM +0200, Christophe JAILLET wrote:
> In function 'dra7xx_pcie_init_irq_domain', the pattern used to check and
> return error is:
>
> if (!var) {
> dev_err(...);
> return PTR_ERR(var);
> }
>
> So the returned value in case of error is always 0, which means 'success'.
> Change it to return -ENODEV instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied with Kishon's reviewed-by to pci/host-dra7xx for v4.8, thanks!
> ---
> drivers/pci/host/pci-dra7xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index f441130..81b3949 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
>
> if (!pcie_intc_node) {
> dev_err(dev, "No PCIe Intc node found\n");
> - return PTR_ERR(pcie_intc_node);
> + return -ENODEV;
> }
>
> pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
> &intx_domain_ops, pp);
> if (!pp->irq_domain) {
> dev_err(dev, "Failed to get a INTx IRQ domain\n");
> - return PTR_ERR(pp->irq_domain);
> + return -ENODEV;
> }
>
> return 0;
> --
> 2.7.4
>
>
> ---
> L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
> https://www.avast.com/antivirus
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-07-25 17:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-14 21:18 [PATCH] PCI: dra7xx: Fix return value in case of error Christophe JAILLET
2016-07-14 21:18 ` Christophe JAILLET
2016-07-14 21:18 ` Christophe JAILLET
2016-07-18 6:29 ` Kishon Vijay Abraham I
2016-07-18 6:41 ` Kishon Vijay Abraham I
2016-07-18 6:29 ` Kishon Vijay Abraham I
2016-07-25 17:30 ` Bjorn Helgaas
2016-07-25 17:30 ` Bjorn Helgaas
2016-07-25 17:30 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.