All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Hoan Tran <hotran@apm.com>, Jean Delvare <jdelvare@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Rob Herring <robh+dt@kernel.org>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
	Ashwin Chaugule <ashwin.chaugule@linaro.org>,
	Duc Dang <dhdang@apm.com>,
	lho@apm.com, linux-hwmon@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 0/3] hwmon: xgene: Add support for X-Gene hwmon driver
Date: Thu, 21 Jul 2016 18:30:52 -0700	[thread overview]
Message-ID: <5791774C.4010804@roeck-us.net> (raw)
In-Reply-To: <1469140653-2287-1-git-send-email-hotran@apm.com>

On 07/21/2016 03:37 PM, Hoan Tran wrote:
> This patch set adds hardware temperature and power reading support for
> APM X-Gene SoC using the mailbox communication interface.
> For device tree, it is the standard DT mailbox.
> For ACPI, it is the PCC mailbox.
>
> For ACPI, this patch is built on top and depends on patch[1]:
> [1] http://www.spinics.net/lists/linux-acpi/msg66041.html
>   - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2
>

One thought: You might consider taking ACPI support out of the driver for now,
and add it back in after the dependent patch was accepted.

Guenter

> v4
>   - Return 0 if driver registers successfully
>
> v3
>   - Order include files alphabetically
>   - Use sign_extend32() to decode temperature
>   - Use DEVICE_ATTR_RO() for temperature and power attributes
>   - Temperature and power attributes start with index 1
>   - Use !!amsg->param2
>   - Fix checkpatch WARNING with --strict flag
>   - Use hwmon_device_register_with_groups()
>   - Check invalid sensor data
>
> v2
>   - Increase power reading accurateness by using 2 registers
> (a register for Watt, another for milli-Watt)
>   - Remove power reading for SoC
>   - Fix review comments from Guenter
>
> v1
>   - Initial
>
> Hoan Tran (3):
>    Documentation: dtb: xgene: Add hwmon dts binding documentation
>    hwmon: xgene: Add hwmon driver
>    arm64: dts: apm: Add X-Gene SoC hwmon to device tree
>
>   .../devicetree/bindings/hwmon/apm-xgene-hwmon.txt  |  14 +
>   Documentation/hwmon/xgene-hwmon                    |  30 +
>   arch/arm64/boot/dts/apm/apm-shadowcat.dtsi         |   5 +
>   arch/arm64/boot/dts/apm/apm-storm.dtsi             |   5 +
>   drivers/hwmon/Kconfig                              |   7 +
>   drivers/hwmon/Makefile                             |   1 +
>   drivers/hwmon/xgene-hwmon.c                        | 755 +++++++++++++++++++++
>   7 files changed, 817 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
>   create mode 100644 Documentation/hwmon/xgene-hwmon
>   create mode 100644 drivers/hwmon/xgene-hwmon.c
>


WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/3] hwmon: xgene: Add support for X-Gene hwmon driver
Date: Thu, 21 Jul 2016 18:30:52 -0700	[thread overview]
Message-ID: <5791774C.4010804@roeck-us.net> (raw)
In-Reply-To: <1469140653-2287-1-git-send-email-hotran@apm.com>

On 07/21/2016 03:37 PM, Hoan Tran wrote:
> This patch set adds hardware temperature and power reading support for
> APM X-Gene SoC using the mailbox communication interface.
> For device tree, it is the standard DT mailbox.
> For ACPI, it is the PCC mailbox.
>
> For ACPI, this patch is built on top and depends on patch[1]:
> [1] http://www.spinics.net/lists/linux-acpi/msg66041.html
>   - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2
>

One thought: You might consider taking ACPI support out of the driver for now,
and add it back in after the dependent patch was accepted.

Guenter

> v4
>   - Return 0 if driver registers successfully
>
> v3
>   - Order include files alphabetically
>   - Use sign_extend32() to decode temperature
>   - Use DEVICE_ATTR_RO() for temperature and power attributes
>   - Temperature and power attributes start with index 1
>   - Use !!amsg->param2
>   - Fix checkpatch WARNING with --strict flag
>   - Use hwmon_device_register_with_groups()
>   - Check invalid sensor data
>
> v2
>   - Increase power reading accurateness by using 2 registers
> (a register for Watt, another for milli-Watt)
>   - Remove power reading for SoC
>   - Fix review comments from Guenter
>
> v1
>   - Initial
>
> Hoan Tran (3):
>    Documentation: dtb: xgene: Add hwmon dts binding documentation
>    hwmon: xgene: Add hwmon driver
>    arm64: dts: apm: Add X-Gene SoC hwmon to device tree
>
>   .../devicetree/bindings/hwmon/apm-xgene-hwmon.txt  |  14 +
>   Documentation/hwmon/xgene-hwmon                    |  30 +
>   arch/arm64/boot/dts/apm/apm-shadowcat.dtsi         |   5 +
>   arch/arm64/boot/dts/apm/apm-storm.dtsi             |   5 +
>   drivers/hwmon/Kconfig                              |   7 +
>   drivers/hwmon/Makefile                             |   1 +
>   drivers/hwmon/xgene-hwmon.c                        | 755 +++++++++++++++++++++
>   7 files changed, 817 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
>   create mode 100644 Documentation/hwmon/xgene-hwmon
>   create mode 100644 drivers/hwmon/xgene-hwmon.c
>

  parent reply	other threads:[~2016-07-22  1:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21 22:37 [PATCH v4 0/3] hwmon: xgene: Add support for X-Gene hwmon driver Hoan Tran
2016-07-21 22:37 ` Hoan Tran
2016-07-21 22:37 ` [PATCH v4 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation Hoan Tran
2016-07-21 22:37   ` Hoan Tran
2016-07-21 22:37 ` [PATCH v4 2/3] hwmon: xgene: Add hwmon driver Hoan Tran
2016-07-21 22:37   ` Hoan Tran
2016-07-21 22:37 ` [PATCH v4 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree Hoan Tran
2016-07-21 22:37   ` Hoan Tran
2016-07-22  1:30 ` Guenter Roeck [this message]
2016-07-22  1:30   ` [PATCH v4 0/3] hwmon: xgene: Add support for X-Gene hwmon driver Guenter Roeck
2016-07-22 16:27   ` Hoan Tran
2016-07-22 16:27     ` Hoan Tran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5791774C.4010804@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=ashwin.chaugule@linaro.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dhdang@apm.com \
    --cc=hotran@apm.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=lho@apm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.