From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Rob Herring <robh@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Richard Purdie <rpurdie@rpsys.net>,
drivshin.allworx@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
kernel@pyra-handheld.com, marek@goldelico.com,
letux-kernel@openphoenux.org,
Andrey Utkin <andrey_utkin@fastmail.com>
Subject: Re: [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver
Date: Fri, 22 Jul 2016 09:12:02 +0200 [thread overview]
Message-ID: <5791C742.2070308@samsung.com> (raw)
In-Reply-To: <09C8D3C3-0CA9-48EB-B7B1-FCADAB2BA23A@goldelico.com>
On 07/22/2016 08:42 AM, H. Nikolaus Schaller wrote:
> Hi,
>
>> Am 22.07.2016 um 08:36 schrieb Jacek Anaszewski <j.anaszewski@samsung.com>:
>>
>> On 07/20/2016 03:24 AM, Rob Herring wrote:
>>> On Tue, Jul 19, 2016 at 01:47:31PM +0200, H. Nikolaus Schaller wrote:
>>>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>>>> ---
>>>> .../devicetree/bindings/leds/is31fl319x.txt | 59 ++++++++++++++++++++++
>>>> 1 file changed, 59 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/leds/is31fl319x.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/leds/is31fl319x.txt b/Documentation/devicetree/bindings/leds/is31fl319x.txt
>>>> new file mode 100644
>>>> index 0000000..03287c0
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/leds/is31fl319x.txt
>>>> @@ -0,0 +1,59 @@
>>>> +LEDs connected to is31fl319x LED controller chip
>>>> +
>>>> +Required properties:
>>>> +- compatible : Should be any of
>>>> + "issi,is31fl3190"
>>>> + "issi,is31fl3191"
>>>> + "issi,is31fl3193"
>>>> + "issi,is31fl3196"
>>>> + "issi,is31fl3199"
>>>> + "si-en,sn3199".
>>>> +- #address-cells: Must be 1.
>>>> +- #size-cells: Must be 0.
>>>> +- reg: 0x64, 0x65, 0x66, 0x67.
>>>
>>> This is an OR or AND? OR it seems. With that,
>>
>> Nikolaus, could you please make it explicit?
>
> Yes, Rob's intuition is right. An AND does
> obviously not make sense for a reg property.
>
> It is an OR.
>
> So if you perfer, please substitute
>
> - reg: 0x64, 0x65, 0x66, or 0x67.
Updated the for-4.9 branch accordingly. I also added "led-" prefix
to the file name to match it with the vast majority of the
remaining ones.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2016-07-22 7:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 11:47 [PATCH v6 0/2] driver: leds: is31fl319x dimmable LED driver H. Nikolaus Schaller
2016-07-19 11:47 ` [PATCH v6 1/2] led: is31fl319x: 1/3/6/9-channel light effect led driver H. Nikolaus Schaller
2016-07-19 12:29 ` Jacek Anaszewski
2016-07-19 12:34 ` H. Nikolaus Schaller
2016-07-19 11:47 ` [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver H. Nikolaus Schaller
2016-07-20 1:24 ` Rob Herring
2016-07-22 6:36 ` Jacek Anaszewski
2016-07-22 6:42 ` H. Nikolaus Schaller
2016-07-22 7:12 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5791C742.2070308@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=andrey_utkin@fastmail.com \
--cc=devicetree@vger.kernel.org \
--cc=drivshin.allworx@gmail.com \
--cc=galak@codeaurora.org \
--cc=hns@goldelico.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.