All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	drivshin.allworx@gmail.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org, kernel@pyra-handheld.com,
	marek@goldelico.com, letux-kernel@openphoenux.org,
	Andrey Utkin <andrey_utkin@fastmail.com>
Subject: [PATCH v6 0/2] driver: leds: is31fl319x dimmable LED driver
Date: Tue, 19 Jul 2016 13:47:29 +0200	[thread overview]
Message-ID: <cover.1468928850.git.hns@goldelico.com> (raw)

Changes V6 suggested by Jacek Anaszewski:
* indentation/tab of macro values
* use inline for some helper functions
* define constant 12 (CS reference point) as semantic macro

2016-07-19 11:40:07: Changes V5 suggested by Jacek Anaszewski:
* update macros/function for audio gain
* mention PWM in bindings

2016-07-19 10:03:40: Changes V4 (mostly fixed by Andrey Utkin):
* Fix struct is31fl319x_driver alignment
* Rework chip matching as suggested by Jacek Anaszewski
* Enhance macro-constants names
* Traverse cdef.num_leds, not MAX_LEDS
* Fix some checkpatch --strict notices
* Fixup for MAX_LEDS -> cdef->num_leds
* Fix lots of review notices
    - macrodef for bits shift
     - drop dev_err() on parse_dt() fail (thus inside parse_dt() every
       failure must give a proper message)
     - of_node_put() where needed
     - rework is31fl319x_microamp_to_cs()
     - destroy mutex properly
* remove note that it is based on tca6507 driver (has deviated completely) (fixed by hns)
* reject if any led current < current_min (fixed by hns)
* simplify helper function is31fl319x_microamp_to_cs and round down (fixed by hns)
* Drop extra empty line in Documentation/devicetree/bindings/leds/is31fl319x.txt
* remove led-max-microamps global property in bindings documentation (fixed by hns)

2016-07-08 21:49:42: Changes V3 (mostly done by Andrey Utkin):
* general coding style improvements
* added a mutex to properly serialize multiple calls to set_backlight
* use regmap defaults (suggested by Jacek Anaszewski)
* improve DT parsing (suggested by Jacek Anaszewski)
* define dependency on REGMAP_I2C
* minor code improvements

2016-07-06 12:02:47: Changes V2:
* suggested by David Rivshin
	* add more "compatible" strings for other chip variants/brands
	* renumber output <reg> values to expect a range of 1..9
	* fixes for typos and DT example, Kconfig message
	* fix location in Makefile and Kconfig
	* remove some dead/not implemented code
	* use of_property_read_string for better error handling
	* coding style improvements
	* use devm_led_classdev_register and simplify error path
* suggested by Jacek Anaszewski
	* fix more typos & writing style
	* separate bindings document into a second patch
	* max current property renamed and define uA instead of mA
	* debugging message improvements
	* remove platform data and header file completely and therefore require DT
	* use regmap to handle caching and locking + i2c serialization
* suggested by Rob Herring
	* bindings documentation style improvements

V1: 2016-04-18 20:43:18:
This patch adds a driver for the is31fl3196/99 dimmable dual/triple rgb
controller chips from ISSI.

H. Nikolaus Schaller (2):
  led: is31fl319x: 1/3/6/9-channel light effect led driver
  Bindings documentation for ISSI is31fl319x driver

 .../devicetree/bindings/leds/is31fl319x.txt        |  59 +++
 drivers/leds/Kconfig                               |  12 +
 drivers/leds/Makefile                              |   1 +
 drivers/leds/leds-is31fl319x.c                     | 450 +++++++++++++++++++++
 4 files changed, 522 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/is31fl319x.txt
 create mode 100644 drivers/leds/leds-is31fl319x.c

-- 
2.7.3

             reply	other threads:[~2016-07-19 11:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 11:47 H. Nikolaus Schaller [this message]
2016-07-19 11:47 ` [PATCH v6 1/2] led: is31fl319x: 1/3/6/9-channel light effect led driver H. Nikolaus Schaller
2016-07-19 12:29   ` Jacek Anaszewski
2016-07-19 12:34     ` H. Nikolaus Schaller
2016-07-19 11:47 ` [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver H. Nikolaus Schaller
2016-07-20  1:24   ` Rob Herring
2016-07-22  6:36     ` Jacek Anaszewski
2016-07-22  6:42       ` H. Nikolaus Schaller
2016-07-22  7:12         ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1468928850.git.hns@goldelico.com \
    --to=hns@goldelico.com \
    --cc=andrey_utkin@fastmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drivshin.allworx@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=j.anaszewski@samsung.com \
    --cc=kernel@pyra-handheld.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=marek@goldelico.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.