* [PATCH v3a] regulator: core: avoid unused variable warning
@ 2015-11-20 14:23 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2015-11-20 14:23 UTC (permalink / raw)
To: Mark Brown
Cc: Sascha Hauer, Liam Girdwood, linux-kernel, linux-arm-kernel,
Peter Zijlstra, Ingo Molnar
The second argument of the mutex_lock_nested() helper is only
evaluated if CONFIG_DEBUG_LOCK_ALLOC is set. Otherwise we
get this build warning for the new regulator_lock_supply
function:
drivers/regulator/core.c: In function 'regulator_lock_supply':
drivers/regulator/core.c:142:6: warning: unused variable 'i' [-Wunused-variable]
To avoid the warning, this patch moves the postincrement outside
of the call mutex_lock_nested(), which is enough to shut up
gcc about it.
We had some discussion about changing mutex_lock_nested to an
inline function, which would make the code do the right thing here,
but in the end decided against it, in order to guarantee that
mutex_lock_nested() does not introduced overhead without
CONFIG_DEBUG_LOCK_ALLOC.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 9f01cd4a915 ("regulator: core: introduce function to lock regulators and its supplies")
Link: http://permalink.gmane.org/gmane.linux.kernel/2068900
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 4cf1390784e5..5afe02cce9aa 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -142,7 +142,11 @@ static void regulator_lock_supply(struct regulator_dev *rdev)
int i = 0;
while (1) {
- mutex_lock_nested(&rdev->mutex, i++);
+ mutex_lock_nested(&rdev->mutex, i);
+
+ /* avoid unused variable warning without DEBUG_LOCK_ALLOC */
+ (void)i++;
+
supply = rdev->supply;
if (!rdev->supply)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v3a] regulator: core: avoid unused variable warning
@ 2015-11-20 14:23 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2015-11-20 14:23 UTC (permalink / raw)
To: linux-arm-kernel
The second argument of the mutex_lock_nested() helper is only
evaluated if CONFIG_DEBUG_LOCK_ALLOC is set. Otherwise we
get this build warning for the new regulator_lock_supply
function:
drivers/regulator/core.c: In function 'regulator_lock_supply':
drivers/regulator/core.c:142:6: warning: unused variable 'i' [-Wunused-variable]
To avoid the warning, this patch moves the postincrement outside
of the call mutex_lock_nested(), which is enough to shut up
gcc about it.
We had some discussion about changing mutex_lock_nested to an
inline function, which would make the code do the right thing here,
but in the end decided against it, in order to guarantee that
mutex_lock_nested() does not introduced overhead without
CONFIG_DEBUG_LOCK_ALLOC.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 9f01cd4a915 ("regulator: core: introduce function to lock regulators and its supplies")
Link: http://permalink.gmane.org/gmane.linux.kernel/2068900
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 4cf1390784e5..5afe02cce9aa 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -142,7 +142,11 @@ static void regulator_lock_supply(struct regulator_dev *rdev)
int i = 0;
while (1) {
- mutex_lock_nested(&rdev->mutex, i++);
+ mutex_lock_nested(&rdev->mutex, i);
+
+ /* avoid unused variable warning without DEBUG_LOCK_ALLOC */
+ (void)i++;
+
supply = rdev->supply;
if (!rdev->supply)
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-20 14:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-20 14:23 [PATCH v3a] regulator: core: avoid unused variable warning Arnd Bergmann
2015-11-20 14:23 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.