* [PATCH] drm: mxsfb: Check NULL pointer
@ 2021-11-03 7:48 ` Jiasheng Jiang
0 siblings, 0 replies; 6+ messages in thread
From: Jiasheng Jiang @ 2021-11-03 7:48 UTC (permalink / raw)
To: marex, stefan, airlied, daniel, shawnguo, s.hauer, kernel,
festevam, linux-imx
Cc: dri-devel, linux-arm-kernel, linux-kernel, Jiasheng Jiang
As we see in the drm_connector_list_iter_next(), it could return
NULL. In order to avoid the use of the NULL pointer, it may be
better to check the return value.
Fixes: c42001e ("drm: mxsfb: Use drm_panel_bridge")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 6da9355..b875c11 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -145,6 +145,8 @@ static int mxsfb_attach_bridge(struct mxsfb_drm_private *mxsfb)
*/
drm_connector_list_iter_begin(drm, &iter);
mxsfb->connector = drm_connector_list_iter_next(&iter);
+ if (!mxsfb->connector)
+ return 1;
drm_connector_list_iter_end(&iter);
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm: mxsfb: Check NULL pointer
@ 2021-11-03 7:48 ` Jiasheng Jiang
0 siblings, 0 replies; 6+ messages in thread
From: Jiasheng Jiang @ 2021-11-03 7:48 UTC (permalink / raw)
To: marex, stefan, airlied, daniel, shawnguo, s.hauer, kernel,
festevam, linux-imx
Cc: dri-devel, linux-arm-kernel, linux-kernel, Jiasheng Jiang
As we see in the drm_connector_list_iter_next(), it could return
NULL. In order to avoid the use of the NULL pointer, it may be
better to check the return value.
Fixes: c42001e ("drm: mxsfb: Use drm_panel_bridge")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 6da9355..b875c11 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -145,6 +145,8 @@ static int mxsfb_attach_bridge(struct mxsfb_drm_private *mxsfb)
*/
drm_connector_list_iter_begin(drm, &iter);
mxsfb->connector = drm_connector_list_iter_next(&iter);
+ if (!mxsfb->connector)
+ return 1;
drm_connector_list_iter_end(&iter);
return 0;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm: mxsfb: Check NULL pointer
@ 2021-11-03 7:48 ` Jiasheng Jiang
0 siblings, 0 replies; 6+ messages in thread
From: Jiasheng Jiang @ 2021-11-03 7:48 UTC (permalink / raw)
To: marex, stefan, airlied, daniel, shawnguo, s.hauer, kernel,
festevam, linux-imx
Cc: Jiasheng Jiang, linux-arm-kernel, dri-devel, linux-kernel
As we see in the drm_connector_list_iter_next(), it could return
NULL. In order to avoid the use of the NULL pointer, it may be
better to check the return value.
Fixes: c42001e ("drm: mxsfb: Use drm_panel_bridge")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 6da9355..b875c11 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -145,6 +145,8 @@ static int mxsfb_attach_bridge(struct mxsfb_drm_private *mxsfb)
*/
drm_connector_list_iter_begin(drm, &iter);
mxsfb->connector = drm_connector_list_iter_next(&iter);
+ if (!mxsfb->connector)
+ return 1;
drm_connector_list_iter_end(&iter);
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: mxsfb: Check NULL pointer
2021-11-03 7:48 ` Jiasheng Jiang
(?)
@ 2021-11-03 7:58 ` Marek Vasut
-1 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2021-11-03 7:58 UTC (permalink / raw)
To: Jiasheng Jiang, stefan, airlied, daniel, shawnguo, s.hauer,
kernel, festevam, linux-imx
Cc: dri-devel, linux-arm-kernel, linux-kernel
On 11/3/21 8:48 AM, Jiasheng Jiang wrote:
> As we see in the drm_connector_list_iter_next(), it could return
> NULL. In order to avoid the use of the NULL pointer, it may be
> better to check the return value.
>
> Fixes: c42001e ("drm: mxsfb: Use drm_panel_bridge")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index 6da9355..b875c11 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -145,6 +145,8 @@ static int mxsfb_attach_bridge(struct mxsfb_drm_private *mxsfb)
> */
> drm_connector_list_iter_begin(drm, &iter);
> mxsfb->connector = drm_connector_list_iter_next(&iter);
> + if (!mxsfb->connector)
> + return 1;
In which case does this happen failure happen ?
What is the test case ?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: mxsfb: Check NULL pointer
@ 2021-11-03 7:58 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2021-11-03 7:58 UTC (permalink / raw)
To: Jiasheng Jiang, stefan, airlied, daniel, shawnguo, s.hauer,
kernel, festevam, linux-imx
Cc: linux-arm-kernel, dri-devel, linux-kernel
On 11/3/21 8:48 AM, Jiasheng Jiang wrote:
> As we see in the drm_connector_list_iter_next(), it could return
> NULL. In order to avoid the use of the NULL pointer, it may be
> better to check the return value.
>
> Fixes: c42001e ("drm: mxsfb: Use drm_panel_bridge")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index 6da9355..b875c11 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -145,6 +145,8 @@ static int mxsfb_attach_bridge(struct mxsfb_drm_private *mxsfb)
> */
> drm_connector_list_iter_begin(drm, &iter);
> mxsfb->connector = drm_connector_list_iter_next(&iter);
> + if (!mxsfb->connector)
> + return 1;
In which case does this happen failure happen ?
What is the test case ?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: mxsfb: Check NULL pointer
@ 2021-11-03 7:58 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2021-11-03 7:58 UTC (permalink / raw)
To: Jiasheng Jiang, stefan, airlied, daniel, shawnguo, s.hauer,
kernel, festevam, linux-imx
Cc: dri-devel, linux-arm-kernel, linux-kernel
On 11/3/21 8:48 AM, Jiasheng Jiang wrote:
> As we see in the drm_connector_list_iter_next(), it could return
> NULL. In order to avoid the use of the NULL pointer, it may be
> better to check the return value.
>
> Fixes: c42001e ("drm: mxsfb: Use drm_panel_bridge")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index 6da9355..b875c11 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -145,6 +145,8 @@ static int mxsfb_attach_bridge(struct mxsfb_drm_private *mxsfb)
> */
> drm_connector_list_iter_begin(drm, &iter);
> mxsfb->connector = drm_connector_list_iter_next(&iter);
> + if (!mxsfb->connector)
> + return 1;
In which case does this happen failure happen ?
What is the test case ?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-03 8:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 7:48 [PATCH] drm: mxsfb: Check NULL pointer Jiasheng Jiang
2021-11-03 7:48 ` Jiasheng Jiang
2021-11-03 7:48 ` Jiasheng Jiang
2021-11-03 7:58 ` Marek Vasut
2021-11-03 7:58 ` Marek Vasut
2021-11-03 7:58 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.