From: David Daney <ddaney@caviumnetworks.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jan Glauber <jglauber@cavium.com>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>, David Daney <david.daney@cavium.com>,
"Steven J . Hill" <steven.hill@cavium.com>
Subject: Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver
Date: Mon, 1 Aug 2016 12:02:54 -0700 [thread overview]
Message-ID: <579F9CDE.5050207@caviumnetworks.com> (raw)
In-Reply-To: <20160801184931.GB10376@sirena.org.uk>
On 08/01/2016 11:49 AM, Mark Brown wrote:
> On Mon, Aug 01, 2016 at 11:31:43AM -0700, David Daney wrote:
>> On 08/01/2016 10:28 AM, Mark Brown wrote:
>>> On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote:
>
>>>> + p->clk = devm_clk_get(dev, NULL);
>>>> + if (IS_ERR(p->clk))
>>>> + goto out_unmap;
>
>>> We're now just using the normal clock API which is good but I'm now
>>> unclear what is going to ensure that the clock is there - is there some
>>> other change elsewhere that I'm not aware of?
>
>> The clock is an integral part of the SoC and is always running, so it will
>> always be there. All we want to know is the frequency, which is supplied by
>> the device tree clock-bindings framework
>
> So there's something there that registers the clock?
Yes, when using OF device tree, standard device probing registers the clock.
> What is that thing on ACPI systems?
I don't know if it works ACPI, or if ACPI even has support for the clock
framework. But does it matter? We are not currently using ACPI on
systems where this driver is used.
In the future, if we ever need ACPI support, we will add support for it.
David.
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jan Glauber <jglauber-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
"Steven J . Hill"
<steven.hill-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver
Date: Mon, 1 Aug 2016 12:02:54 -0700 [thread overview]
Message-ID: <579F9CDE.5050207@caviumnetworks.com> (raw)
In-Reply-To: <20160801184931.GB10376-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 08/01/2016 11:49 AM, Mark Brown wrote:
> On Mon, Aug 01, 2016 at 11:31:43AM -0700, David Daney wrote:
>> On 08/01/2016 10:28 AM, Mark Brown wrote:
>>> On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote:
>
>>>> + p->clk = devm_clk_get(dev, NULL);
>>>> + if (IS_ERR(p->clk))
>>>> + goto out_unmap;
>
>>> We're now just using the normal clock API which is good but I'm now
>>> unclear what is going to ensure that the clock is there - is there some
>>> other change elsewhere that I'm not aware of?
>
>> The clock is an integral part of the SoC and is always running, so it will
>> always be there. All we want to know is the frequency, which is supplied by
>> the device tree clock-bindings framework
>
> So there's something there that registers the clock?
Yes, when using OF device tree, standard device probing registers the clock.
> What is that thing on ACPI systems?
I don't know if it works ACPI, or if ACPI even has support for the clock
framework. But does it matter? We are not currently using ACPI on
systems where this driver is used.
In the future, if we ever need ACPI support, we will add support for it.
David.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-01 22:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 8:31 [PATCH v2 0/2] SPI ThunderX driver Jan Glauber
2016-07-28 8:31 ` Jan Glauber
2016-07-28 8:31 ` [PATCH v2 1/2] spi: octeon: Split driver into Octeon specific and common parts Jan Glauber
2016-08-01 17:36 ` Mark Brown
2016-08-01 17:36 ` Mark Brown
2016-07-28 8:31 ` [PATCH v2 2/2] spi: octeon: Add thunderx driver Jan Glauber
2016-07-28 8:31 ` Jan Glauber
2016-08-01 17:28 ` Mark Brown
2016-08-01 17:28 ` Mark Brown
2016-08-01 18:31 ` David Daney
2016-08-01 18:49 ` Mark Brown
2016-08-01 18:49 ` Mark Brown
2016-08-01 19:02 ` David Daney [this message]
2016-08-01 19:02 ` David Daney
2016-08-02 21:30 ` Mark Brown
2016-08-02 21:30 ` Mark Brown
2016-08-02 21:49 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579F9CDE.5050207@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=broonie@kernel.org \
--cc=david.daney@cavium.com \
--cc=jglauber@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.