From: akpm@linux-foundation.org
To: torvalds@linux-foundation.org, mm-commits@vger.kernel.org,
akpm@linux-foundation.org, mgorman@techsingularity.net,
hannes@cmpxchg.org, minchan@kernel.org, vbabka@suse.cz
Subject: [patch 056/101] mm, vmscan: remove redundant check in shrink_zones()
Date: Thu, 28 Jul 2016 15:47:20 -0700 [thread overview]
Message-ID: <579a8b78.L6XUEuhOTBJsNA1o%akpm@linux-foundation.org> (raw)
From: Mel Gorman <mgorman@techsingularity.net>
Subject: mm, vmscan: remove redundant check in shrink_zones()
As pointed out by Minchan Kim, shrink_zones() checks for populated zones
in a zonelist but a zonelist can never contain unpopulated zones. While
it's not related to the node-lru series, it can be cleaned up now.
Link: http://lkml.kernel.org/r/1468853426-12858-2-git-send-email-mgorman@techsingularity.net
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Suggested-by: Minchan Kim <minchan@kernel.org>
Acked-by: Minchan Kim <minchan@kernel.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/vmscan.c | 3 ---
1 file changed, 3 deletions(-)
diff -puN mm/vmscan.c~mm-vmscan-remove-redundant-check-in-shrink_zones mm/vmscan.c
--- a/mm/vmscan.c~mm-vmscan-remove-redundant-check-in-shrink_zones
+++ a/mm/vmscan.c
@@ -2605,9 +2605,6 @@ static void shrink_zones(struct zonelist
for_each_zone_zonelist_nodemask(zone, z, zonelist,
sc->reclaim_idx, sc->nodemask) {
- if (!populated_zone(zone))
- continue;
reply other threads:[~2016-07-28 22:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579a8b78.L6XUEuhOTBJsNA1o%akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.