From: "\"Zhou, Wenjian/周文剑\"" <zhouwj-fnst@cn.fujitsu.com> To: Baoquan He <bhe@redhat.com> Cc: <linux-kernel@vger.kernel.org>, <kexec@lists.infradead.org>, <dyoung@redhat.com>, <d.hatayama@jp.fujitsu.com> Subject: Re: [PATCH v2] Documentation: kdump: add description of bringing up SMP dump-capture kernel Date: Tue, 2 Aug 2016 16:49:01 +0800 [thread overview] Message-ID: <57A05E7D.90101@cn.fujitsu.com> (raw) In-Reply-To: <20160802074602.GA3663@x1.redhat.com> Hi Baoquan, On 08/02/2016 03:46 PM, Baoquan He wrote: > Hi Wenjian, > > On 08/01/16 at 08:23am, Zhou Wenjian wrote: >> v1->v2: change nr_cpus to maxcpus >> >> SMP dump-capture kernel is useful to improve the performance of kdump in >> some cases. So add the description of bringing up SMP dump-capture kernel. >> >> Signed-off-by: Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com> > > Discussed with people, it could be better to adjust the > description about nr_cpus and maxcpus part. I think you can still > describe nr_cpus/maxcpus in patch 1/2, and keep parallel dumping part in > 2/2. > > Originally maxcpus=1 is used for all ARCHes. Later people found > nr_cpus=1 is better since nr_cpus decides the number of possible cpu > while maxcpus decides the max working cpu after system boot. So nr_cpus > can save memory because percpu will pre-allocate memory for each > possible cpu for hotplug. So on x86 nr_cpus is used because much memory > can be saved if possible cpu number is very large. > > So you can mention that both maxcpus and nr_cpus can be used but nr_cpus > has advantage if it has been implemented in some ARCHes like x86_64. And > I guess you mush have tested parallel dumping feature with nr_cpus > specified, it makes sense to tell people with the real situation. > I think it is better to describe the difference in somewhere else. Maybe, it's a good choice which just replace maxcpus by maxcpus/nr_cpus. Then user can choose maxcpus or nr_cpus. What do you think about it? -- Thanks Zhou > Thanks > Baoquan > >> --- >> Documentation/kdump/kdump.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt >> index 88ff63d..c5762b7 100644 >> --- a/Documentation/kdump/kdump.txt >> +++ b/Documentation/kdump/kdump.txt >> @@ -394,6 +394,12 @@ Notes on loading the dump-capture kernel: >> dump. Hence generally it is useful either to build a UP dump-capture >> kernel or specify maxcpus=1 option while loading dump-capture kernel. >> >> +* We should bring up a SMP dump-capture kernel if we intend to use multi-threads >> + programs with it, such as parallel dump feature of makedumpfile. Otherwise, >> + the multi-threads program may have a great performance degradation. >> + To bring up a SMP dump-capture kernel, we should specify maxcpus=[X] and >> + disable_cpu_apic=[Y] options while loading it. >> + >> * For s390x there are two kdump modes: If a ELF header is specified with >> the elfcorehdr= kernel parameter, it is used by the kdump kernel as it >> is done on all other architectures. If no elfcorehdr= kernel parameter is >> -- >> 1.8.3.1 >> >> >> > >
WARNING: multiple messages have this Message-ID (diff)
From: "\"Zhou, Wenjian/周文剑\"" <zhouwj-fnst@cn.fujitsu.com> To: Baoquan He <bhe@redhat.com> Cc: dyoung@redhat.com, d.hatayama@jp.fujitsu.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Documentation: kdump: add description of bringing up SMP dump-capture kernel Date: Tue, 2 Aug 2016 16:49:01 +0800 [thread overview] Message-ID: <57A05E7D.90101@cn.fujitsu.com> (raw) In-Reply-To: <20160802074602.GA3663@x1.redhat.com> Hi Baoquan, On 08/02/2016 03:46 PM, Baoquan He wrote: > Hi Wenjian, > > On 08/01/16 at 08:23am, Zhou Wenjian wrote: >> v1->v2: change nr_cpus to maxcpus >> >> SMP dump-capture kernel is useful to improve the performance of kdump in >> some cases. So add the description of bringing up SMP dump-capture kernel. >> >> Signed-off-by: Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com> > > Discussed with people, it could be better to adjust the > description about nr_cpus and maxcpus part. I think you can still > describe nr_cpus/maxcpus in patch 1/2, and keep parallel dumping part in > 2/2. > > Originally maxcpus=1 is used for all ARCHes. Later people found > nr_cpus=1 is better since nr_cpus decides the number of possible cpu > while maxcpus decides the max working cpu after system boot. So nr_cpus > can save memory because percpu will pre-allocate memory for each > possible cpu for hotplug. So on x86 nr_cpus is used because much memory > can be saved if possible cpu number is very large. > > So you can mention that both maxcpus and nr_cpus can be used but nr_cpus > has advantage if it has been implemented in some ARCHes like x86_64. And > I guess you mush have tested parallel dumping feature with nr_cpus > specified, it makes sense to tell people with the real situation. > I think it is better to describe the difference in somewhere else. Maybe, it's a good choice which just replace maxcpus by maxcpus/nr_cpus. Then user can choose maxcpus or nr_cpus. What do you think about it? -- Thanks Zhou > Thanks > Baoquan > >> --- >> Documentation/kdump/kdump.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt >> index 88ff63d..c5762b7 100644 >> --- a/Documentation/kdump/kdump.txt >> +++ b/Documentation/kdump/kdump.txt >> @@ -394,6 +394,12 @@ Notes on loading the dump-capture kernel: >> dump. Hence generally it is useful either to build a UP dump-capture >> kernel or specify maxcpus=1 option while loading dump-capture kernel. >> >> +* We should bring up a SMP dump-capture kernel if we intend to use multi-threads >> + programs with it, such as parallel dump feature of makedumpfile. Otherwise, >> + the multi-threads program may have a great performance degradation. >> + To bring up a SMP dump-capture kernel, we should specify maxcpus=[X] and >> + disable_cpu_apic=[Y] options while loading it. >> + >> * For s390x there are two kdump modes: If a ELF header is specified with >> the elfcorehdr= kernel parameter, it is used by the kdump kernel as it >> is done on all other architectures. If no elfcorehdr= kernel parameter is >> -- >> 1.8.3.1 >> >> >> > > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-08-02 9:06 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-01 0:23 [PATCH v2] Documentation: kdump: add description of bringing up SMP dump-capture kernel Zhou Wenjian 2016-08-01 0:23 ` Zhou Wenjian 2016-08-02 7:46 ` Baoquan He 2016-08-02 7:46 ` Baoquan He 2016-08-02 8:49 ` "Zhou, Wenjian/周文剑" [this message] 2016-08-02 8:49 ` "Zhou, Wenjian/周文剑" 2016-08-02 14:09 ` Baoquan He 2016-08-02 14:09 ` Baoquan He
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=57A05E7D.90101@cn.fujitsu.com \ --to=zhouwj-fnst@cn.fujitsu.com \ --cc=bhe@redhat.com \ --cc=d.hatayama@jp.fujitsu.com \ --cc=dyoung@redhat.com \ --cc=kexec@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.