[PATCH] x86/hvm: Drop the info level HVM save/restore messages

[PATCH] x86/hvm: Drop the info level HVM save/restore messages

[Andrew Cooper]

These are not very useful at all, and overly voluminous since the domain
builder switched to using XEN_DOMCTL_{get,set}hvmcontext to construct HVM
domains.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
---
 xen/common/hvm/save.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/xen/common/hvm/save.c b/xen/common/hvm/save.c
index dd2c547..26b7a4b 100644
--- a/xen/common/hvm/save.c
+++ b/xen/common/hvm/save.c
@@ -173,8 +173,6 @@ int hvm_save(struct domain *d, hvm_domain_context_t *h)
         handler = hvm_sr_handlers[i].save;
         if ( handler != NULL ) 
         {
-            printk(XENLOG_G_INFO "HVM%d save: %s\n",
-                   d->domain_id, hvm_sr_handlers[i].name);
             if ( handler(d, h) != 0 ) 
             {
                 printk(XENLOG_G_ERR
@@ -247,8 +245,6 @@ int hvm_load(struct domain *d, hvm_domain_context_t *h)
         }
 
         /* Load the entry */
-        printk(XENLOG_G_INFO "HVM%d restore: %s %"PRIu16"\n", d->domain_id,
-               hvm_sr_handlers[desc->typecode].name, desc->instance);
         if ( handler(d, h) != 0 ) 
         {
             printk(XENLOG_G_ERR "HVM%d restore: failed to load entry %u/%u\n",
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] x86/hvm: Drop the info level HVM save/restore messages

[Jan Beulich]

>>> On 03.08.16 at 20:26, <andrew.cooper3@citrix.com> wrote:
> These are not very useful at all, and overly voluminous since the domain
> builder switched to using XEN_DOMCTL_{get,set}hvmcontext to construct HVM
> domains.

I have to admit that I like to have them for restore, but I'm with
you that they're quite useless for domain construction. Could we
alternatively switch them to dprintk() (or, to avoid file/line getting
printed, make them conditional upon !NDEBUG) and/or
XENLOG_G_DEBUG?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] x86/hvm: Drop the info level HVM save/restore messages

[Andrew Cooper]

On 04/08/16 08:41, Jan Beulich wrote:
>>>> On 03.08.16 at 20:26, <andrew.cooper3@citrix.com> wrote:
>> These are not very useful at all, and overly voluminous since the domain
>> builder switched to using XEN_DOMCTL_{get,set}hvmcontext to construct HVM
>> domains.
> I have to admit that I like to have them for restore, but I'm with
> you that they're quite useless for domain construction. Could we
> alternatively switch them to dprintk() (or, to avoid file/line getting
> printed, make them conditional upon !NDEBUG) and/or
> XENLOG_G_DEBUG?

That would be an improvement, but still leaves the domain construction
messages around (which is my real purpose here).

However, I can't think of any easy way of distinguishing domain
construction from restore.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] x86/hvm: Drop the info level HVM save/restore messages

[Jan Beulich]

>>> On 04.08.16 at 15:41, <andrew.cooper3@citrix.com> wrote:
> On 04/08/16 08:41, Jan Beulich wrote:
>>>>> On 03.08.16 at 20:26, <andrew.cooper3@citrix.com> wrote:
>>> These are not very useful at all, and overly voluminous since the domain
>>> builder switched to using XEN_DOMCTL_{get,set}hvmcontext to construct HVM
>>> domains.
>> I have to admit that I like to have them for restore, but I'm with
>> you that they're quite useless for domain construction. Could we
>> alternatively switch them to dprintk() (or, to avoid file/line getting
>> printed, make them conditional upon !NDEBUG) and/or
>> XENLOG_G_DEBUG?
> 
> That would be an improvement, but still leaves the domain construction
> messages around (which is my real purpose here).
> 
> However, I can't think of any easy way of distinguishing domain
> construction from restore.

Neither can I (does the ordering of the operations here vs memory
population perhaps differ?), but in that case I'd rather like to keep
the messages (but perhaps turn their severity down, albeit I guess
that wouldn't help you).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel