* [PATCH] xenbus: don't look up transaction IDs for ordinary writes
@ 2016-08-15 15:02 Jan Beulich
2016-08-24 17:43 ` [Xen-devel] " David Vrabel
2016-08-24 17:43 ` David Vrabel
0 siblings, 2 replies; 8+ messages in thread
From: Jan Beulich @ 2016-08-15 15:02 UTC (permalink / raw)
To: david.vrabel, boris.ostrovsky, Juergen Gross; +Cc: xen-devel, linux-kernel
This should really only be done for XS_TRANSACTION_END messages, or
else at least some of the xenstore-* tools don't work anymore.
Fixes: 0beef634b8 ("xenbus: don't BUG() on user mode induced condition")
Reported-by: Richard Schütz <rschuetz@uni-koblenz.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Richard Schütz <rschuetz@uni-koblenz.de>
---
drivers/xen/xenbus/xenbus_dev_frontend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 4.8-rc2/drivers/xen/xenbus/xenbus_dev_frontend.c
+++ 4.8-rc2-xen-xenbus-dev-write-oridinary/drivers/xen/xenbus/xenbus_dev_frontend.c
@@ -316,7 +316,7 @@ static int xenbus_write_transaction(unsi
rc = -ENOMEM;
goto out;
}
- } else {
+ } else if (msg_type == XS_TRANSACTION_END) {
list_for_each_entry(trans, &u->transactions, list)
if (trans->handle.id == u->u.msg.tx_id)
break;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Xen-devel] [PATCH] xenbus: don't look up transaction IDs for ordinary writes
2016-08-15 15:02 [PATCH] xenbus: don't look up transaction IDs for ordinary writes Jan Beulich
@ 2016-08-24 17:43 ` David Vrabel
2016-08-24 17:43 ` David Vrabel
1 sibling, 0 replies; 8+ messages in thread
From: David Vrabel @ 2016-08-24 17:43 UTC (permalink / raw)
To: Jan Beulich, david.vrabel, boris.ostrovsky, Juergen Gross
Cc: xen-devel, linux-kernel
On 15/08/16 16:02, Jan Beulich wrote:
> This should really only be done for XS_TRANSACTION_END messages, or
> else at least some of the xenstore-* tools don't work anymore.
Applied to for-linus-4.8b, thanks.
David
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xenbus: don't look up transaction IDs for ordinary writes
2016-08-15 15:02 [PATCH] xenbus: don't look up transaction IDs for ordinary writes Jan Beulich
2016-08-24 17:43 ` [Xen-devel] " David Vrabel
@ 2016-08-24 17:43 ` David Vrabel
1 sibling, 0 replies; 8+ messages in thread
From: David Vrabel @ 2016-08-24 17:43 UTC (permalink / raw)
To: Jan Beulich, david.vrabel, boris.ostrovsky, Juergen Gross
Cc: xen-devel, linux-kernel
On 15/08/16 16:02, Jan Beulich wrote:
> This should really only be done for XS_TRANSACTION_END messages, or
> else at least some of the xenstore-* tools don't work anymore.
Applied to for-linus-4.8b, thanks.
David
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xenbus: don't look up transaction IDs for ordinary writes
2016-08-16 10:07 ` Juergen Gross
2016-08-18 12:41 ` Ed Swierk
@ 2016-08-18 12:41 ` Ed Swierk
1 sibling, 0 replies; 8+ messages in thread
From: Ed Swierk @ 2016-08-18 12:41 UTC (permalink / raw)
To: Juergen Gross; +Cc: Jan Beulich, David Vrabel, Boris Ostrovsky, xen-devel, lkml
On Tue, Aug 16, 2016 at 3:07 AM, Juergen Gross <jgross@suse.com> wrote:
> On 15/08/16 17:02, Jan Beulich wrote:
>> This should really only be done for XS_TRANSACTION_END messages, or
>> else at least some of the xenstore-* tools don't work anymore.
>>
>> Fixes: 0beef634b8 ("xenbus: don't BUG() on user mode induced condition")
>> Reported-by: Richard Schütz <rschuetz@uni-koblenz.de>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Tested-by: Richard Schütz <rschuetz@uni-koblenz.de>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Confirmed that this patch fixes xenstore-read, xenstore-ls et al, on
stable kernel 4.4.17.
It should also go to 4.7, 4.6, 4.1, 3.18.
--Ed
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xenbus: don't look up transaction IDs for ordinary writes
2016-08-16 10:07 ` Juergen Gross
@ 2016-08-18 12:41 ` Ed Swierk
2016-08-18 12:41 ` Ed Swierk
1 sibling, 0 replies; 8+ messages in thread
From: Ed Swierk @ 2016-08-18 12:41 UTC (permalink / raw)
To: Juergen Gross; +Cc: xen-devel, Boris Ostrovsky, David Vrabel, Jan Beulich, lkml
On Tue, Aug 16, 2016 at 3:07 AM, Juergen Gross <jgross@suse.com> wrote:
> On 15/08/16 17:02, Jan Beulich wrote:
>> This should really only be done for XS_TRANSACTION_END messages, or
>> else at least some of the xenstore-* tools don't work anymore.
>>
>> Fixes: 0beef634b8 ("xenbus: don't BUG() on user mode induced condition")
>> Reported-by: Richard Schütz <rschuetz@uni-koblenz.de>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Tested-by: Richard Schütz <rschuetz@uni-koblenz.de>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Confirmed that this patch fixes xenstore-read, xenstore-ls et al, on
stable kernel 4.4.17.
It should also go to 4.7, 4.6, 4.1, 3.18.
--Ed
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xenbus: don't look up transaction IDs for ordinary writes
[not found] <57B1F5AE0200007800106092@suse.com>
@ 2016-08-16 10:07 ` Juergen Gross
2016-08-18 12:41 ` Ed Swierk
2016-08-18 12:41 ` Ed Swierk
2016-08-16 10:07 ` Juergen Gross
1 sibling, 2 replies; 8+ messages in thread
From: Juergen Gross @ 2016-08-16 10:07 UTC (permalink / raw)
To: Jan Beulich, David Vrabel, Boris Ostrovsky; +Cc: xen-devel, lkml
On 15/08/16 17:02, Jan Beulich wrote:
> This should really only be done for XS_TRANSACTION_END messages, or
> else at least some of the xenstore-* tools don't work anymore.
>
> Fixes: 0beef634b8 ("xenbus: don't BUG() on user mode induced condition")
> Reported-by: Richard Schütz <rschuetz@uni-koblenz.de>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Tested-by: Richard Schütz <rschuetz@uni-koblenz.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Thanks,
Juergen
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xenbus: don't look up transaction IDs for ordinary writes
[not found] <57B1F5AE0200007800106092@suse.com>
2016-08-16 10:07 ` Juergen Gross
@ 2016-08-16 10:07 ` Juergen Gross
1 sibling, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2016-08-16 10:07 UTC (permalink / raw)
To: Jan Beulich, David Vrabel, Boris Ostrovsky; +Cc: xen-devel, lkml
On 15/08/16 17:02, Jan Beulich wrote:
> This should really only be done for XS_TRANSACTION_END messages, or
> else at least some of the xenstore-* tools don't work anymore.
>
> Fixes: 0beef634b8 ("xenbus: don't BUG() on user mode induced condition")
> Reported-by: Richard Schütz <rschuetz@uni-koblenz.de>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Tested-by: Richard Schütz <rschuetz@uni-koblenz.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Thanks,
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] xenbus: don't look up transaction IDs for ordinary writes
@ 2016-08-15 15:02 Jan Beulich
0 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2016-08-15 15:02 UTC (permalink / raw)
To: david.vrabel, boris.ostrovsky, Juergen Gross; +Cc: xen-devel, linux-kernel
This should really only be done for XS_TRANSACTION_END messages, or
else at least some of the xenstore-* tools don't work anymore.
Fixes: 0beef634b8 ("xenbus: don't BUG() on user mode induced condition")
Reported-by: Richard Schütz <rschuetz@uni-koblenz.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Richard Schütz <rschuetz@uni-koblenz.de>
---
drivers/xen/xenbus/xenbus_dev_frontend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 4.8-rc2/drivers/xen/xenbus/xenbus_dev_frontend.c
+++ 4.8-rc2-xen-xenbus-dev-write-oridinary/drivers/xen/xenbus/xenbus_dev_frontend.c
@@ -316,7 +316,7 @@ static int xenbus_write_transaction(unsi
rc = -ENOMEM;
goto out;
}
- } else {
+ } else if (msg_type == XS_TRANSACTION_END) {
list_for_each_entry(trans, &u->transactions, list)
if (trans->handle.id == u->u.msg.tx_id)
break;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-08-24 17:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-15 15:02 [PATCH] xenbus: don't look up transaction IDs for ordinary writes Jan Beulich
2016-08-24 17:43 ` [Xen-devel] " David Vrabel
2016-08-24 17:43 ` David Vrabel
[not found] <57B1F5AE0200007800106092@suse.com>
2016-08-16 10:07 ` Juergen Gross
2016-08-18 12:41 ` Ed Swierk
2016-08-18 12:41 ` Ed Swierk
2016-08-16 10:07 ` Juergen Gross
-- strict thread matches above, loose matches on Subject: below --
2016-08-15 15:02 Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.