All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] builddeb: Skip gcc-plugins when not configured
@ 2016-08-15 17:36 Kees Cook
  2016-08-16  8:34 ` Michal Marek
  0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2016-08-15 17:36 UTC (permalink / raw)
  To: Michal Marek; +Cc: Frank Paulsen, Christian Kujau, linux-kernel, linux-kbuild

When attempting to build a Debian kernel package, the "scripts/gcc-plugins"
directory does not exist in the output tree unless CONFIG_GCC_PLUGINS=y.
To avoid errors when not defined, this wraps the failing "find" in a config
test.

Reported-by: Frank Paulsen <frobnic+lkml@gmail.com>
Tested-by: Christian Kujau <lists@nerdbynature.de>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
This should go into v4.8...
---
 scripts/package/builddeb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index e1c09e2f9be7..8ea9fd2b6573 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -332,7 +332,9 @@ if grep -q '^CONFIG_STACK_VALIDATION=y' $KCONFIG_CONFIG ; then
 	(cd $objtree; find tools/objtool -type f -executable) >> "$objtree/debian/hdrobjfiles"
 fi
 (cd $objtree; find arch/$SRCARCH/include Module.symvers include scripts -type f) >> "$objtree/debian/hdrobjfiles"
-(cd $objtree; find scripts/gcc-plugins -name \*.so -o -name gcc-common.h) >> "$objtree/debian/hdrobjfiles"
+if grep -q '^CONFIG_GCC_PLUGINS=y' $KCONFIG_CONFIG ; then
+	(cd $objtree; find scripts/gcc-plugins -name \*.so -o -name gcc-common.h) >> "$objtree/debian/hdrobjfiles"
+fi
 destdir=$kernel_headers_dir/usr/src/linux-headers-$version
 mkdir -p "$destdir"
 (cd $srctree; tar -c -f - -T -) < "$objtree/debian/hdrsrcfiles" | (cd $destdir; tar -xf -)
-- 
2.7.4


-- 
Kees Cook
Nexus Security

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] builddeb: Skip gcc-plugins when not configured
  2016-08-15 17:36 [PATCH] builddeb: Skip gcc-plugins when not configured Kees Cook
@ 2016-08-16  8:34 ` Michal Marek
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2016-08-16  8:34 UTC (permalink / raw)
  To: Kees Cook; +Cc: Frank Paulsen, Christian Kujau, linux-kernel, linux-kbuild

Dne 15.8.2016 v 19:36 Kees Cook napsal(a):
> When attempting to build a Debian kernel package, the "scripts/gcc-plugins"
> directory does not exist in the output tree unless CONFIG_GCC_PLUGINS=y.
> To avoid errors when not defined, this wraps the failing "find" in a config
> test.
> 
> Reported-by: Frank Paulsen <frobnic+lkml@gmail.com>
> Tested-by: Christian Kujau <lists@nerdbynature.de>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> This should go into v4.8...

Applied to kbuild.git#rc-fixes.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-16  8:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-15 17:36 [PATCH] builddeb: Skip gcc-plugins when not configured Kees Cook
2016-08-16  8:34 ` Michal Marek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.