From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/6] e1000e: drop unnecessary funtions
Date: Thu, 18 Aug 2016 15:38:00 +0800 [thread overview]
Message-ID: <57B565D8.2030409@cn.fujitsu.com> (raw)
In-Reply-To: <9BED61EB-EBF6-463A-A3D1-2E28C5690B64@daynix.com>
On 08/18/2016 01:23 PM, Dmitry Fleytman wrote:
>
>
>> On 17 Aug 2016, at 17:39, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
>>
>> Internal helper function: e1000e_init_msix(), e1000e_cleanup_msix()
>> is unnecessary, remove them all.
>
> Is there any reason to drop these functions?
> They exist to improve code readability and modularisation.
>
previous commit 66bf7d58d removed the corresponding function of msi, so,
keep the consistency is the reason
--
Yours Sincerely,
Cao jin
next prev parent reply other threads:[~2016-08-18 7:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 14:39 [Qemu-devel] [PATCH 0/6] Convert msix_init() to error Cao jin
2016-08-17 14:39 ` [Qemu-devel] [PATCH 1/6] msix_init: assert programming error Cao jin
2016-08-18 7:14 ` Markus Armbruster
2016-08-18 7:46 ` Cao jin
2016-08-17 14:39 ` [Qemu-devel] [PATCH 2/6] pci: Convert msix_init() to Error and fix callers to check it Cao jin
2016-08-18 7:55 ` Markus Armbruster
2016-08-19 8:11 ` Cao jin
2016-08-17 14:39 ` [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility Cao jin
2016-08-18 5:25 ` Dmitry Fleytman
2016-08-18 10:47 ` Paolo Bonzini
2016-08-18 13:11 ` Cao jin
2016-08-18 13:04 ` Paolo Bonzini
2016-08-18 13:25 ` Cao jin
2016-08-18 13:22 ` Paolo Bonzini
2016-08-17 14:39 ` [Qemu-devel] [PATCH 4/6] e1000e: drop unnecessary funtions Cao jin
2016-08-18 5:23 ` Dmitry Fleytman
2016-08-18 7:38 ` Cao jin [this message]
2016-08-17 14:39 ` [Qemu-devel] [PATCH 5/6] megasas: remove unnecessary megasas_use_msix() Cao jin
2016-08-17 14:39 ` [Qemu-devel] [PATCH 6/6] megasas: undo the overwrites of user configuration Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B565D8.2030409@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=armbru@redhat.com \
--cc=dmitry@daynix.com \
--cc=jasowang@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.